Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call For Participation: vectorize all Date/Time builtin functions #12101

Closed
37 tasks done
qw4990 opened this issue Sep 10, 2019 · 17 comments · Fixed by #16349
Closed
37 tasks done

Call For Participation: vectorize all Date/Time builtin functions #12101

qw4990 opened this issue Sep 10, 2019 · 17 comments · Fixed by #16349
Assignees
@qw4990
Labels
component/expression good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@qw4990
Copy link
Contributor

qw4990 commented Sep 10, 2019 •
edited
Loading

This issue is used to trace all vectorized Data/Time builtin functions, which is a part of #12058.

NOTE:

  1. Feel free to join us in the wg-vec-expr working group
  2. Please comment on this issue if you are working on any of the functions.

Note For Performance Challenge Teams: each PR on this issue has 50 score.

Prefer to implement them by go generate, see https://docs.google.com/document/d/17XdYo_EwYaWANqbjS3i3OVSz3oLlovU2fIo1bRx4YqA/edit#, and find your interest and take a job.

builtinAddDateStringStringSig
builtinAddDateStringIntSig
builtinAddDateStringRealSig
builtinAddDateStringDecimalSig
builtinAddDateIntStringSig
builtinAddDateIntIntSig
builtinAddDateIntRealSig
builtinAddDateIntDecimalSig
builtinAddDateDatetimeStringSig
builtinAddDateDatetimeIntSig
builtinAddDateDatetimeRealSig
builtinAddDateDatetimeDecimalSig
builtinAddDateDurationStringSig
builtinAddDateDurationIntSig
builtinAddDateDurationRealSig
builtinAddDateDurationDecimalSig

builtinSubDateStringStringSig
builtinSubDateStringIntSig
builtinSubDateStringRealSig
builtinSubDateStringDecimalSig
builtinSubDateIntStringSig
builtinSubDateIntIntSig
builtinSubDateIntRealSig
builtinSubDateIntDecimalSig
builtinSubDateDatetimeStringSig
builtinSubDateDatetimeIntSig
builtinSubDateDatetimeRealSig
builtinSubDateDatetimeDecimalSig
builtinSubDateDurationStringSig
builtinSubDateDurationIntSig
builtinSubDateDurationRealSig
builtinSubDateDurationDecimalSig

builtinSubDateAndDurationSig
builtinSubDateAndStringSig
builtinSubDatetimeAndDurationSig
builtinSubDatetimeAndStringSig
builtinSubDurationAndDurationSig
builtinSubDurationAndStringSig
builtinSubStringAndDurationSig
builtinSubStringAndStringSig
builtinSubTimeDateTimeNullSig
builtinSubTimeDurationNullSig
builtinSubTimeStringNullSig
@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. component/expression labels Sep 10, 2019
@qw4990 qw4990 changed the title Call For Participation: vectorize all date/time builtin functions Call For Participation: vectorize all Date/Time builtin functions Sep 10, 2019
@qw4990 qw4990 mentioned this issue Sep 10, 2019
Closed
This was referenced Sep 18, 2019
Merged
Merged
Merged
This was referenced Oct 10, 2019
Merged
Merged
@tsthght
Copy link
Contributor

tsthght commented Oct 12, 2019

let me fix:
builtinTimeAnyValueSig
builtinNameConstTimeSig

This was referenced Oct 12, 2019
Merged
Merged
@ekalinin ekalinin mentioned this issue Oct 20, 2019
Merged
@ekalinin ekalinin mentioned this issue Oct 22, 2019
Merged
@mmyj
Copy link
Member

mmyj commented Oct 23, 2019

let me fix:
'builtinUTCTimeWithArgSig'
'builtinUTCTimestampWithArgSig'
'builtinUTCTimeWithoutArgSig'
'builtinUTCTimestampWithoutArgSig'

@mmyj mmyj mentioned this issue Oct 23, 2019
Merged
@ekalinin ekalinin mentioned this issue Oct 23, 2019
Merged
@mmyj mmyj mentioned this issue Oct 26, 2019
Merged
@ekalinin ekalinin mentioned this issue Oct 26, 2019
Merged
@icditwang icditwang mentioned this issue Nov 5, 2019
Merged
@wangxin0327 wangxin0327 mentioned this issue Nov 5, 2019
Closed
@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

@mmyj this is not a performance challenge issue.

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Nov 6, 2019

@mmyj this is not a performance challenge issue.

@mmyj mmyj mentioned this issue Nov 6, 2019
Merged
This was referenced Nov 6, 2019
Merged
Merged
@ekalinin ekalinin mentioned this issue Nov 15, 2019
Merged
@pingyu
Copy link
Contributor

pingyu commented Nov 16, 2019

Let me fix:
builtinStrToDateDateSig

@pingyu pingyu mentioned this issue Nov 16, 2019
Merged
@icditwang
Copy link
Contributor

let me fix:
builtinAddDateStringDecimalSig
builtinAddDateIntStringSig
builtinAddDateIntRealSig
builtinAddDateIntDecimalSig

This was referenced Nov 19, 2019
Closed
Closed
@icditwang icditwang mentioned this issue Nov 20, 2019
Closed
@AerysNan AerysNan mentioned this issue Nov 20, 2019
Merged
@zhongshanhao zhongshanhao mentioned this issue Nov 20, 2019
Merged
@SilvaXiang
Copy link
Contributor

let me fix builtinSubTimeDateTimeNullSig

This was referenced Nov 22, 2019
Closed
Merged
@icditwang icditwang mentioned this issue Nov 22, 2019
Closed
@ekalinin
Copy link
Contributor

JFYI:

There's a plan to to use template package to generate some built-in functions:

Functions like builtinAddDate*, builtinSubDate* are in that list.

@catror catror mentioned this issue Nov 23, 2019
Merged
@icditwang icditwang mentioned this issue Nov 25, 2019
Closed
@ekalinin ekalinin mentioned this issue Dec 1, 2019
Closed
@glorv glorv mentioned this issue Dec 6, 2019
Merged
@doki23
Copy link

doki23 commented Mar 18, 2020

/pick-up-challenge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2020

You can file a PR directly without picking up because this issue is a collection of multiple tasks. Each PR related to this issue will rewarded 50 score when merged.

@qw4990 qw4990 mentioned this issue Apr 14, 2020
Merged
@sre-bot sre-bot mentioned this issue Apr 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qw4990 qw4990

Labels
component/expression good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expression: implement vectorized evaluation for builtinConvertTzSig qw4990/tidb