Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized evaluation for builtinConvertTzSig (#16349) #16392

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 15, 2020

cherry-pick #16349 to release-4.0


What problem does this PR solve?

Issue Number: close #12101

Problem Summary: implement vectorized evaluation for builtinConvertTzSig

Check List

Tests

  • Unit test

@sre-bot sre-bot requested a review from a team as a code owner April 15, 2020 06:08
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2020
@zz-jason
Copy link
Member

/run-sqllogic-test-2
/run-integration-copr-test

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. status/PTAL labels Apr 15, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

Your auto merge job has been accepted, waiting for 16395

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 15, 2020

@sre-bot merge failed.

@zz-jason zz-jason merged commit 007d59d into pingcap:release-4.0 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants