Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinTidbParseTsoSig #13615

Merged
merged 9 commits into from
Nov 21, 2019
Merged

expression: implement vectorized evaluation for builtinTidbParseTsoSig #13615

merged 9 commits into from
Nov 21, 2019

Conversation

AerysNan
Copy link
Contributor

Signed-off-by: AerysNan aerysnan@gmail.com

PCP #12101

What problem does this PR solve?

Implement vectorized evaluation for builtinTidbParseTsoSig.

What is changed and how it works?

BenchmarkVectorizedBuiltinTimeFunc/builtinTidbParseTsoSig-VecBuiltinFunc-4                  6111            186963 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinTidbParseTsoSig-NonVecBuiltinFunc-4               5262            216277 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test

@AerysNan
vectorize builtinTidbParseTsoSig
599fe63 
Signed-off-by: AerysNan <aerysnan@gmail.com>
@AerysNan AerysNan requested a review from a team as a code owner November 20, 2019 05:22
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 20, 2019
@ghost ghost requested review from SunRunAway and wshwsh12 and removed request for a team November 20, 2019 05:22
@codecov
Copy link

codecov bot commented Nov 20, 2019 •
edited
Loading

Codecov Report

Merging #13615 into master will decrease coverage by 0.0786%.
The diff coverage is 59.2592%.

@@               Coverage Diff                @@
##             master     #13615        +/-   ##
================================================
- Coverage   79.9622%   79.8835%   -0.0787%     
================================================
  Files           473        473                
  Lines        115991     115801       -190     
================================================
- Hits          92749      92506       -243     
- Misses        15965      16003        +38     
- Partials       7277       7292        +15

SunRunAway
SunRunAway reviewed Nov 20, 2019
View reviewed changes
expression/builtin_time_vec.go Outdated Show resolved Hide resolved
expression/builtin_time_vec.go Outdated Show resolved Hide resolved
@AerysNan
fix
5c3bf57 
Signed-off-by: AerysNan <aerysnan@gmail.com>
Reminiscent
Reminiscent reviewed Nov 20, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 20, 2019
qw4990
qw4990 previously approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

Your auto merge job has been accepted, waiting for 13541, 13630

@qw4990
Copy link
Contributor

qw4990 commented Nov 20, 2019

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Nov 20, 2019

@AerysNan Please fix the CI problem:

[2019-11-20T13:19:21.169Z] gofmt (simplify)
[2019-11-20T13:19:27.787Z] expression/builtin_time_vec_test.go

It seems you should gofmt -w this file.

@AerysNan
format
124b821 
Signed-off-by: AerysNan <aerysnan@gmail.com>
@AerysNan
Copy link
Contributor Author

@qw4990 Thanks for your reminder, formatted.

@qw4990
Copy link
Contributor

qw4990 commented Nov 21, 2019

/run-all-tests

@qw4990 qw4990 merged commit 042cff4 into pingcap:master Nov 21, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 21, 2019

@AerysNan complete task #12101 and get 50 score, currerent score 250.

@AerysNan AerysNan deleted the vectorize/builtinTidbParseTsoSig branch November 21, 2019 02:42
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@AerysNan @XiaTianliang
expression: implement vectorized evaluation for `builtinTidbParseTsoS…
52be03d 
…ig` (pingcap#13615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@qw4990 qw4990 qw4990 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AerysNan @sre-bot @qw4990 @SunRunAway @Reminiscent @wshwsh12