Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinCastDurationAsTimeSig #13244

Merged
merged 8 commits into from
Nov 8, 2019
Merged

expression: implement vectorized evaluation for builtinCastDurationAsTimeSig #13244

merged 8 commits into from
Nov 8, 2019

Conversation

ekalinin
Copy link
Contributor

@ekalinin ekalinin commented Nov 7, 2019

PCP #12101

What problem does this PR solve?

This PR implements vectorized builtinCastDurationAsTimeSig.

What is changed and how it works?

➜ make vectorized-bench VB_FILE=Cast VB_FUNC=builtinCastDurationAsTimeSig
cd ./expression && \
	go test -v -benchmem \
		-bench=BenchmarkVectorizedBuiltinCastFunc \
		-run=BenchmarkVectorizedBuiltinCastFunc \
		-args "builtinCastDurationAsTimeSig"
goos: linux
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinCastFunc/builtinCastDurationAsTimeSig-VecBuiltinFunc-12         	    4983	    228006 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastDurationAsTimeSig-NonVecBuiltinFunc-12      	    4659	    252440 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/pingcap/tidb/expression	2.389s

Check List

Tests

  • Unit test
  • Integration test

@ekalinin ekalinin requested a review from a team as a code owner November 7, 2019 09:17
@sre-bot
Copy link
Contributor

sre-bot commented Nov 7, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 7, 2019
@ghost ghost requested review from SunRunAway and wshwsh12 and removed request for a team November 7, 2019 09:18
@codecov
Copy link

codecov bot commented Nov 7, 2019 •
edited
Loading

Codecov Report

Merging #13244 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13244   +/-   ##
===========================================
  Coverage   80.2561%   80.2561%           
===========================================
  Files           469        469           
  Lines        111802     111802           
===========================================
  Hits          89728      89728           
  Misses        15183      15183           
  Partials       6891       6891

SunRunAway
SunRunAway reviewed Nov 7, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wshwsh12
wshwsh12 approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Nov 8, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 8, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 8, 2019

@ekalinin merge failed.

@ngaut ngaut merged commit c793247 into pingcap:master Nov 8, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 8, 2019

@ekalinin complete task #12101 and get 50 score, currerent score 50.

@ekalinin ekalinin deleted the vec-builtinCastDurationAsTimeSig branch November 8, 2019 08:33
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@ekalinin @XiaTianliang
expression: implement vectorized evaluation for builtinCastDurationAs…
d8e64f6 
…TimeSig (pingcap#13244)

* expression: implement vectorized evaluation for builtinCastDurationAsTimeSig

* expression: use GoDurations instead of GetDuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ekalinin @sre-bot @SunRunAway @wshwsh12 @ngaut