Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinLastDaySig #13503

Merged
merged 9 commits into from
Nov 20, 2019
Merged

expression: implement vectorized evaluation for builtinLastDaySig #13503

merged 9 commits into from
Nov 20, 2019

Conversation

ekalinin
Copy link
Contributor

PCP #12101

What problem does this PR solve?

This PR implements vectorized builtinLastDaySig

What is changed and how it works?

➜ make vectorized-bench VB_FILE=Time VB_FUNC=builtinLastDaySig                           
cd ./expression && \
	go test -v -benchmem \
		-bench=BenchmarkVectorizedBuiltinTimeFunc \
		-run=BenchmarkVectorizedBuiltinTimeFunc \
		-args "builtinLastDaySig"
goos: linux
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinTimeFuncGenerated-12    	1000000000	         0.0728 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinLastDaySig-VecBuiltinFunc-12         	   66322	     18120 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinLastDaySig-NonVecBuiltinFunc-12      	   23734	     50426 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/pingcap/tidb/expression	4.308s

Check List

Tests

  • Unit test
  • Integration test

@ekalinin ekalinin requested a review from a team as a code owner November 15, 2019 21:44
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 15, 2019
@ghost ghost requested review from qw4990 and SunRunAway and removed request for a team November 15, 2019 21:45
SunRunAway
SunRunAway reviewed Nov 19, 2019
View reviewed changes
expression/builtin_time_vec.go Show resolved Hide resolved
expression/builtin_time_vec.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 19, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@52afe66). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13503   +/-   ##
===========================================
  Coverage          ?   80.5948%           
===========================================
  Files             ?        473           
  Lines             ?     117448           
  Branches          ?          0           
===========================================
  Hits              ?      94657           
  Misses            ?      15544           
  Partials          ?       7247

@ekalinin ekalinin mentioned this pull request Nov 19, 2019
Closed
@sre-bot sre-bot closed this Nov 20, 2019
@ekalinin
Copy link
Contributor Author

Why it was closed?

@ekalinin
Copy link
Contributor Author

ekalinin commented Nov 20, 2019 •
edited
Loading

/re-open

@ekalinin
Copy link
Contributor Author

ekalinin commented Nov 20, 2019 •
edited
Loading

@SunRunAway @qw4990 could you reopen the PR?

@Reminiscent Reminiscent reopened this Nov 20, 2019
Reminiscent
Reminiscent reviewed Nov 20, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added status/LGT1 Indicates that a PR has LGTM 1. and removed status/ReqChange labels Nov 20, 2019
SunRunAway
SunRunAway previously approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@SunRunAway SunRunAway removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 20, 2019
@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Nov 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Nov 20, 2019

/run-all-tests

@qw4990 qw4990 merged commit 9b4943f into pingcap:master Nov 20, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 20, 2019

@ekalinin complete task #12101 and get 50 score, currerent score 550.

@ekalinin ekalinin deleted the vec-builtinLastDaySig branch November 20, 2019 13:31
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@ekalinin @XiaTianliang
expression: implement vectorized evaluation for builtinLastDaySig (pi…
9a1ba66 
…ngcap#13503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@qw4990 qw4990 qw4990 approved these changes

@SunRunAway SunRunAway SunRunAway left review comments

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ekalinin @sre-bot @qw4990 @SunRunAway @Reminiscent