expression: implement vectorized evaluation for 'builtinLastDaySig' #13592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
|
Codecov Report
@@ Coverage Diff @@
## master #13592 +/- ##
================================================
+ Coverage 79.8789% 79.8803% +0.0014%
================================================
Files 472 472
Lines 115516 115534 +18
================================================
+ Hits 92273 92289 +16
- Misses 15981 15986 +5
+ Partials 7262 7259 -3 |
wshwsh12
reviewed
Nov 19, 2019
Comment on lines
+724
to
+728
| buf, err := b.bufAllocator.get(types.ETDatetime, n) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer b.bufAllocator.put(buf) |
There was a problem hiding this comment.
- We can use result to get the son's result directly without alloc a buffer.
- We need to call b.arg[0].VecEvalTime to get son's result.
| result.ResizeTime(n, false) | ||
| times := result.Times() | ||
| for i := 0; i < n; i++ { | ||
| tm := ds[i].Time |
There was a problem hiding this comment.
We need check Null before calculate.
| tm := ds[i].Time | ||
| year, month, day := tm.Year(), tm.Month(), tm.Day() | ||
| if month == 0 || day == 0 { | ||
| return handleInvalidTimeError(b.ctx, types.ErrIncorrectDatetimeValue.GenWithStackByArgs(buf.GetString(i))) |
There was a problem hiding this comment.
If the error can be handled, we should set null and continue.
|
I'm sorry, but this function is vectorized by #13503 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
expression: implement vectorized evaluation for 'builtinLastDaySig'
What is changed and how it works?
goos: windows
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinTimeFuncGenerated-2 1000000000 0.0610 ns/op 0 B/op 0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc-2 1000000000 0.0350 ns/op 0 B/op 0 allocs/op
PASS
Check List
Tests