Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: copy original content instead of formatted content for CopyLink #802

Merged
merged 5 commits into from
Nov 24, 2020

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Nov 20, 2020

fix #798 in step 1

Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just fix the incorrect format, instead of copying an unformatted SQL.. Since current copy problem only exists in very rare cases, while copying a formatted SQL is widely used.

@baurine
Copy link
Collaborator Author

baurine commented Nov 23, 2020

According to the comment in #798 (comment) , we can supply "Copy Original" and "Copy Formatted" buttons both.

The effects:

WeCom20201123-121229@2x

WeCom20201123-121300@2x

@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: d609231

@ti-chi-bot ti-chi-bot merged commit a99a643 into pingcap:master Nov 24, 2020
@baurine baurine deleted the fix-copy-clipboard branch November 24, 2020 14:37
breezewish pushed a commit that referenced this pull request Nov 26, 2020
…802)

* ui: copy original content instead of formatted content for CopyLink component

* Revert "ui: copy original content instead of formatted content for CopyLink component"

This reverts commit fa2a709.

* ui: support copy original sql and formatted sql

* refine

* remove tooltip
breezewish added a commit that referenced this pull request Nov 26, 2020
* misc: Increase ulimit to 65535 for test env (#756)
* test: Fix frontend CI (#752)
* ui: fix dayjs i18n (#755)
* ui: handle error globally (#757)
* statement, slow_query: support all fields in list page (#749)
* ui: memorize expand/collapse full text in detail pages (#775)
* ui: break loop dependencies (#771)
* ui: fix browser compatibility check (#776)
* ui: Refine store location, add zoom and pan (#772)
* ui: show disk usage information for statement and slow query (#777)
* ui: use qps instead of ops (#786)
* statement: support export (#778)
*: Fix slow query and start_ts not working in some cases (#793)
* ui: fix errors doesn't display (#794)
* ui: fix the error message doesn't show correct (#799)
* slow_queries: support export (#792)
* ui: add MySqlFormatter to customize the sql formatter (#805)
*: fix query statement detail error cause by round (#806)
* ui: copy original content instead of formatted content for CopyLink (#802)
* add min height of topology canvas (#804)
* metrics: Support customize Prometheus address (#808)
* clusterinfo: Refine (#815)
* ui: Open statement and slow log in new tab (#816)
* ui: add more time field for slow query detail page (#810)
* slowlog: Improve descriptions (#817)
* build: add action to check release-version is changed for release branch
* Release v2020.11.26.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Digester produces invalid sql for selecting global variables
3 participants