ui: break loop dependencies #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baurine
reviewed
Oct 20, 2020
baurine
reviewed
Oct 20, 2020
baurine
reviewed
Oct 20, 2020
baurine
reviewed
Oct 20, 2020
| avg_mem: genDerivedBarSources('avg_mem', 'max_mem'), | ||
| sum_errors: ['sum_errors', 'sum_warnings'], | ||
| related_schemas: ['table_names'], | ||
| } |
There was a problem hiding this comment.
In fact, this solution is a bit similar to the old version that was replaced by bringing sourceFields and IColumnWithSourceFields, aka put the ref columns in an individual object, but this is better than before by reusing it with statementColumns() or slowQueryColumns(). So I think it's fine.
@breeswish how do you think about it?
baurine
reviewed
Oct 20, 2020
baurine
reviewed
Oct 21, 2020
ti-srebot
approved these changes
Oct 21, 2020
breezewish
pushed a commit
that referenced
this pull request
Nov 26, 2020
breezewish
added a commit
that referenced
this pull request
Nov 26, 2020
* misc: Increase ulimit to 65535 for test env (#756) * test: Fix frontend CI (#752) * ui: fix dayjs i18n (#755) * ui: handle error globally (#757) * statement, slow_query: support all fields in list page (#749) * ui: memorize expand/collapse full text in detail pages (#775) * ui: break loop dependencies (#771) * ui: fix browser compatibility check (#776) * ui: Refine store location, add zoom and pan (#772) * ui: show disk usage information for statement and slow query (#777) * ui: use qps instead of ops (#786) * statement: support export (#778) *: Fix slow query and start_ts not working in some cases (#793) * ui: fix errors doesn't display (#794) * ui: fix the error message doesn't show correct (#799) * slow_queries: support export (#792) * ui: add MySqlFormatter to customize the sql formatter (#805) *: fix query statement detail error cause by round (#806) * ui: copy original content instead of formatted content for CopyLink (#802) * add min height of topology canvas (#804) * metrics: Support customize Prometheus address (#808) * clusterinfo: Refine (#815) * ui: Open statement and slow log in new tab (#816) * ui: add more time field for slow query detail page (#810) * slowlog: Improve descriptions (#817) * build: add action to check release-version is changed for release branch * Release v2020.11.26.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
calculating selectedFields no longer need tableColumns
close #764