Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export slow queries #792

Merged
merged 16 commits into from
Nov 24, 2020
Merged

export slow queries #792

merged 16 commits into from
Nov 24, 2020

Conversation

unbyte
Copy link
Contributor

@unbyte unbyte commented Nov 6, 2020

close #569

Export the slow query statements as .csv format file, like #778

@unbyte unbyte marked this pull request as draft November 6, 2020 15:05
@unbyte unbyte marked this pull request as ready for review November 7, 2020 12:39
@unbyte
Copy link
Contributor Author

unbyte commented Nov 7, 2020

known issue:
there should be a loop to convert slice of specific type to slice of interface{}, as a result, the performance is affected (though not significant)

@baurine
Copy link
Collaborator

baurine commented Nov 9, 2020

most LGTM, good job!

The CI is failed, please run make dev in local and commit the changes.

image

image

@breezewish
Copy link
Member

Good job!

@unbyte
Copy link
Contributor Author

unbyte commented Nov 12, 2020

PTAL @baurine

Copy link
Collaborator

@baurine baurine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM, @baurine PTAL

@baurine
Copy link
Collaborator

baurine commented Nov 23, 2020

others LGTM

@baurine baurine merged commit 599d34f into pingcap:master Nov 24, 2020
breezewish pushed a commit that referenced this pull request Nov 26, 2020
breezewish added a commit that referenced this pull request Nov 26, 2020
* misc: Increase ulimit to 65535 for test env (#756)
* test: Fix frontend CI (#752)
* ui: fix dayjs i18n (#755)
* ui: handle error globally (#757)
* statement, slow_query: support all fields in list page (#749)
* ui: memorize expand/collapse full text in detail pages (#775)
* ui: break loop dependencies (#771)
* ui: fix browser compatibility check (#776)
* ui: Refine store location, add zoom and pan (#772)
* ui: show disk usage information for statement and slow query (#777)
* ui: use qps instead of ops (#786)
* statement: support export (#778)
*: Fix slow query and start_ts not working in some cases (#793)
* ui: fix errors doesn't display (#794)
* ui: fix the error message doesn't show correct (#799)
* slow_queries: support export (#792)
* ui: add MySqlFormatter to customize the sql formatter (#805)
*: fix query statement detail error cause by round (#806)
* ui: copy original content instead of formatted content for CopyLink (#802)
* add min height of topology canvas (#804)
* metrics: Support customize Prometheus address (#808)
* clusterinfo: Refine (#815)
* ui: Open statement and slow log in new tab (#816)
* ui: add more time field for slow query detail page (#810)
* slowlog: Improve descriptions (#817)
* build: add action to check release-version is changed for release branch
* Release v2020.11.26.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirement Request: Data Export in slow query
4 participants