Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: copy original content instead of formatted content for CopyLink #802

Merged
merged 5 commits into from
Nov 24, 2020
Merged

ui: copy original content instead of formatted content for CopyLink #802

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fa2a709
ui: copy original content instead of formatted content for CopyLink c…
baurine Nov 20, 2020
5b62080
Revert "ui: copy original content instead of formatted content for Co…
baurine Nov 23, 2020
83c66b7
ui: support copy original sql and formatted sql
baurine Nov 23, 2020
79226a4
refine
baurine Nov 23, 2020
d609231
remove tooltip
baurine Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ui/lib/apps/SlowQuery/pages/Detail/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { useLocalStorageState } from '@umijs/hooks'
import client from '@lib/client'
import { useClientRequest } from '@lib/utils/useClientRequest'
import { buildQueryFn, parseQueryFn } from '@lib/utils/query'
import formatSql from '@lib/utils/formatSql'
import {
AnimatedSkeleton,
CardTabs,
Expand Down Expand Up @@ -91,7 +90,7 @@ function DetailPage() {
expanded={detailExpand.query}
onClick={toggleQuery}
/>
<CopyLink data={formatSql(data.query!)} />
<CopyLink data={data.query!} />
</Space>
}
>
Expand All @@ -117,7 +116,7 @@ function DetailPage() {
expanded={detailExpand.prev_query}
onClick={togglePrevQuery}
/>
<CopyLink data={formatSql(data.prev_stmt!)} />
<CopyLink data={data.prev_stmt!} />
</Space>
}
>
Expand Down
5 changes: 2 additions & 3 deletions ui/lib/apps/Statement/pages/Detail/PlanDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
} from '@lib/components'
import { useClientRequest } from '@lib/utils/useClientRequest'
import client from '@lib/client'
import formatSql from '@lib/utils/formatSql'

import { IPageQuery } from '.'
import TabBasic from './PlanDetailTabBasic'
Expand Down Expand Up @@ -96,7 +95,7 @@ function PlanDetail({ query }: IPlanDetailProps) {
expanded={detailExpand.query}
onClick={toggleQuery}
/>
<CopyLink data={formatSql(data.query_sample_text)} />
<CopyLink data={data.query_sample_text} />
</Space>
}
>
Expand All @@ -120,7 +119,7 @@ function PlanDetail({ query }: IPlanDetailProps) {
expanded={detailExpand.prev_query}
onClick={togglePrevQuery}
/>
<CopyLink data={formatSql(data.prev_sample_text)} />
<CopyLink data={data.prev_sample_text} />
</Space>
}
>
Expand Down
3 changes: 1 addition & 2 deletions ui/lib/apps/Statement/pages/Detail/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {
TextWithInfo,
} from '@lib/components'
import CopyLink from '@lib/components/CopyLink'
import formatSql from '@lib/utils/formatSql'
import { buildQueryFn, parseQueryFn } from '@lib/utils/query'
import { useClientRequest } from '@lib/utils/useClientRequest'

Expand Down Expand Up @@ -99,7 +98,7 @@ function DetailPage() {
expanded={sqlExpanded}
onClick={toggleSqlExpanded}
/>
<CopyLink data={formatSql(plans[0].digest_text!)} />
<CopyLink data={plans[0].digest_text!} />
</Space>
}
>
Expand Down