Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sql optimization-related docs to toc #5561

Merged
merged 12 commits into from
Nov 10, 2021
Merged

Add sql optimization-related docs to toc #5561

merged 12 commits into from
Nov 10, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Feb 22, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn added translation/from-docs This PR is translated from a PR in pingcap/docs. size/large Changes of a large size. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Feb 22, 2021
TomShawn
TomShawn commented Feb 22, 2021
View reviewed changes
@TomShawn TomShawn added the type/refactor The issue belongs to a refactor work. label Feb 22, 2021
@TomShawn TomShawn marked this pull request as ready for review February 23, 2021 04:12
@ti-srebot
Copy link
Contributor

@SunRunAway, @zz-jason, @qw4990, @lzmhhh123, PTAL.

@ti-srebot
Copy link
Contributor

@SunRunAway, @zz-jason, @qw4990, @lzmhhh123, PTAL.

@SunRunAway
Copy link
Contributor

/uncc @SunRunAway

@ti-srebot ti-srebot removed the request for review from SunRunAway February 26, 2021 11:17
@ti-srebot
Copy link
Contributor

@zz-jason, @qw4990, @lzmhhh123, PTAL.

@ti-srebot
Copy link
Contributor

@lzmhhh123, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@ti-srebot
Copy link
Contributor

@lzmhhh123, @zz-jason, @qw4990, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@lzmhhh123, @zz-jason, @qw4990, PTAL.

@ti-srebot
Copy link
Contributor

@lzmhhh123, @zz-jason, @qw4990, PTAL.

@windtalker windtalker mentioned this pull request Mar 19, 2021
Merged
11 tasks
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2021
winoros
winoros reviewed Oct 11, 2021
View reviewed changes
explain-aggregation.md
@@ -175,3 +177,13 @@ Query OK, 0 rows affected (0.28 sec)
+------------------------------+---------+-----------+----------------------------+----------------------------------------------------------------------------------------------------+
5 rows in set (0.00 sec)
```

## 其他类型查询的执行计划
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that this part is not shown in the English side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. This PR is not a strict translation of the English version. Some parts are deleted from the English version (which I think should not be deleted). Please help confirm whether this part is needed or not. If yes, I'll add it to the English version later.

TOC.md
+ [聚合查询的执行计划](/explain-aggregation.md)
+ [视图查询的执行计划](/explain-views.md)
+ [分区查询的执行计划](/explain-partitions.md)
+ [开启 IndexMerge 查询的执行计划](/explain-index-merge.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one about the index merge is not included in English version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has an English page: https://docs.pingcap.com/tidb/dev/explain-index-merge/. It is missed in the English PR. I'll add it to the English TOC later.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Liuxiaozhen12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 10, 2021
@TomShawn
Copy link
Contributor Author

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e8059a8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2021
@TomShawn TomShawn merged commit 3aab170 into pingcap:master Nov 10, 2021
@TomShawn TomShawn deleted the toc-add-sql-optimization-related-docs branch November 10, 2021 03:39
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 10, 2021
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#5561
0ba7b89 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 10, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7452.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 10, 2021
@TomShawn @ti-chi-bot
Add sql optimization-related docs to toc (pingcap#5561)
4f0a8ff 
* Add sql optimization-related docs to toc

* Update explain-overview.md

* fix broken anchor

* refine language

* update TOC

* link to indexmerge

* Update explain-overview.md

* add mpp

* Update explain-overview.md
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 10, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7453.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 10, 2021
@TomShawn @ti-chi-bot
Add sql optimization-related docs to toc (pingcap#5561)
d27baa1 
* Add sql optimization-related docs to toc

* Update explain-overview.md

* fix broken anchor

* refine language

* update TOC

* link to indexmerge

* Update explain-overview.md

* add mpp

* Update explain-overview.md
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 10, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7454.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Nov 10, 2021
@TomShawn @ti-chi-bot
Add sql optimization-related docs to toc (pingcap#5561)
a3ec104 
* Add sql optimization-related docs to toc

* Update explain-overview.md

* fix broken anchor

* refine language

* update TOC

* link to indexmerge

* Update explain-overview.md

* add mpp

* Update explain-overview.md
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 10, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7455.

TomShawn added a commit that referenced this pull request Nov 10, 2021
@ti-chi-bot @TomShawn
Add sql optimization-related docs to toc (#5561) (#7454)
2b75e5b 
* Add sql optimization-related docs to toc

* Update explain-overview.md

* fix broken anchor

* refine language

* update TOC

* link to indexmerge

* Update explain-overview.md

* add mpp

* Update explain-overview.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Nov 10, 2021
@ti-chi-bot @TomShawn
Add sql optimization-related docs to toc (#5561) (#7453)
6e6fdf8 
* Add sql optimization-related docs to toc

* Update explain-overview.md

* fix broken anchor

* refine language

* update TOC

* link to indexmerge

* Update explain-overview.md

* add mpp

* Update explain-overview.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
ti-chi-bot added a commit that referenced this pull request Nov 10, 2021
@ti-chi-bot
Add sql optimization-related docs to toc (#5561) (#7455)
432fef4
TomShawn added a commit that referenced this pull request Nov 25, 2021
@ti-chi-bot @TomShawn
Add sql optimization-related docs to toc (#5561) (#7452)
3a0c033 
* This is an automated cherry-pick of #5561

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* Apply suggestions from code review

* Delete explain-mpp.md

* Apply suggestions from code review

* resolve conflict

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@Liuxiaozhen12 Liuxiaozhen12 Liuxiaozhen12 approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

@qw4990 qw4990 Awaiting requested review from qw4990

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs. type/refactor The issue belongs to a refactor work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TomShawn @ti-srebot @SunRunAway @ti-chi-bot @winoros @lzmhhh123 @Liuxiaozhen12