Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain: add indexes #4913

Merged
merged 8 commits into from
Feb 20, 2021
Merged

explain: add indexes #4913

merged 8 commits into from
Feb 20, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Nov 16, 2020

What is changed, added or deleted? (Required)

This is a followup PR to #3858 - but they can be reviewed independently, and merge out of order.

This PR does not add this page to the TOC. I will only do that once all PRs are merged (this is one ~3-4 followup PRs).

The content here is based on/duplicates query-execution-plan. I will merge all of the replacement pages, and then update query-execution-plan (soon to be called explain-overview) as a last step, and in the same PR which adds this page to the TOC.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn added translation/from-docs This PR is translated from a PR in pingcap/docs. size/large Changes of a large size. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 requires-followup This PR requires a follow-up task after being merged. labels Nov 16, 2020
@TomShawn TomShawn marked this pull request as ready for review November 17, 2020 05:33
TomShawn and others added 2 commits November 19, 2020 11:04
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 20, 2020
@ti-srebot
Copy link
Contributor

@yikeke, @SunRunAway, @lzmhhh123, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@yikeke, @SunRunAway, @lzmhhh123, PTAL.

@ti-srebot
Copy link
Contributor

@yikeke, @SunRunAway, @lzmhhh123, PTAL.

Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@lzmhhh123, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

@TomShawn TomShawn merged commit c3d380d into pingcap:master Feb 20, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Feb 20, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 20, 2021
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5555

@TomShawn TomShawn deleted the explain--add-indexs branch February 20, 2021 06:30
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Feb 20, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 20, 2021
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5556

TomShawn added a commit that referenced this pull request Feb 20, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn added a commit that referenced this pull request Feb 20, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn removed the requires-followup This PR requires a follow-up task after being merged. label Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/large Changes of a large size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants