Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql tuning: add EXPLAIN views #4624

Merged
merged 14 commits into from
Jan 6, 2021
Merged

sql tuning: add EXPLAIN views #4624

merged 14 commits into from
Jan 6, 2021

Conversation

ireneontheway
Copy link
Contributor

What is changed, added or deleted? (Required)

This is a followup PR to pingcap/docs#3858 - but they can be reviewed independently, and merge out of order.

This PR does not add this page to the TOC. I will only do that once all PRs are merged (this is one ~3-4 followup PRs).

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ireneontheway ireneontheway added translation/from-docs This PR is translated from a PR in pingcap/docs. requires-followup This PR requires a follow-up task after being merged. needs-cherry-pick-4.0 labels Sep 28, 2020
@ireneontheway
Copy link
Contributor Author

ireneontheway commented Sep 28, 2020 •
edited
Loading

As we don't need to translate "bikeshare 的样例数据", there is no file named import-example-data.md in docs-cn. So I cannot fix the dead link. @TomShawn

@TomShawn TomShawn added the size/large Changes of a large size. label Sep 29, 2020
TomShawn
TomShawn reviewed Sep 29, 2020
View reviewed changes
ireneontheway and others added 2 commits September 29, 2020 10:31
@ireneontheway @TomShawn
Update explain-views.md
aff5ab2 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ireneontheway
Update explain-views.md
88af760
TomShawn
TomShawn reviewed Sep 29, 2020
View reviewed changes
@TomShawn TomShawn requested a review from lilin90 September 29, 2020 03:04
@ireneontheway ireneontheway marked this pull request as ready for review September 29, 2020 06:47
zz-jason
zz-jason reviewed Sep 29, 2020
View reviewed changes
@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Oct 12, 2020
@TomShawn @zz-jason
Apply suggestions from code review
aa17b7b 
Co-authored-by: Zhang Jian <zjsariel@gmail.com>
@TomShawn TomShawn removed the request for review from lilin90 October 12, 2020 05:43
TomShawn
TomShawn reviewed Oct 12, 2020
View reviewed changes
@TomShawn TomShawn added size/medium Changes of a medium size. and removed size/large Changes of a large size. labels Oct 12, 2020
TomShawn
TomShawn reviewed Oct 12, 2020
View reviewed changes
TomShawn
TomShawn reviewed Oct 12, 2020
View reviewed changes
TomShawn
TomShawn reviewed Oct 12, 2020
View reviewed changes
@ti-srebot
Copy link
Contributor

@TomShawn, @zz-jason, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@TomShawn, @zz-jason, PTAL.

@ti-srebot
Copy link
Contributor

@TomShawn, @zz-jason, PTAL.

@TomShawn TomShawn added status/PTAL This PR is ready for reviewing. and removed status/PTAL This PR is ready for reviewing. labels Oct 27, 2020
@ti-srebot
Copy link
Contributor

@TomShawn, @zz-jason, @lilin90, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@TomShawn, @zz-jason, @lilin90, PTAL.

@ti-srebot
Copy link
Contributor

@TomShawn, @zz-jason, @lilin90, PTAL.

TomShawn
TomShawn approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2021
@TomShawn TomShawn merged commit 028b59a into pingcap:master Jan 6, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 6, 2021
@ireneontheway @ti-srebot
cherry pick pingcap#4624 to release-4.0
72135fc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 6, 2021
Merged
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 6, 2021
@ireneontheway @ti-srebot
cherry pick pingcap#4624 to release-5.0
0c914f6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 6, 2021
Merged
TomShawn pushed a commit that referenced this pull request Jan 6, 2021
@ti-srebot @ireneontheway
cherry pick #4624 to release-4.0 (#5258)
3727658 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
TomShawn pushed a commit that referenced this pull request Jan 6, 2021
@ti-srebot @ireneontheway
cherry pick #4624 to release-5.0 (#5259)
cf801f4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: ireneontheway <48651140+ireneontheway@users.noreply.github.com>
@TomShawn TomShawn mentioned this pull request Feb 23, 2021
Merged
10 tasks
@TomShawn TomShawn removed the requires-followup This PR requires a follow-up task after being merged. label Feb 23, 2021
This was referenced Nov 10, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@lilin90 lilin90 lilin90 left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
size/medium Changes of a medium size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ireneontheway @ti-srebot @zz-jason @lilin90 @TomShawn