Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explain: add index merge #4576

Merged
merged 11 commits into from
Oct 12, 2020
Merged

explain: add index merge #4576

merged 11 commits into from
Oct 12, 2020

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Sep 23, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

This is a followup PR to #3858. The content is taken from query-execution-plan#indexmerge-example.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-4.0,size/small, translation/from-docs

@ti-srebot ti-srebot added needs-cherry-pick-4.0 size/small Changes of a small size. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Sep 23, 2020
@Joyinqin
Copy link
Contributor Author

/cc TomShawn

@ti-srebot ti-srebot requested a review from TomShawn September 24, 2020 01:50
@Joyinqin Joyinqin marked this pull request as ready for review September 24, 2020 01:50
TomShawn
TomShawn reviewed Sep 24, 2020
View reviewed changes
@Joyinqin @TomShawn
Apply suggestions from code review
2d6954b 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed Sep 24, 2020
View reviewed changes
@TomShawn TomShawn requested a review from lzmhhh123 September 24, 2020 04:03
Joyinqin and others added 2 commits September 24, 2020 12:08
@Joyinqin @TomShawn
Apply suggestions from code review
4e3ad41 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Joyinqin @TomShawn
Apply suggestions from code review
8ad2350 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
TomShawn
TomShawn reviewed Sep 24, 2020
View reviewed changes
@TomShawn TomShawn added the status/PTAL This PR is ready for reviewing. label Sep 24, 2020
@ti-srebot
Copy link
Contributor

@TomShawn, @lzmhhh123, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@TomShawn, @lzmhhh123, PTAL.

@ti-srebot
Copy link
Contributor

@TomShawn, @lzmhhh123, PTAL.

lzmhhh123
lzmhhh123 reviewed Oct 12, 2020
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@lzmhhh123,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: docs(slack).

TomShawn
TomShawn reviewed Oct 12, 2020
View reviewed changes
TomShawn
TomShawn reviewed Oct 12, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2020
@TomShawn TomShawn added the requires-followup This PR requires a follow-up task after being merged. label Oct 12, 2020
@TomShawn
Copy link
Contributor

follow-up: TOC

@TomShawn TomShawn merged commit 97cf277 into pingcap:master Oct 12, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Oct 12, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#4576 to release-4.0
98f5a67 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 12, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4661

TomShawn pushed a commit that referenced this pull request Oct 12, 2020
@ti-srebot @Joyinqin
cherry pick #4576 to release-4.0 (#4661)
82c431e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
@Joyinqin Joyinqin deleted the explain-index-merge branch October 13, 2020 00:45
@TomShawn TomShawn removed the requires-followup This PR requires a follow-up task after being merged. label Feb 23, 2021
@TomShawn TomShawn mentioned this pull request Feb 23, 2021
Merged
10 tasks
This was referenced Nov 10, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees
No one assigned
Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joyinqin @ti-srebot @TomShawn @lzmhhh123