Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add experimental warning #3330

Merged
merged 6 commits into from
May 26, 2020
Merged

add experimental warning #3330

merged 6 commits into from
May 26, 2020

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented May 25, 2020 •
edited
Loading

Signed-off-by: Shuaipeng Yu jackysp@gmail.com

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@jackysp
add experimental warning
740b35a 
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@sre-bot sre-bot added special-week PR from Document Special Week. status/PTAL This PR is ready for reviewing. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels May 25, 2020
@sre-bot sre-bot requested review from kissmydb and lilin90 May 25, 2020 09:54
nolouch
nolouch reviewed May 25, 2020
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackysp
update
d37adab 
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
bb7133
bb7133 reviewed May 25, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented May 25, 2020

PTAL @lilin90

@bb7133 bb7133 added the status/LGT2 Indicates that a PR has LGTM 2. label May 25, 2020
@jackysp
update
a04bceb 
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
zz-jason
zz-jason reviewed May 25, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. labels May 25, 2020
kissmydb
kissmydb reviewed May 25, 2020
View reviewed changes
tikv-configuration-file.md Outdated
@@ -92,6 +92,10 @@ TiKV 配置文件比命令行参数支持更多的选项。你可以在 [etc/con

## readpool.unified

> **注意：**
>
> 该功能目前是实验性阶段，不建议在生产环境中使用。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该不属于实验性了吧，默认已经是这样用了好久了
readpool.storage.use-unified-pool: false
readpool.coprocessor.use-unified-pool: true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

跟 QA 确认过是实验特性

tidb-configuration-file.md Outdated
@@ -49,8 +53,12 @@ TiDB 配置文件比命令行参数支持更多的选项。你可以在 [config/

### `oom-action`

> **注意：**
>
> 该功能目前会对写入过程中的内存进行统计，为实验性阶段，对于希望依赖该特性取消写入操作的用户，不建议在生产环境中将其配置为 `cancel`。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

诶？这个用能不是一直有么？怎么是实验性质呢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个特性现在混杂了写入内存统计，这部分还没系统验证过，使用 cancel 有风险。

@jackysp
Copy link
Member Author

jackysp commented May 26, 2020

PTAL @kissmydb

@jackysp
remove warning because sort is disabled
30f1c0a 
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
lilin90
lilin90 reviewed May 26, 2020
View reviewed changes
configure-placement-rules.md Outdated Show resolved Hide resolved
garbage-collection-configuration.md Outdated Show resolved Hide resolved
production-deployment-using-tiup.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-create-index.md Outdated Show resolved Hide resolved
system-tables/system-table-sql-diagnosis.md Outdated Show resolved Hide resolved
ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
tidb-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member Author

jackysp commented May 26, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 26, 2020

Your auto merge job has been accepted, waiting for:

  • 3284

@yikeke yikeke added the translation/doing This PR’s assignee is translating this PR. label Jun 1, 2020
@ran-huang ran-huang mentioned this pull request Jun 1, 2020
Merged
5 tasks
@toutdesuite toutdesuite mentioned this pull request Jun 5, 2020
Merged
5 tasks
This was referenced Jun 5, 2020
Merged
Merged
@TomShawn TomShawn mentioned this pull request Jun 10, 2020
Merged
5 tasks
@yikeke yikeke removed their assignment Jun 12, 2020
@jackysp jackysp mentioned this pull request Jun 12, 2020
Merged
5 tasks
@TomShawn TomShawn mentioned this pull request Jun 15, 2020
Merged
5 tasks
@sre-bot sre-bot mentioned this pull request Jun 16, 2020
Merged
5 tasks
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2020
Merged
5 tasks
@yikeke yikeke assigned jackysp and yikeke and unassigned toutdesuite, TomShawn and ran-huang Jun 16, 2020
@ti-srebot ti-srebot mentioned this pull request Jun 17, 2020
Merged
5 tasks
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@yikeke yikeke assigned TomShawn and unassigned yikeke Jun 23, 2020
@TomShawn TomShawn mentioned this pull request Jun 23, 2020
Merged
5 tasks
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 29, 2020
@yikeke yikeke mentioned this pull request Jun 29, 2020
Merged
5 tasks
@ti-srebot ti-srebot mentioned this pull request Jun 30, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke left review comments

@kissmydb kissmydb kissmydb left review comments

@nolouch nolouch nolouch left review comments

@zz-jason zz-jason zz-jason left review comments

@bb7133 bb7133 bb7133 left review comments

@lilin90 lilin90 lilin90 approved these changes

@imtbkcat imtbkcat imtbkcat approved these changes

@shuke987 shuke987 Awaiting requested review from shuke987

@zhangjinpeng87 zhangjinpeng87 Awaiting requested review from zhangjinpeng87

@crazycs520 crazycs520 Awaiting requested review from crazycs520

@IANTHEREAL IANTHEREAL Awaiting requested review from IANTHEREAL

Assignees

@jackysp jackysp

@TomShawn TomShawn

Labels
size/small Changes of a small size. special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.