Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiCDC: Update ticdc-overview.md #2694

Merged
merged 6 commits into from
Jun 8, 2020
Merged

Conversation

toutdesuite
Copy link
Contributor

@toutdesuite toutdesuite commented Jun 5, 2020

What is changed, added or deleted? (Required)

Update ticdc-overview.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@toutdesuite toutdesuite marked this pull request as draft June 5, 2020 02:22
@toutdesuite toutdesuite marked this pull request as ready for review June 5, 2020 06:59
@toutdesuite toutdesuite added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 5, 2020
ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
ticdc/ticdc-overview.md Outdated Show resolved Hide resolved
ticdc/ticdc-overview.md Show resolved Hide resolved
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ran-huang and others added 2 commits June 5, 2020 21:51
@yikeke yikeke removed their request for review June 8, 2020 02:45
@toutdesuite toutdesuite added the requires-followup This PR requires a follow-up task after being merged. label Jun 8, 2020
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toutdesuite toutdesuite added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

/run-all-tests

@sre-bot sre-bot merged commit fb520a7 into pingcap:master Jun 8, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

cherry pick to release-4.0 in PR #2720

sre-bot added a commit that referenced this pull request Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-followup This PR requires a follow-up task after being merged. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants