Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configure-placement-rules.md #2875

Merged
merged 3 commits into from
Jun 16, 2020
Merged

Update configure-placement-rules.md #2875

merged 3 commits into from
Jun 16, 2020

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jun 15, 2020 •
edited by yikeke
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/small Changes of a small size. needs-cherry-pick-4.0 special-week PR from Document Special Week. labels Jun 15, 2020
@TomShawn TomShawn requested review from disksing and yikeke June 15, 2020 11:47
yikeke
yikeke approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yikeke
Copy link
Contributor

yikeke commented Jun 16, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit e2b303f into pingcap:master Jun 16, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 16, 2020
@TomShawn @ti-srebot
cherry pick pingcap#2875 to release-4.0
3921628 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 16, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #2894

@TomShawn TomShawn deleted the placement-ruless branch June 16, 2020 06:26
ti-srebot added a commit that referenced this pull request Jun 16, 2020
@ti-srebot
Update configure-placement-rules.md (#2875) (#2894)
d6b0867 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
size/small Changes of a small size. special-week PR from Document Special Week. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @yikeke @ti-srebot