Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how-to: update doc for deploying tidb cluster using tiup #2649

Merged
merged 10 commits into from
Jun 5, 2020
Merged

how-to: update doc for deploying tidb cluster using tiup #2649

merged 10 commits into from
Jun 5, 2020

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jun 1, 2020 •
edited by yikeke
Loading

What is changed, added or deleted? (Required)

Update the doc for deploying TiDB cluster using TiUP.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Jun 1, 2020
@ran-huang ran-huang requested review from yikeke and superlzs0476 June 1, 2020 10:19
@yikeke
Copy link
Contributor

yikeke commented Jun 5, 2020

Except for the deadlinks, rest LGTM. You can take a look at my commits and see if there are any problems. @ran-huang

@yikeke yikeke added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 5, 2020
@ran-huang
Copy link
Contributor Author

@yikeke Made a minor edit. Rest LGTM.

@yikeke
Copy link
Contributor

yikeke commented Jun 5, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 5, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

@ran-huang merge failed.

yikeke
yikeke approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit 0af51fd into pingcap:master Jun 5, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request Jun 5, 2020
@ran-huang @sre-bot
cherry pick pingcap#2649 to release-4.0
a7905a8 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Jun 5, 2020
Merged
5 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 5, 2020

cherry pick to release-4.0 in PR #2717

yikeke pushed a commit that referenced this pull request Jun 5, 2020
@sre-bot @ran-huang
how-to: update doc for deploying tidb cluster using tiup (#2649) (#2717)
8f84e19 
* cherry pick #2649 to release-4.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* change version of template files

Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang deleted the tiup-deployment branch July 30, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yikeke yikeke yikeke approved these changes

@superlzs0476 superlzs0476 Awaiting requested review from superlzs0476

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ran-huang @yikeke @sre-bot