Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update production-deployment-using-tiup.md #3417

Merged
merged 5 commits into from
Jun 1, 2020
Merged

Update production-deployment-using-tiup.md #3417

merged 5 commits into from
Jun 1, 2020

Conversation

lonng
Copy link
Contributor

@lonng lonng commented May 30, 2020

What is changed, added or deleted? (Required)

The --refresh has been removed at TiUP v1.0.0

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@lonng lonng requested a review from yikeke May 30, 2020 14:24
@yikeke yikeke mentioned this pull request Jun 1, 2020
5 tasks
@yikeke
Copy link
Contributor

yikeke commented Jun 1, 2020

还有一些其他文档也有提及 --refresh 参数,要不要批量搜索下都去掉? @lonng

@lonng
Copy link
Contributor Author

lonng commented Jun 1, 2020

还有一些其他文档也有提及 --refresh 参数,要不要批量搜索下都去掉? @lonng

Nice catch, I will address all documents.

@yikeke yikeke added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 1, 2020
@yikeke yikeke added the status/require-change Needs the author to address comments. label Jun 1, 2020
yikeke and others added 2 commits June 1, 2020 14:00
@lonng
Copy link
Contributor Author

lonng commented Jun 1, 2020

@yikeke PTAL again.

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke requested a review from kissmydb June 1, 2020 07:55
@yikeke yikeke assigned yikeke and unassigned TomShawn Jun 1, 2020
Copy link
Contributor

@kissmydb kissmydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yikeke
Copy link
Contributor

yikeke commented Jun 1, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 1, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 1, 2020

/run-all-tests

@sre-bot sre-bot merged commit 721138e into master Jun 1, 2020
@yikeke yikeke deleted the lonng-patch-1-1 branch June 1, 2020 08:39
@yikeke
Copy link
Contributor

yikeke commented Jun 1, 2020

/run-cherry-picker

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 1, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 1, 2020

cherry pick to release-4.0 in PR #3433

yikeke pushed a commit that referenced this pull request Jun 1, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Lonng <heng@lonng.org>
yikeke added a commit to pingcap/docs that referenced this pull request Jun 5, 2020
* how-to: update doc for deploying tidb cluster using tiup

* update tiup repo link

* align part of pingcap/docs-cn#3417

* translate part of pingcap/docs-cn#3476

* fix heading levels

* fix punctuation

* rename

Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke yikeke added the size/small Changes of a small size. label Jun 19, 2020
@yikeke yikeke added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/require-change Needs the author to address comments. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants