-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difficult to find RegionAndCulture ComboBox in preferences #945
Comments
Yes! I remember thinking (if I didn't say it) that the locale selection box could use a label and thought it was strange it didn't have one. I just assumed that we don't have enough space to fit everything, but if we can label that I agree that it would be really beneficial. |
Okay perfect. What would you like the label and description to be? |
Just 'Locale' for the label seems fine to me. I wouldn't add a description. |
@amanda-phet and I discussed in Slack that we will reuse the label and description that were being provided to the PDOM for the localePanel. That has been committed above and is now ready to cherry-pick for phetsims/qa#1014 and phetsims/qa#1016 |
@Luisav1 will also cherry-pick into energy-skate-park |
I believe this has been cherry-picked for all active RCs that would need this change. Can be closed by QA once verified. |
For Number Line: Integers 1.2.0-rc.4, there is now a 'Languages' label and description. |
ESP doesn't have dynamic locale, so there was nothing to check for phetsims/qa#1022. |
For NL: Operations rc.2, the "Languages" title and description have been added to the Localization tab (noting that this sim doesn't have a Region and Culture combobox). |
I believe all related cherry picks to this issue are now complete. Closing! |
While meeting with @pixelzoom he mentioned that he had a difficult time finding the ComboBox control for "Region and Culture" because it looked like the ComboBox label was actually the language selection label. He kept clicking a language thinking that was actually changing the region and culture portrayals. It took him several minutes to finally notice the ComboBox in the far right:
We both acknowledged that there is a lot of preferences design work that needs to be done to find a long term solution for this, but thought that an appropriate short term solution would be to add a label and description for the language selection so that it feels separated from the "Region and Culture" selection.
@amanda-phet, I felt this was something the two of us could discuss and find a good strategy moving forward. It would be easy to cherry pick this change into sims that are already in RC as well.
The text was updated successfully, but these errors were encountered: