Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to find RegionAndCulture ComboBox in preferences #945

Closed
Tracked by #1024
marlitas opened this issue Dec 5, 2023 · 10 comments
Closed
Tracked by #1024

Difficult to find RegionAndCulture ComboBox in preferences #945

marlitas opened this issue Dec 5, 2023 · 10 comments

Comments

@marlitas
Copy link
Contributor

marlitas commented Dec 5, 2023

While meeting with @pixelzoom he mentioned that he had a difficult time finding the ComboBox control for "Region and Culture" because it looked like the ComboBox label was actually the language selection label. He kept clicking a language thinking that was actually changing the region and culture portrayals. It took him several minutes to finally notice the ComboBox in the far right:

image

We both acknowledged that there is a lot of preferences design work that needs to be done to find a long term solution for this, but thought that an appropriate short term solution would be to add a label and description for the language selection so that it feels separated from the "Region and Culture" selection.

@amanda-phet, I felt this was something the two of us could discuss and find a good strategy moving forward. It would be easy to cherry pick this change into sims that are already in RC as well.

@amanda-phet
Copy link

Yes! I remember thinking (if I didn't say it) that the locale selection box could use a label and thought it was strange it didn't have one. I just assumed that we don't have enough space to fit everything, but if we can label that I agree that it would be really beneficial.

@marlitas
Copy link
Contributor Author

Okay perfect. What would you like the label and description to be?

@amanda-phet
Copy link

Just 'Locale' for the label seems fine to me. I wouldn't add a description.

@marlitas
Copy link
Contributor Author

@amanda-phet and I discussed in Slack that we will reuse the label and description that were being provided to the PDOM for the localePanel. That has been committed above and is now ready to cherry-pick for phetsims/qa#1014 and phetsims/qa#1016

@marlitas
Copy link
Contributor Author

@Luisav1 will also cherry-pick into energy-skate-park

@marlitas
Copy link
Contributor Author

marlitas commented Jan 2, 2024

I believe this has been cherry-picked for all active RCs that would need this change. Can be closed by QA once verified.

@Nancy-Salpepi
Copy link

For Number Line: Integers 1.2.0-rc.4, there is now a 'Languages' label and description.

@Nancy-Salpepi
Copy link

ESP doesn't have dynamic locale, so there was nothing to check for phetsims/qa#1022.

@Nancy-Salpepi
Copy link

For NL: Operations rc.2, the "Languages" title and description have been added to the Localization tab (noting that this sim doesn't have a Region and Culture combobox).

@marlitas
Copy link
Contributor Author

I believe all related cherry picks to this issue are now complete. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants