Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xhtml version doesn't load #1413

Open
Nancy-Salpepi opened this issue Dec 14, 2023 · 15 comments
Open

xhtml version doesn't load #1413

Nancy-Salpepi opened this issue Dec 14, 2023 · 15 comments
Labels
priority:2-high status:ready-to-cherry-pick type:bug

Comments

@Nancy-Salpepi
Copy link

For phetsims/qa#1014, on macOS 14.1.2 with both safari and chrome, the xhtml version doesn't load. These errors appear in the console:
Screenshot 2023-12-14 at 11 57 48 AM
@Nancy-Salpepi Nancy-Salpepi mentioned this issue Dec 18, 2023
Closed
@marlitas marlitas transferred this issue from phetsims/number-line-operations Dec 18, 2023
@marlitas
Copy link
Contributor

marlitas commented Dec 18, 2023 •
edited
Loading

After some investigation with @zepumph we found that this bug was introduced in this commit: 5b5aeff

This blocks all sim publications and any sims whose RC was created after 12/5 will require a patch.

zepumph added a commit that referenced this issue Dec 18, 2023
@zepumph
initial global variables before setting, #1413
8c84053
@marlitas
Copy link
Contributor

Tagging as a reminder that this needs to be cherry-picked for:

@zepumph zepumph mentioned this issue Dec 18, 2023
Closed
@zepumph
Copy link
Member

zepumph commented Dec 18, 2023

@jonathanolson can you please spot check the commit? Presumably you got rid of the initialization objects because something before this script is setting it now? So I added grace.

@zepumph
Copy link
Member

zepumph commented Dec 18, 2023

Let's call this blocking until @jonathanolson can get eyes on the commit.

@marlitas marlitas removed their assignment Dec 18, 2023
@zepumph
Copy link
Member

zepumph commented Dec 19, 2023

@marlitas, please don't cherry pick this just yet. @jonathanolson has another fix that he would like to propose.

jonathanolson added a commit that referenced this issue Dec 19, 2023
@jonathanolson
Include the license script in XHTML, see #1413
4496294
@jonathanolson
Copy link
Contributor

The script with the licenses had the initialization, and it was missing in the XHTML. I reverted the workaround above, and added the license script (which I forgot) to the XHTML version. @marlitas can you test?

@marlitas
Copy link
Contributor

Tested on a Number Line Integers build and it's working well. Thanks @jonathanolson. I'll mark as ready for cherry-pick. To clarify, do I need to grab both commits or is 8c84053 being reverted?

@jonathanolson
Copy link
Contributor

Presumably you'll want to apply both commits, sorry!

@zepumph
Copy link
Member

zepumph commented Dec 19, 2023

Ok perfect. Thanks for the rush job @jonathanolson. We can proceed with MSS too now.

AgustinVallejo pushed a commit that referenced this issue Dec 19, 2023
@zepumph @AgustinVallejo
initial global variables before setting, #1413
0cc29d2 
(cherry picked from commit 8c84053)
AgustinVallejo pushed a commit that referenced this issue Dec 19, 2023
@jonathanolson @AgustinVallejo
Include the license script in XHTML, see #1413
b66691c 
(cherry picked from commit 4496294)
@marlitas
Copy link
Contributor

This was cherry-picked for #1413.

@marlitas marlitas removed their assignment Dec 20, 2023
@marlitas marlitas mentioned this issue Dec 20, 2023
Closed
16 tasks
@Nancy-Salpepi
Copy link
Author

Nancy-Salpepi commented Dec 21, 2023 •
edited
Loading

xhtml loads in rc.4. for Number Line Distance.

@Nancy-Salpepi Nancy-Salpepi reopened this Dec 21, 2023
@Nancy-Salpepi
Copy link
Author

Sorry! Closed this by accident!

marlitas pushed a commit that referenced this issue Dec 22, 2023
@zepumph @marlitas
initial global variables before setting, #1413
47261b1
marlitas pushed a commit that referenced this issue Dec 22, 2023
@jonathanolson @marlitas
Include the license script in XHTML, see #1413
bd6d154
marlitas added a commit to phetsims/number-line-integers that referenced this issue Dec 22, 2023
@marlitas
updated dependencies.json for phetsims/number-line-operations#108 and #…
8cf002c 
…128 and phetsims/chipper#1413 and phetsims/joist#945
@marlitas marlitas mentioned this issue Dec 22, 2023
Closed
14 tasks
marlitas pushed a commit that referenced this issue Jan 2, 2024
@zepumph @marlitas
initial global variables before setting, #1413
932244f
marlitas pushed a commit that referenced this issue Jan 2, 2024
@jonathanolson @marlitas
Include the license script in XHTML, see #1413
ab80eb7
marlitas added a commit to phetsims/number-line-operations that referenced this issue Jan 2, 2024
@marlitas
updated dependencies.json for #108 and phetsims/chipper#1413 and phet…
de07a3c 
…sims/joist#945 and phetsims/number-line-integers#124
@marlitas marlitas mentioned this issue Jan 2, 2024
Closed
22 tasks
@Nancy-Salpepi
Copy link
Author

Nancy-Salpepi commented Jan 3, 2024 •
edited
Loading

Working in rc.4 for Number Line: Integers.

@Nancy-Salpepi
Copy link
Author

I did it again! Reopening.

@Nancy-Salpepi Nancy-Salpepi reopened this Jan 3, 2024
@Nancy-Salpepi
Copy link
Author

Nancy-Salpepi commented Jan 5, 2024 •
edited
Loading

This looks good for NL: Operations rc.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:2-high status:ready-to-cherry-pick type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonathanolson @zepumph @marlitas @Nancy-Salpepi