Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xhtml version doesn't load #1413 #319

Closed
zepumph opened this issue Dec 18, 2023 · 4 comments
Closed

xhtml version doesn't load #1413 #319

zepumph opened this issue Dec 18, 2023 · 4 comments
Assignees
@AgustinVallejo
Labels
status:ready-to-cherry-pick type:bug Something isn't working

Comments

@zepumph
Copy link
Member

zepumph commented Dec 18, 2023

MSS 1.3 should get the patch in phetsims/chipper#1413 so that the XHTML will load.

https://phet-dev.colorado.edu/html/my-solar-system/1.3.0-rc.1/phet/xhtml/my-solar-system_all.xhtml (currently broken)

Cherry pick phetsims/chipper@8c84053 to fix.
@zepumph
Copy link
Member Author

zepumph commented Dec 19, 2023

Please hold off on this. The above commit didn't pass review. Wait until we hear back from @jonathanolson in phetsims/chipper#1413 (comment).

@Nancy-Salpepi
Copy link

linking to phetsims/qa#1015

@zepumph
Copy link
Member Author

zepumph commented Dec 19, 2023 •
edited by AgustinVallejo
Loading

Ok we have sorted things out. To cherry pick (in order):

@AgustinVallejo
Copy link
Contributor

Done and ready. Also linking the main issue and closing
#282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgustinVallejo AgustinVallejo

Labels
status:ready-to-cherry-pick type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zepumph @AgustinVallejo @Nancy-Salpepi