Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should touch/pointer areas be the same width for checkboxes? #124

Closed
Tracked by #1024
Nancy-Salpepi opened this issue Dec 7, 2023 · 5 comments
Closed
Tracked by #1024

Should touch/pointer areas be the same width for checkboxes? #124

Nancy-Salpepi opened this issue Dec 7, 2023 · 5 comments
Labels
status:ready-for-review type:question Further information is requested

Comments

@Nancy-Salpepi
Copy link

For phetsims/qa#1010, I noticed the pointer/touch areas were different widths. Should they be the same?

Screenshot 2023-12-07 at 2 03 41 PM
@Nancy-Salpepi Nancy-Salpepi added the type:question Further information is requested label Dec 7, 2023
@Nancy-Salpepi Nancy-Salpepi mentioned this issue Dec 8, 2023
Closed
@marlitas marlitas assigned amanda-phet and unassigned marlitas Dec 11, 2023
@marlitas
Copy link
Contributor

I think the touch areas are supposed to be slightly bigger. @amanda-phet thoughts here?

@Nancy-Salpepi
Copy link
Author

I thought they were usually all the same width:
Screenshot 2023-12-11 at 6 40 05 PM
Screenshot 2023-12-11 at 6 38 18 PM

@marlitas
Copy link
Contributor

Interesting. Looks like this was just applied to the Number Line Suite, I'm seeing similar sims from that time period with the same dilation @Nancy-Salpepi just showed. I'll go ahead and adjust for all of the number-line sims.

@marlitas marlitas assigned marlitas and unassigned amanda-phet Dec 12, 2023
marlitas added a commit to phetsims/number-line-common that referenced this issue Dec 12, 2023
@marlitas
Renamed touch area constants and added mouse area dilations in NLChec…
5795e6e 
…kbox, phetsims/number-line-integers#124
@marlitas
Copy link
Contributor

This will need to be cherry picked for phetsims/qa#1009 and phetsims/qa#1014

@marlitas marlitas removed their assignment Dec 12, 2023
marlitas added a commit to phetsims/number-line-common that referenced this issue Dec 20, 2023
@marlitas
Renamed touch area constants and added mouse area dilations in NLChec…
685d32c 
…kbox, phetsims/number-line-integers#124
marlitas added a commit to phetsims/number-line-distance that referenced this issue Dec 20, 2023
@marlitas
updated dependencies.json for phetsims/number-line-integers#124 and p…
970e333 
…hetsims/number-line-operations#108
marlitas added a commit to phetsims/number-line-common that referenced this issue Jan 2, 2024
@marlitas
Renamed touch area constants and added mouse area dilations in NLChec…
7579c0a 
…kbox, phetsims/number-line-integers#124
marlitas added a commit to phetsims/number-line-operations that referenced this issue Jan 2, 2024
@marlitas
updated dependencies.json for #108 and phetsims/chipper#1413 and phet…
de07a3c 
…sims/joist#945 and phetsims/number-line-integers#124
@marlitas marlitas mentioned this issue Jan 2, 2024
Closed
22 tasks
@Nancy-Salpepi
Copy link
Author

Looks good in rc.2 for NL: Operations
Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready-for-review type:question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amanda-phet @marlitas @Nancy-Salpepi