Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization label and description not translatable #976

Closed
zepumph opened this issue Jul 2, 2024 · 7 comments
Closed

Localization label and description not translatable #976

zepumph opened this issue Jul 2, 2024 · 7 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jul 2, 2024

@DianaTavares and I found over in phetsims/babel#24 that we have been using a couple of string under a11y for visual text, and published those sims that way. For example, arithmetic 1.2

const localeLabel = new Text( JoistStrings.a11y.preferences.tabs.localization.languageSelection.labelStringProperty,
PreferencesDialogConstants.CONTROL_LABEL_OPTIONS );
const localeDescription = new RichText( JoistStrings.a11y.preferences.tabs.localization.languageSelection.descriptionStringProperty,
PreferencesDialogConstants.CONTROL_DESCRIPTION_OPTIONS );
const localePanel = new LocalePanel( localizationModel.localeProperty );

I have not more research here, but I'll mark for dev prioritization.

@zepumph
Copy link
Member Author

zepumph commented Jul 2, 2024

Perhaps effecting all sims since 12/23/24:

a38b1d5

@jessegreenberg
Copy link
Contributor

The reasoning for using these strings is listed here: #945 (comment)

we will reuse the label and description that were being provided to the PDOM for the localePanel.

So these strings were in the PDOM, not translatable, and then added visually, but using the same keys. That means that there are NOT existing tranlsations for these that can be revived.

So the plan is to

  • Move these strings into the translatable area in the strings file
  • Republish sims that include a38b1d5 (december 22, 2023)

@jessegreenberg jessegreenberg changed the title a11y strings used in visual text; not translatable! Localization label and description not translatable Jul 16, 2024
jessegreenberg added a commit to phetsims/area-model-algebra that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/area-model-decimals that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/area-model-introduction that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/area-model-multiplication that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/arithmetic that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/balancing-act that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/diffusion that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/gas-properties that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/gases-intro that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/graphing-lines that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/hookes-law that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/keplers-laws that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/projectile-data-lab that referenced this issue Jul 16, 2024
jessegreenberg added a commit to phetsims/projectile-sampling-distributions that referenced this issue Jul 16, 2024
@jessegreenberg
Copy link
Contributor

Fixed in main, patches applied to sims that took SHAs after a38b1d5. RCs prepared in phetsims/qa#1114. If QA lets us know we are clear, we can continue by deploying to production.

@jessegreenberg
Copy link
Contributor

Spot check cleared, Ill begin the production deploys.

jessegreenberg added a commit to phetsims/area-model-algebra that referenced this issue Jul 17, 2024
jessegreenberg added a commit to phetsims/area-model-decimals that referenced this issue Jul 17, 2024
jessegreenberg added a commit to phetsims/area-model-introduction that referenced this issue Jul 17, 2024
jessegreenberg added a commit to phetsims/area-model-multiplication that referenced this issue Jul 17, 2024
jessegreenberg added a commit to phetsims/arithmetic that referenced this issue Jul 17, 2024
jessegreenberg added a commit to phetsims/balancing-act that referenced this issue Jul 17, 2024
jessegreenberg added a commit to phetsims/graphing-lines that referenced this issue Jul 17, 2024
jessegreenberg added a commit to phetsims/graphing-slope-intercept that referenced this issue Jul 17, 2024
jessegreenberg added a commit to phetsims/greenhouse-effect that referenced this issue Jul 17, 2024
jessegreenberg added a commit to phetsims/hookes-law that referenced this issue Jul 17, 2024
jessegreenberg added a commit to phetsims/keplers-laws that referenced this issue Jul 17, 2024
jessegreenberg added a commit to phetsims/projectile-data-lab that referenced this issue Jul 17, 2024
jessegreenberg added a commit to phetsims/projectile-sampling-distributions that referenced this issue Jul 17, 2024
@jessegreenberg
Copy link
Contributor

Deploys complete. I now see these strings in the tranlsation utility:

image

Closing.

@zepumph
Copy link
Member Author

zepumph commented Jul 22, 2024

@arouinfar, should we ping translators about these new strings through the admin utility? Not sure what the "minimum value to bother translators" is.

@arouinfar
Copy link

Good question @zepumph. We don't have a process for informing translators about new common strings. We can email trusted translators from the sim admin page, and it generates an email that is pre-populated with language along the lines of:

{{Sim Name}} has been published and is available for translation.

We can add additional information to the email, but it remains centered around a specific simulation.

Since these new strings are common, translators will encounter them the next time they translate any new sim. We notify translators each time a new simulation is published, and there are several coming soon (FEL suite, GasProps suite, MSaB), so these new strings are likely to get translated along with the new sims.

I don't think we need to send out a separate notification for these new common strings, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants