You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Strings that are only used for accessibility are under an a11y key in translatable strings files. This makes it so these strings are not translatable.
This is risky because
Developers might use a string under a11y accidentally and then that string will not be translatable.
Developers might put accessibility strings elsewhere in the file, and then they are accidentally translatable.
@jbphet suggested that a11y strings be totally removed from the translatable strings file. That may be a good way to make the behavior if i18n + a11y strings more clear.
To consider:
Does rosetta need to be updated with how it handles the a11y key?
I recommend creating new files for 'a11y' strings. JoistA11yStrings.ts or something.
Should they be converted to StringProperties? Do we have tooling for that or should it be done inline?
Do we need new tooling to 'modulify' these strings?
The text was updated successfully, but these errors were encountered:
This issue was suggested after phetsims/joist#976. That issue would have been caught by developer and QA if a11y strings were skipped by ?stringTest. That change alone may be enough.
From developer meeting today - Removing strings from our strings files will be a large chunk of work, and there are questions about how to best support a11y strings with typescript and tooling if we don't keep them in the strings file. There is uncertainty how a11y strings will work in the future as we consider an "description tool" to add and design descriptions.
We are going to proceed with changing the query param behavior, and revisit after we know more about the description tool.
Strings that are only used for accessibility are under an
a11y
key in translatable strings files. This makes it so these strings are not translatable.This is risky because
a11y
accidentally and then that string will not be translatable.@jbphet suggested that a11y strings be totally removed from the translatable strings file. That may be a good way to make the behavior if i18n + a11y strings more clear.
To consider:
a11y
key?JoistA11yStrings.ts
or something.The text was updated successfully, but these errors were encountered: