Migrate baseline error-prone checks to use jdk13 compatible qualifiers #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
commented
Dec 10, 2019
| @@ -210,7 +210,6 @@ private static void configureErrorProneOptions( | |||
| // Errorprone 2.3.4 isn't officially compatible with Java13 either | |||
| // https://github.com/google/error-prone/issues/1106 | |||
| errorProneOptions.check("TypeParameterUnusedInFormals", CheckSeverity.OFF); | |||
| errorProneOptions.check("PreferCollectionConstructors", CheckSeverity.OFF); | |||
There was a problem hiding this comment.
calling out that I re-enabled this because it uses the safe qualify method now.
ferozco
approved these changes
Dec 10, 2019
|
dozer? |
|
Released 2.42.0 |
This was referenced Dec 10, 2019
This was referenced Dec 10, 2019
This was referenced Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The compiler failed on jdk13 when checks with suggested fixes were found.
After this PR
==COMMIT_MSG==
Migrate baseline error-prone checks to use jdk13 compatible qualifiers
==COMMIT_MSG==
Possible downsides?
We don't run any tests on jdk13