Excavator: Upgrades Baseline to the latest version #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
reviewed
Dec 4, 2019
| throw new GradleException( | ||
| String.format( | ||
| "%s does not exist, please run `./gradlew %s --write-locks` and commit the resultant" | ||
| + " file", |
There was a problem hiding this comment.
@dansanduleac Any idea what happened here?
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
2 times, most recently
from
d0c7654 to
5f1d5d1
Compare
carterkozak
reviewed
Dec 6, 2019
| Preconditions.class, | ||
| tag + " is required") | ||
| .addStatement("return this") | ||
| .build()) |
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
3 times, most recently
from
335d66a to
0e2ca81
Compare
svc-excavator-bot
force-pushed
the
roomba/latest-baseline-oss
branch
from
0e2ca81 to
f6973f1
Compare
|
👍 |
|
dozer? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/latest-baseline-oss check.
Release Notes
2.40.0
CatchSpecificityandThrowSpecificityto avoid unnecessarily broad throwables.Prefer more specific catch types than Exception and Throwable.
When methods are updated to throw new checked exceptions they expect
callers to handle failure types explicitly. Catching broad types defeats
the type system. By catching the most specific types possible we
leverage existing compiler functionality to detect unreachable code.
SafeArg.of(when it's a last argument) are no longer unexpectedly split onto the next line.2.40.1
PreferJavaTimeOverloaderror-prone check is turned off as it produces noisy false positives relating to custom AssertJ utilities.2.40.2
2.41.0
No documented user facing changes
2.42.0
NonComparableStreamSortto validate that stream types implement comparable, as opposed to validating that casting to comparable does not cause a compiler error.This commit reduces the severity to WARNING because it's
possible that the check will flag code that happens to work
today, but we strongly recommend against sorting streams of
a type that is not directly comparable without a custom
comparator because it is likely to break later due to lack
of enforcement by the type system.
not enabled by default by providing a comma delimited list of check
names to the
-PerrorProneApplyoption.To enable or disable this check, please contact the maintainers of Excavator.