Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excavator: Upgrades Baseline to the latest version #105

Closed
wants to merge 1 commit into from

Conversation

svc-excavator-bot
Copy link
Collaborator

@svc-excavator-bot svc-excavator-bot commented Nov 22, 2019

excavator is a bot for automating changes across repositories.

Changes produced by the roomba/latest-baseline-oss check.

Release Notes

2.35.2

Type Description Link
Fix Allow declaring that conversion to palantir-java-format has been started, which ensures that conflicting checkstyle rules are removed. palantir/gradle-baseline#1064

2.36.0

Type Description Link
Fix Replace refaster StreamEmpty with error prone StreamOfEmpty to allow refactors to retain type arguments. palantir/gradle-baseline#1068
Improvement RedundantMethodReference check to avoid unnecessary method references palantir/gradle-baseline#1069
Improvement PreferAssertj iterable-map fix retains map type parameters palantir/gradle-baseline#1071

2.37.0

Type Description Link
Improvement refaster will automatically fix up assertions between primitives (a == b) to provide better error messages palantir/gradle-baseline#1078
Improvement Error prone AssertjPrimitiveComparison for primitive comparisons

Prefer using AssertJ fluent comparisons over logic in an assertThat
statement for better failure output. assertThat(a == b).isTrue()
failures report 'expected true' where assertThat(a).isEqualTo(b)
provides the expected and actual values.
palantir/gradle-baseline#1079

2.38.0

Type Description Link
Improvement We now run error-prone 2.3.4, to benefit from smarter static analysis, and hopefully pick up the claimed performance Improvements:

> 40% speedup when run against Google's codebase with errors enabled.
palantir/gradle-baseline#1082

2.39.0

Type Description Link
Improvement Baseline now depends on mockito-errorprone to get Mockito error-prone checks. palantir/gradle-baseline#1085

2.40.0

Type Description Link
Improvement Error prone CatchSpecificity and ThrowSpecificity to avoid unnecessarily broad throwables.

Prefer more specific catch types than Exception and Throwable.
When methods are updated to throw new checked exceptions they expect
callers to handle failure types explicitly. Catching broad types defeats
the type system. By catching the most specific types possible we
leverage existing compiler functionality to detect unreachable code.
palantir/gradle-baseline#1074
Improvement For repos that opted into palantir-java-format, the arguments of SafeArg.of (when it's a last argument) are no longer unexpectedly split onto the next line. palantir/gradle-baseline#1075

2.40.1

Type Description Link
Fix The PreferJavaTimeOverload error-prone check is turned off as it produces noisy false positives relating to custom AssertJ utilities. palantir/gradle-baseline#1094

2.40.2

Type Description Link
Fix Disable ThrowSpecificty and CatchSpecificity fixes by default palantir/gradle-baseline#1098

2.41.0

No documented user facing changes

2.42.0

Type Description Link
Improvement Improve NonComparableStreamSort to validate that stream types implement comparable, as opposed to validating that casting to comparable does not cause a compiler error.

This commit reduces the severity to WARNING because it's
possible that the check will flag code that happens to work
today, but we strongly recommend against sorting streams of
a type that is not directly comparable without a custom
comparator because it is likely to break later due to lack
of enforcement by the type system.
palantir/gradle-baseline#1070
Improvement You may apply specific error-prone refactors including those which are
not enabled by default by providing a comma delimited list of check
names to the -PerrorProneApply option.
palantir/gradle-baseline#1109
Fix Migrate baseline error-prone checks to use jdk13 compatible qualifiers palantir/gradle-baseline#1110

2.43.0

Automated release, no documented user facing changes

2.44.0

Type Description Link
Improvement Document ThrowSpecificity and CatchSpecificity edge cases palantir/gradle-baseline#1118
Improvement Using TaggedMetricRegistry.gauge is equivalent to map.putIfAbsent, and
can result in subtle resource leaks. Prefer replacing existing gauge
values using registerWithReplacement.

This check doesn't apply unless a new enough version of Tritium
is available on the compilation classpath.
palantir/gradle-baseline#1123
Migration All assertj-related code-rewriting now lives in the https://github.com/palantir/assertj-automation repo. palantir/gradle-baseline#1125

2.44.1

Type Description Link
Fix Remove AssertjPrimitiveComparison from default-patch-checks because it has been relocated to assertj-automation. palantir/gradle-baseline#1128

2.45.0

Type Description Link
Improvement Implement BracesRequired error-prone check with suggested fixes
diff<br>- if (condition) statement;<br>+ if (condition) {<br>+ statement;<br>+ }<br>
palantir/gradle-baseline#1130

2.45.1

Type Description Link
Fix The baseline-idea plugin now correctly marks test resources as test resources in IntelliJ. palantir/gradle-baseline#1134

2.46.0

Type Description Link
Improvement Migrate the CollectionStreamForEach refactor to error-prone palantir/gradle-baseline#1139
Feature Configure Intellij to optimize imports on the fly palantir/gradle-baseline#1144

2.47.0

Type Description Link
Feature The com.palantir.baseline-class-uniqueness plugin now records conflicts in a baseline-class-uniqueness.lock file. This should be checked-in to git and makes it easier to incrementally improve projects, rather than requiring a big-bang migration. palantir/gradle-baseline#1145

2.48.0

Type Description Link
Improvement When palantir-java-format is applied to a repo, configure the intellij project to auto-format on save. palantir/gradle-baseline#1151

2.48.1

Type Description Link
Fix Running ./gradlew --write-locks will now update the baseline-class-uniqueness.lock file. palantir/gradle-baseline#1153

2.48.2

Type Description Link
Fix Fix a bug in the Save Actions plugin configuration where it would format any file on save, instead of just java files. palantir/gradle-baseline#1158

2.48.3

Type Description Link
Fix StrictUnusedVariable respects UnusedVariable suppression palantir/gradle-baseline#1160

2.49.0

Type Description Link
Improvement Add error prone LoggerEnclosingClass check. Loggers created using getLogger(Class<?>) must reference their enclosing class. palantir/gradle-baseline#1163

To enable or disable this check, please contact the maintainers of Excavator.

@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 5 times, most recently from a779776 to 1eebce5 Compare December 4, 2019 21:26
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 5 times, most recently from f62a765 to d3f240a Compare December 12, 2019 21:55
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 5 times, most recently from 0dd7910 to 2849e4d Compare December 20, 2019 00:55
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/latest-baseline-oss branch 3 times, most recently from c989d4c to c9f23bd Compare January 10, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant