-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refaster for assertThat(a == b) #1078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
On my todo list to write an error prone rule to make these easier. I think errror-prone would allow us to avoid the duplication, making greaterThan, lessThan, etc feasible for all types (and mixed types) without hundreds of lines of code. 👍 |
This was referenced Dec 2, 2019
This was referenced Dec 2, 2019
This was referenced Dec 16, 2019
This was referenced Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
I just came across this line of code:
Which is bad because if the assertion ever fails, the dev will get an error message like "false did not equal true".
After this PR
==COMMIT_MSG==
refaster will automatically fix up assertions between primitives (a == b) to provide better error messages
==COMMIT_MSG==
Possible downsides?