-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency on mockito-errorprone #1085
Conversation
Generate changelog in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch, thanks!
@@ -7,6 +7,7 @@ apply from: "${rootDir}/gradle/publish-jar.gradle" | |||
|
|||
dependencies { | |||
compile 'com.google.errorprone:error_prone_core' | |||
compile 'org.mockito:mockito-errorprone' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be cleaner to provide it as a runtime dependency since nothing compiles against it. baseline-error-prone isn't used as a library dependency, so it doesn't matter much either way
compile 'org.mockito:mockito-errorprone' | |
runtimeOnly 'org.mockito:mockito-errorprone' |
Released 2.39.0 |
The
MockitoInternalUsage
error-prone check was moved out oferror_prone_core
in google/error-prone@8e821c8. This PR addsorg.mockito:mockito-errorprone
as a dependency ofbaseline-error-prone
to pull in Mockito error-prone checks.