Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on mockito-errorprone #1085

Merged
merged 2 commits into from
Dec 4, 2019

Conversation

pkoenig10
Copy link
Member

The MockitoInternalUsage error-prone check was moved out of error_prone_core in google/error-prone@8e821c8. This PR adds org.mockito:mockito-errorprone as a dependency of baseline-error-prone to pull in Mockito error-prone checks.

@changelog-app
Copy link

changelog-app bot commented Dec 4, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Baseline now depends on mockito-errorprone to get Mockito error-prone checks.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from uschi2000 December 4, 2019 01:35
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thanks!

@@ -7,6 +7,7 @@ apply from: "${rootDir}/gradle/publish-jar.gradle"

dependencies {
compile 'com.google.errorprone:error_prone_core'
compile 'org.mockito:mockito-errorprone'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be cleaner to provide it as a runtime dependency since nothing compiles against it. baseline-error-prone isn't used as a library dependency, so it doesn't matter much either way

Suggested change
compile 'org.mockito:mockito-errorprone'
runtimeOnly 'org.mockito:mockito-errorprone'

@bulldozer-bot bulldozer-bot bot merged commit b4e52e8 into develop Dec 4, 2019
@bulldozer-bot bulldozer-bot bot deleted the pkoenig10/mockitoErrorProne branch December 4, 2019 03:35
@svc-autorelease
Copy link
Collaborator

Released 2.39.0

This was referenced Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants