feat(bun/run): Impl. npm_package_config #3661

trnxdev · 2023-07-17T18:19:29Z

Closes #73

_{Thanks to @InKryption for helping me <3}

src/cli/run_command.zig

src/resolver/package_json.zig

trnxdev · 2023-07-17T22:40:11Z

TODO:

not inline the values
expose it only in bun run
support objects (optional)

trnxdev · 2023-07-18T19:39:56Z

important TODO, currently " " (with space) is being interpreted as "" in bun. it is supposed to be like " " in node.js.
also we need to add objects support, but that can be added in the second version as jarred said

Discord Message with the " " bug

After a bit of investigating and debugging. I found that in zig, the string is correct. but not when comparing it in a js file.

it also happens with ' foo ', it just turns 'foo', after digging even more, it turns out the bun executable strips it. the env is set correctly, because if you run bun run dev and dev launched node, it works correctly. so we might need to address this issue in a different pr.

UPDATE: JULY 20, I just filed an issue on github (#3689) and when talking with someone on the discord server, they supposedly already found the fix, so it might be fixed.

UPDATE: JULY 23, seems to be fixed

trnxdev · 2023-07-28T23:48:22Z

I want to see what happens with arrays in node, I'll check it tomorrow

trnxdev · 2023-07-30T17:39:07Z

interesting... but I think for this version i'll drop the support for arrays, very complicated

* Concurrent Transpiler * Fix bug with some improts and add jsc alias * Some comments * Fix crash * Update module_loader.zig --------- Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>

* return the prop if there are decorators * test and comment

* wasm * WASM test scanner * Update Makefile * Update Makefile * Configurable heap limit * slightly better error * Update js_parser.zig * Update path.test.js * Update node.mjs --------- Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>

* fix iterating headers with `set-cookie` * a test * move work to `HTTPHeaderMap::set` * append set-cookie after sort * remove compare function

- analogous to `npm update` - `bun update <name>` to refresh specified package under `package.json` - `bun update` to refresh all package to latest versions

* fetch data urls * `byteSlice` * deinit slice * allocate `mime_type` string if needed * `content_type_allocated` and uncomment tests * `str_` * createAtom and slice decode result

* fix `Bun.hash` functions to behave as expected * update Bun.hash tests * properly test the returned hash * include murmur32v2 * update Bun.hash docs * run fmt

* almost works * env stuff * test fixes * wtfmove * ok * ok * ref by default * it now does the ref stuff by default * cool

Fixes oven-sh#4057

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>

…h#4064) 2. Avoid duplicating '/' at the beginning of the path. Close: oven-sh#4005

* Fix oven-sh#3820 * Add Module (oven-sh#4074)

…4076)

…ven-sh#3651) * Fix merge issues * oop * make codegen * Fix build issues --------- Co-authored-by: dave caruso <me@paperdave.net>

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>

…sh#4047) * rename callback to func * update testscope to handle function arguments * works * big cleanup * works in debug, not release * fix memory issue & update tests * catch & str test * write types for each() & switch tests to ts * rm & typo * move some code around & support describe * review changes

* 4->16 * add assertions * fix version stuff

trnxdev · 2023-08-09T05:44:38Z

uh--- having troubles..

trnxdev and others added 5 commits July 17, 2023 15:18

Impl. test

e70700c

Fix missing import

4b26291

oops

d37d8bd

Impl. npm_package_config

c750eb5

Merge branch 'main' into tiramify/npm_pkg_cfg

03e26e3

Jarred-Sumner reviewed Jul 17, 2023

View reviewed changes

src/cli/run_command.zig Show resolved Hide resolved

Jarred-Sumner reviewed Jul 17, 2023

View reviewed changes

src/resolver/package_json.zig Show resolved Hide resolved

Jarred-Sumner reviewed Jul 17, 2023

View reviewed changes

src/resolver/package_json.zig Show resolved Hide resolved

trnxdev and others added 4 commits July 18, 2023 17:41

Fixes

a256377

Merge branch 'main' into tiramify/npm_pkg_cfg

882732c

Add support for numbers + booleans

adf1d59

More fixes

487a471

trnxdev and others added 4 commits July 18, 2023 21:44

Oops

66b0ac3

Oops again

ea0fdb7

Last oops

18ba515

Add object support

40553a2

trnxdev mentioned this pull request Jul 19, 2023

Bun trims environment variables #3689

Closed

trnxdev and others added 3 commits July 23, 2023 16:34

Merge branch 'main' into tiramify/npm_pkg_cfg

1012d32

Merge branch 'oven-sh:main' into tiramify/npm_pkg_cfg

3c5c87b

Little fixes

a57fc15

trnxdev requested a review from Jarred-Sumner August 9, 2023 05:25

colinhacks and others added 5 commits August 9, 2023 07:42

Add files (oven-sh#3826)

ba36410

[install] handle workspace:[alias@]range (oven-sh#3819)

fd68a02

Concurrent Transpiler (oven-sh#3816)

5f86b94

* Concurrent Transpiler * Fix bug with some improts and add jsc alias * Some comments * Fix crash * Update module_loader.zig --------- Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>

Don't hoist bun plugin in concurrent transpiler

8c082f4

fix decorator and declare (oven-sh#3828)

e466189

* return the prop if there are decorators * test and comment

colinhacks and others added 26 commits August 9, 2023 07:42

Improve plugin docs

9137cc2

fix iterating headers with set-cookie (oven-sh#4048)

f2a6c8a

* fix iterating headers with `set-cookie` * a test * move work to `HTTPHeaderMap::set` * append set-cookie after sort * remove compare function

implement bun update (oven-sh#4046)

8062976

- analogous to `npm update` - `bun update <name>` to refresh specified package under `package.json` - `bun update` to refresh all package to latest versions

implement fetching data urls (oven-sh#4000)

2703c29

* fetch data urls * `byteSlice` * deinit slice * allocate `mime_type` string if needed * `content_type_allocated` and uncomment tests * `str_` * createAtom and slice decode result

add bun update to help menu

2c38e45

fix worker.ref()

555b46d

Fix Bun.hash functions (oven-sh#4054)

58f46f7

* fix `Bun.hash` functions to behave as expected * update Bun.hash tests * properly test the returned hash * include murmur32v2 * update Bun.hash docs * run fmt

Add env option for node:worker_threads (oven-sh#4052)

7563942

* almost works * env stuff * test fixes * wtfmove * ok * ok * ref by default * it now does the ref stuff by default * cool

Remove printf

aad089f

Enable Headers.prototype.getSetCookie

091c845

Fixes oven-sh#4057

import bun (oven-sh#4055)

069664d

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>

1. Check if the argument is an empty string in path.format. (oven-s…

456189f

…h#4064) 2. Avoid duplicating '/' at the beginning of the path. Close: oven-sh#4005

Update Worker.cpp

b902693

Fix require("console") oven-sh#3820 (oven-sh#4073)

acfd36a

* Fix oven-sh#3820 * Add Module (oven-sh#4074)

Set exports to {} in user-constructed CommonJSModuleRecords (oven-sh#…

c9ee514

…4076)

feat(bun/test): Implement "toSatisfy" & "toIncludeRepeated" (fwup) (o…

230b5ef

…ven-sh#3651) * Fix merge issues * oop * make codegen * Fix build issues --------- Co-authored-by: dave caruso <me@paperdave.net>

worker tests (oven-sh#4058)

22b7ae2

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>

Fix one of the astro segfaults, also fix bun init version (oven-sh#4079)

94454e9

* 4->16 * add assertions * fix version stuff

oops

eb687b4

Impl. npm_package_config

2d792f0

Add support for numbers + booleans

1cd2402

More fixes

f219744

Add object support

fad8866

Little fixes

63320b9

trnxdev mentioned this pull request Aug 9, 2023

feat(bun/run): Impl. npm_package_config (fwup) #4083

Closed

2 tasks

trnxdev closed this Aug 9, 2023

trnxdev deleted the tiramify/npm_pkg_cfg branch August 19, 2023 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(bun/run): Impl. npm_package_config #3661

feat(bun/run): Impl. npm_package_config #3661

trnxdev commented Jul 17, 2023 •

edited

Loading

trnxdev commented Jul 17, 2023 •

edited

Loading

trnxdev commented Jul 18, 2023 •

edited

Loading

trnxdev commented Jul 28, 2023

trnxdev commented Jul 30, 2023 •

edited

Loading

trnxdev commented Aug 9, 2023

feat(bun/run): Impl. npm_package_config #3661

feat(bun/run): Impl. npm_package_config #3661

Conversation

trnxdev commented Jul 17, 2023 • edited Loading

trnxdev commented Jul 17, 2023 • edited Loading

trnxdev commented Jul 18, 2023 • edited Loading

trnxdev commented Jul 28, 2023

trnxdev commented Jul 30, 2023 • edited Loading

trnxdev commented Aug 9, 2023

trnxdev commented Jul 17, 2023 •

edited

Loading

trnxdev commented Jul 17, 2023 •

edited

Loading

trnxdev commented Jul 18, 2023 •

edited

Loading

trnxdev commented Jul 30, 2023 •

edited

Loading