implement fetching data urls #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @dylan-conway 4 files with test failures on bun-darwin-aarch64:
|
|
❌ @dylan-conway 2 files with test failures on linux-x64-baseline:
|
|
❌ @dylan-conway 2 files with test failures on linux-x64:
|
|
❌ @dylan-conway 6 files with test failures on bun-darwin-x64-baseline:
|
src/bun.js/webcore/response.zig
Outdated
| }, | ||
| }, | ||
| .allocator = allocator, | ||
| .status_text = bun.String.create("OK"), |
src/resolver/data_url.zig
Outdated
| @@ -71,22 +71,28 @@ pub const PercentEncoding = struct { | |||
| } | |||
| } | |||
|
|
|||
| if (ret) |some| return allocator.shrink(some, ret_index); | |||
| if (ret) |some| return allocator.realloc(some, ret_index) catch unreachable; | |||
There was a problem hiding this comment.
lets just not reallocate i don't think its necessary
| if (!strings.startsWith(url, "data:")) { | ||
| return null; | ||
| } | ||
|
|
||
| const comma = strings.indexOfChar(url, ',') orelse return null; | ||
| var result = try parseWithoutCheck(url); |
There was a problem hiding this comment.
return try parseWithoutCheck(url);
There was a problem hiding this comment.
but it doesn't matter
There was a problem hiding this comment.
it's actually compiler error, not sure if it's a zig bug
| @@ -34,7 +34,7 @@ pub const PercentEncoding = struct { | |||
| if (comptime Environment.allow_assert) std.debug.assert(str.len > 0); | |||
| return switch (str[0]) { | |||
| 'a'...'z', 'A'...'Z', '0'...'9', '-', '.', '_', '~', '!', '$', '&', '\'', '(', ')', '*', '+', ',', ';', '=', ':', '@' => true, | |||
| '%' => str.len > 3 and isHex(str[1]) and isHex(str[2]), | |||
| '%' => str.len >= 3 and isHex(str[1]) and isHex(str[2]), | |||
trnxdev
pushed a commit
to trnxdev/bun
that referenced
this pull request
Aug 9, 2023
* fetch data urls * `byteSlice` * deinit slice * allocate `mime_type` string if needed * `content_type_allocated` and uncomment tests * `str_` * createAtom and slice decode result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
this adds support for fetching data urls
How did you verify your code works?
added tests for fetching valid and invalid data urls