New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix decorator and declare #3828

Merged

Jarred-Sumner merged 2 commits into main from dylan/fix-decorator-and-declare

Jul 26, 2023

Member

dylan-conway commented Jul 26, 2023

No description provided.

dylan-conway added 2 commits

July 26, 2023 15:44


          return the prop if there are decorators

f5a04b0


          test and comment

95bc099

Jarred-Sumner approved these changes

View reviewed changes

Contributor

github-actions bot commented Jul 26, 2023

❌ @dylan-conway 2 files with test failures on linux-x64:

test/bundler/esbuild/splitting.test.ts
test/js/third_party/svelte/svelte.test.ts

View test output

^{#c785db67e290489415d0a52030888df2bbbe62ec}

Contributor

github-actions bot commented Jul 26, 2023

❌ @dylan-conway 1 files with test failures on linux-x64-baseline:

test/js/third_party/svelte/svelte.test.ts

View test output

^{#c785db67e290489415d0a52030888df2bbbe62ec}

Contributor

github-actions bot commented Jul 26, 2023

❌ @dylan-conway 6 files with test failures on bun-darwin-x64-baseline:

test/js/bun/spawn/spawn-streaming-stdin.test.ts
test/js/bun/sqlite/sqlite.test.js
test/js/third_party/svelte/svelte.test.ts
test/js/third_party/webpack/webpack.test.ts
test/js/web/fetch/fetch-leak.test.js
test/js/web/timers/setTimeout.test.js

View test output

^{#c785db67e290489415d0a52030888df2bbbe62ec}

Jarred-Sumner merged commit 1a558ef into main

Jarred-Sumner deleted the dylan/fix-decorator-and-declare branch

July 26, 2023 23:31

Contributor

github-actions bot commented Jul 26, 2023

❌ @dylan-conway 6 files with test failures on bun-darwin-aarch64:

test/js/bun/net/socket.test.ts
test/js/bun/spawn/spawn.test.ts
test/js/bun/test/test-test.test.ts
test/js/node/watch/fs.watch.test.ts
test/js/third_party/svelte/svelte.test.ts
test/js/web/fetch/fetch-leak.test.js

View test output

^{#c785db67e290489415d0a52030888df2bbbe62ec}

trnxdev pushed a commit to trnxdev/bun that referenced this pull request


          fix decorator and declare (oven-sh#3828)

e466189

* return the prop if there are decorators

* test and comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet