Premint - rename royaltyRecipient to fundsRecipient on premint v2 signature #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2023
Merged
Merged
oveddan
force-pushed
the
rename-royalty-recipient-to-funds-recipient
branch
from
6828515 to
642cc5b
Compare
oveddan
changed the title
oveddan
force-pushed
the
rename-royalty-recipient-to-funds-recipient
branch
from
642cc5b to
81f7546
Compare
oveddan
force-pushed
the
encoded-bytes-in-sig
branch
from
87a2b98 to
6d4233a
Compare
oveddan
changed the base branch from
encoded-bytes-in-sig
to
fix-create-referral-sig
oveddan
force-pushed
the
rename-royalty-recipient-to-funds-recipient
branch
from
81f7546 to
4474cad
Compare
oveddan
force-pushed
the
fix-create-referral-sig
branch
from
94706b4 to
dff91cb
Compare
oveddan
force-pushed
the
rename-royalty-recipient-to-funds-recipient
branch
from
4474cad to
acd8c1e
Compare
oveddan
force-pushed
the
fix-create-referral-sig
branch
from
60dc24b to
41211db
Compare
oveddan
force-pushed
the
rename-royalty-recipient-to-funds-recipient
branch
from
acd8c1e to
575ccbd
Compare
oveddan
changed the base branch from
fix-create-referral-sig
to
premint_create_referral
oveddan
changed the base branch from
premint_create_referral
to
premint-better-mint-arguments
oveddan
force-pushed
the
rename-royalty-recipient-to-funds-recipient
branch
from
575ccbd to
214863d
Compare
oveddan
force-pushed
the
premint-better-mint-arguments
branch
from
1720bf2 to
dcf6b6a
Compare
oveddan
force-pushed
the
rename-royalty-recipient-to-funds-recipient
branch
from
214863d to
d193941
Compare
oveddan
force-pushed
the
premint-better-mint-arguments
branch
from
dcf6b6a to
0012402
Compare
oveddan
force-pushed
the
rename-royalty-recipient-to-funds-recipient
branch
from
d193941 to
b873fa9
Compare
…o better imply what it means
oveddan
changed the base branch from
default-msg-sender
to
premint_create_referral
oveddan
force-pushed
the
rename-royalty-recipient-to-funds-recipient
branch
from
acb98a6 to
8678ee2
Compare
oveddan
changed the title
oveddan
added a commit
that referenced
this pull request
Nov 6, 2023
…o better imply what it means (#289)
This was referenced Nov 6, 2023
Closed
Merged
This was referenced Nov 14, 2023
Closed
Merged
oveddan
pushed a commit
that referenced
this pull request
Apr 8, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @zoralabs/zora-1155-contracts@2.8.0 ### Minor Changes - 13a4785: Adds ERC20 Minter contract which enables NFTs to be purchased with ERC20 tokens ### Patch Changes - 13a4785: Adds first minter reward to ERC20 Minter - 1cf02a4: Add ERC7572 ContracTURIUpdated() event for indexing - 079a596: Moved shared functionality into shared-contracts. premintWithSignerContract takes firstMinter as an argument ## @zoralabs/nft-creator-subgraph@0.1.0 ### Minor Changes - 13a4785: Adds ERC20Minter contract and events to the subgraph - 13a4785: Adds ERC20Minter deployment addresses to the subgraph configs ### Patch Changes - Updated dependencies [13a4785] - Updated dependencies [1cf02a4] - Updated dependencies [ec20ac8] - Updated dependencies [13a4785] - Updated dependencies [079a596] - @zoralabs/zora-1155-contracts@2.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since royalty recipient is both the creator rewarsd recipient and royalty recipient, this PR renames it to
creatorRewardsAndRoyaltyRecipienton the signature, to better imply what it means