Changed premint executor to use simpler method for determining if signer is authorized to sign a premint #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2023
Merged
Closed
Merged
oveddan
changed the title
oveddan
force-pushed
the
get-supported-premint-version
branch
from
85e0a80 to
16241da
Compare
oveddan
force-pushed
the
simplify-auth-method
branch
from
80088df to
af4df44
Compare
This was referenced Nov 13, 2023
Merged
Closed
oveddan
force-pushed
the
get-supported-premint-version
branch
from
9a47b0e to
b5f3019
Compare
oveddan
force-pushed
the
simplify-auth-method
branch
from
949eab2 to
391b405
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
b5f3019 to
24e5de5
Compare
oveddan
force-pushed
the
simplify-auth-method
branch
from
391b405 to
c299eb0
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
24e5de5 to
9bc75d9
Compare
oveddan
force-pushed
the
simplify-auth-method
branch
from
c299eb0 to
f76218e
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
9bc75d9 to
48830c3
Compare
oveddan
force-pushed
the
simplify-auth-method
branch
from
888fa53 to
3eed128
Compare
oveddan
force-pushed
the
get-supported-premint-version
branch
from
48830c3 to
b59a7c1
Compare
oveddan
force-pushed
the
simplify-auth-method
branch
from
3eed128 to
8206c7e
Compare
* updated a front-end test that leverages validation to use zora sepolia
oveddan
force-pushed
the
simplify-auth-method
branch
from
8206c7e to
e0178d5
Compare
This was referenced Nov 17, 2023
Merged
iainnash
pushed a commit
that referenced
this pull request
Jan 5, 2024
…ner is authorized to sign a premint (#344) * Simplified authorization determining methods for premint; Instead of having a bunch of methods that need to decode a signature and determine if a creator is authorized to create premints, just have a single method that determines if the creator is authorized, and put the burden on external clients to decode the signature. * added new premint sdk method to replace existing `isAuthorizedToSign` function that existed on the contract`
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
…ner is authorized to sign a premint (#344) * Simplified authorization determining methods for premint; Instead of having a bunch of methods that need to decode a signature and determine if a creator is authorized to create premints, just have a single method that determines if the creator is authorized, and put the burden on external clients to decode the signature. * added new premint sdk method to replace existing `isAuthorizedToSign` function that existed on the contract`
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
…ner is authorized to sign a premint (#344) * Simplified authorization determining methods for premint; Instead of having a bunch of methods that need to decode a signature and determine if a creator is authorized to create premints, just have a single method that determines if the creator is authorized, and put the burden on external clients to decode the signature. * added new premint sdk method to replace existing `isAuthorizedToSign` function that existed on the contract`
oveddan
pushed a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified authorization determining methods for premint;
Instead of having a bunch of methods that need to decode a signature and determine if a creator is authorized to create premints, just have a single method that determines if the creator is authorized, and put the burden on external clients to decode the signature.
added new premint sdk method to replace existing
isAuthorizedToSignfunction that existed on the contract`