-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove factory impl check in fork test #331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es and us to ignore broken builds
IsabellaSmallcombe
approved these changes
Nov 6, 2023
This was referenced Nov 6, 2023
Merged
Merged
kulkarohan
approved these changes
Nov 8, 2023
kulkarohan
approved these changes
Nov 8, 2023
oveddan
force-pushed
the
remove-factory-impl-check
branch
from
November 8, 2023 23:17
31f6db8
to
b05ceaa
Compare
iainnash
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
Failing fork test that checks for factory impl address happens often, even though code is correct, and can result in masking other errors. This removes that check from the fork tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing fork test that checks for factory impl address happens often, even though code is correct, and can result in masking other errors. This removes that check from the fork tests