Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove factory impl check in fork test #331

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Nov 6, 2023

Failing fork test that checks for factory impl address happens often, even though code is correct, and can result in masking other errors. This removes that check from the fork tests

@oveddan oveddan force-pushed the remove-factory-impl-check branch from 31f6db8 to b05ceaa Compare November 8, 2023 23:17
Copy link
Collaborator

@iainnash iainnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@oveddan oveddan merged commit 2af30cd into main Nov 8, 2023
13 of 14 checks passed
@oveddan
Copy link
Collaborator Author

oveddan commented Nov 8, 2023

Merge activity

iainnash pushed a commit that referenced this pull request Jan 11, 2024
Failing fork test that checks for factory impl address happens often, even though code is correct, and can result in masking other errors.  This removes that check from the fork tests
@iainnash iainnash deleted the remove-factory-impl-check branch January 11, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants