Skip to content

Commit

Permalink
Remove factory impl check in fork test (#331)
Browse files Browse the repository at this point in the history
Failing fork test that checks for factory impl address happens often, even though code is correct, and can result in masking other errors.  This removes that check from the fork tests
  • Loading branch information
oveddan authored Nov 8, 2023
1 parent 865e179 commit 2af30cd
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,6 @@ contract ZoraCreator1155FactoryForkTest is ForkDeploymentConfig, Test {
address factoryAddress = deployment.factoryProxy;
ZoraCreator1155FactoryImpl factory = ZoraCreator1155FactoryImpl(factoryAddress);

assertEq(factory.implementation(), deployment.factoryImpl, "factory implementation incorrect");

assertEq(getChainConfig().factoryOwner, IOwnable(factoryAddress).owner(), string.concat("configured owner incorrect on: ", chainName));

// make sure that the address from the factory matches the stored fixed price address
Expand Down

0 comments on commit 2af30cd

Please sign in to comment.