Skip to content

Commit

Permalink
Rename royaltyRecipient to funds recipient on premint v2 signature, t…
Browse files Browse the repository at this point in the history
…o better imply what it means
  • Loading branch information
oveddan committed Nov 3, 2023
1 parent ad3c720 commit 8678ee2
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions .changeset/violet-starfishes-visit.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ struct TokenCreationConfigV2 {
uint64 mintDuration;
// RoyaltyBPS for created tokens. The royalty amount in basis points for secondary sales.
uint32 royaltyBPS;
// funds for created tokens. The address that will receive creatorRewards, secondary royalties, and paid mint funds.
address royaltyRecipient;
// The address that will receive creatorRewards, secondary royalties, and paid mint funds.
address payoutAddress;
// Fixed price minter address
address fixedPriceMinter;
// create referral
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ struct TokenCreationConfigV2 {
// RoyaltyBPS for created tokens. The royalty amount in basis points for secondary sales.
uint32 royaltyBPS;
// The address that will receive creatorRewards, secondary royalties, and paid mint funds.
address royaltyRecipient;
address payoutAddress;
// Fixed price minter address
address fixedPriceMinter;
// create referral
Expand Down Expand Up @@ -195,7 +195,7 @@ library ZoraCreator1155Attribution {

bytes32 constant TOKEN_DOMAIN_V2 =
keccak256(
"TokenCreationConfig(string tokenURI,uint256 maxSupply,uint64 maxTokensPerAddress,uint96 pricePerToken,uint64 mintStart,uint64 mintDuration,uint32 royaltyBPS,address royaltyRecipient,address fixedPriceMinter,address createReferral)"
"TokenCreationConfig(string tokenURI,uint256 maxSupply,uint64 maxTokensPerAddress,uint96 pricePerToken,uint64 mintStart,uint64 mintDuration,uint32 royaltyBPS,address payoutAddress,address fixedPriceMinter,address createReferral)"
);

function _hashToken(TokenCreationConfigV2 memory tokenConfig) private pure returns (bytes32) {
Expand All @@ -210,7 +210,7 @@ library ZoraCreator1155Attribution {
tokenConfig.mintStart,
tokenConfig.mintDuration,
tokenConfig.royaltyBPS,
tokenConfig.royaltyRecipient,
tokenConfig.payoutAddress,
tokenConfig.fixedPriceMinter,
tokenConfig.createReferral
)
Expand Down Expand Up @@ -266,7 +266,7 @@ library PremintTokenSetup {
maxTokensPerAddress: tokenConfig.maxTokensPerAddress,
mintDuration: tokenConfig.mintDuration,
royaltyBPS: tokenConfig.royaltyBPS,
royaltyRecipient: tokenConfig.royaltyRecipient
payoutAddress: tokenConfig.payoutAddress
});
}

Expand All @@ -280,7 +280,7 @@ library PremintTokenSetup {
maxTokensPerAddress: tokenConfig.maxTokensPerAddress,
mintDuration: tokenConfig.mintDuration,
royaltyBPS: tokenConfig.royaltyBPS,
royaltyRecipient: tokenConfig.royaltyRecipient
payoutAddress: tokenConfig.royaltyRecipient
});
}

Expand All @@ -291,7 +291,7 @@ library PremintTokenSetup {
uint64 maxTokensPerAddress,
uint64 mintDuration,
uint32 royaltyBPS,
address royaltyRecipient
address payoutAddress
) private view returns (bytes[] memory calls) {
calls = new bytes[](3);

Expand All @@ -318,7 +318,7 @@ library PremintTokenSetup {
calls[2] = abi.encodeWithSelector(
IZoraCreator1155.updateRoyaltiesForToken.selector,
newTokenId,
ICreatorRoyaltiesControl.RoyaltyConfiguration({royaltyBPS: royaltyBPS, royaltyRecipient: royaltyRecipient, royaltyMintSchedule: 0})
ICreatorRoyaltiesControl.RoyaltyConfiguration({royaltyBPS: royaltyBPS, royaltyRecipient: payoutAddress, royaltyMintSchedule: 0})
);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ library Zora1155PremintFixtures {
mintStart: 0,
mintDuration: 0,
fixedPriceMinter: address(fixedPriceMinter),
royaltyRecipient: royaltyRecipient,
payoutAddress: royaltyRecipient,
royaltyBPS: 0,
createReferral: address(0)
});
Expand All @@ -46,7 +46,7 @@ library Zora1155PremintFixtures {
mintStart: 0,
mintDuration: 0,
fixedPriceMinter: address(fixedPriceMinter),
royaltyRecipient: royaltyRecipient,
payoutAddress: royaltyRecipient,
royaltyBPS: 10,
createReferral: createReferral
});
Expand Down
2 changes: 1 addition & 1 deletion packages/1155-contracts/test/nft/ZoraCreator1155.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,7 @@ contract ZoraCreator1155Test is Test {
mintStart: 0,
// The duration of the mint, starting from the first mint of this token. 0 for infinite
mintDuration: type(uint64).max - 1,
royaltyRecipient: admin,
payoutAddress: admin,
royaltyBPS: 0,
// Fixed price minter address
fixedPriceMinter: address(fixedPriceMinter),
Expand Down

0 comments on commit 8678ee2

Please sign in to comment.