-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1972076: jsonnet: Disable cpufreq collector in node_exporter #1229
Conversation
@bison: Bugzilla bug 1972076 is in a bug group that is not in the allowed groups for this repo.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The node_exporter cpufreq collector seems to be causing high load on some machines with lots of cores. This disables it temporarily as a workaround until the issue can be addressed upstream. We don't seem to rely on these metrics anywhere. See: https://bugzilla.redhat.com/show_bug.cgi?id=1972076
/lgtm even though we're not sure that node_exporter is the root cause for the kernel soft locks, it might amplify the issue. The procfs library (used to gather the CPU frequency metrics) reads the values from all CPUs in parallel [1] which creates undesired CPU spikes on nodes with many CPUs (prometheus/node_exporter#1880). |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bison, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle Bug 1972076: jsonnet: Disable cpufreq collector in node_exporter |
/retest |
/bugzilla refresh |
@simonpasquier: Bugzilla bug 1972076 is in a bug group that is not in the allowed groups for this repo.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@bison: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherry-pick release-4.8 |
@bison: new pull request created: #1272 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The node_exporter cpufreq collector seems to be causing high load on
some machines with lots of cores. This disables it temporarily as a
workaround until the issue can be addressed upstream. We don't seem
to rely on these metrics anywhere.
See: https://bugzilla.redhat.com/show_bug.cgi?id=1972076