Merge pull request #1229 from bison/no-cpufreq

Bug 1972076: jsonnet: Disable cpufreq collector in node_exporter
openshift · Jul 2, 2021 · a1ce745 · a1ce745
2 parents e852c3f + ed1d1f6
commit a1ce745
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/assets/node-exporter/daemonset.yaml b/assets/node-exporter/daemonset.yaml
@@ -35,6 +35,7 @@ spec:
         - --collector.netdev.device-exclude=^(veth.*)$
         - --collector.cpu.info
         - --collector.textfile.directory=/var/node_exporter/textfile
+        - --no-collector.cpufreq
         image: quay.io/prometheus/node-exporter:v1.1.2
         name: node-exporter
         resources:

diff --git a/jsonnet/node-exporter.libsonnet b/jsonnet/node-exporter.libsonnet
@@ -138,7 +138,19 @@ function(params)
                       // gather that data (especially for bare metal clusters), and
                       // add flags to collect the node_cpu_info metric + metrics
                       // from the text file.
-                      args: [a for a in c.args if a != '--no-collector.hwmon'] + ['--collector.cpu.info', '--collector.textfile.directory=' + textfileDir],
+                      args: [a for a in c.args if a != '--no-collector.hwmon'] +
+                            [
+                              '--collector.cpu.info',
+                              '--collector.textfile.directory=' + textfileDir,
+
+                              // The cpufreq collector seems to be causing high
+                              // load on some nodes with lots of cores.  Disable
+                              // it temporarily as a workaround.
+                              //
+                              // https://bugzilla.redhat.com/show_bug.cgi?id=1972076
+                              // https://github.com/prometheus/node_exporter/issues/1880
+                              '--no-collector.cpufreq',
+                            ],
                       terminationMessagePolicy: 'FallbackToLogsOnError',
                       volumeMounts+: [{
                         mountPath: textfileDir,