Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1972076: jsonnet: Disable cpufreq collector in node_exporter #1229

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Bug 1972076: jsonnet: Disable cpufreq collector in node_exporter #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/node-exporter/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ spec:
- --collector.netdev.device-exclude=^(veth.*)$
- --collector.cpu.info
- --collector.textfile.directory=/var/node_exporter/textfile
- --no-collector.cpufreq
image: quay.io/prometheus/node-exporter:v1.1.2
name: node-exporter
resources:
Expand Down
14 changes: 13 additions & 1 deletion jsonnet/node-exporter.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,19 @@ function(params)
// gather that data (especially for bare metal clusters), and
// add flags to collect the node_cpu_info metric + metrics
// from the text file.
args: [a for a in c.args if a != '--no-collector.hwmon'] + ['--collector.cpu.info', '--collector.textfile.directory=' + textfileDir],
args: [a for a in c.args if a != '--no-collector.hwmon'] +
[
'--collector.cpu.info',
'--collector.textfile.directory=' + textfileDir,

// The cpufreq collector seems to be causing high
// load on some nodes with lots of cores. Disable
// it temporarily as a workaround.
//
// https://bugzilla.redhat.com/show_bug.cgi?id=1972076
// https://github.com/prometheus/node_exporter/issues/1880
'--no-collector.cpufreq',
],
terminationMessagePolicy: 'FallbackToLogsOnError',
volumeMounts+: [{
mountPath: textfileDir,
Expand Down