Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.8] Bug 1981871: jsonnet: Disable cpufreq collector in node_exporter #1272

Merged
merged 1 commit into from
Jul 15, 2021
Merged

[release-4.8] Bug 1981871: jsonnet: Disable cpufreq collector in node_exporter #1272

merged 1 commit into from
Jul 15, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1229

/assign bison

@bison
jsonnet: Disable cpufreq collector in node_exporter
f2c8899 
The node_exporter cpufreq collector seems to be causing high load on
some machines with lots of cores.  This disables it temporarily as a
workaround until the issue can be addressed upstream.  We don't seem
to rely on these metrics anywhere.

See: https://bugzilla.redhat.com/show_bug.cgi?id=1972076
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 9, 2021
Merged
2 tasks
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2021

@openshift-cherrypick-robot: Bugzilla bug 1972076 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

[release-4.8] Bug 1972076: jsonnet: Disable cpufreq collector in node_exporter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bison and paulfantom July 9, 2021 09:42
@bison
Copy link
Contributor

bison commented Jul 9, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2021
@bison
Copy link
Contributor

bison commented Jul 9, 2021

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2021

@bison: Bugzilla bug 1972076 is in a bug group that is not in the allowed groups for this repo.
Allowed groups for this repo are:

  • qe_staff
  • redhat

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jan--f
Copy link
Contributor

jan--f commented Jul 9, 2021

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bison, jan--f, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

15 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson
Copy link
Member

sdodson commented Jul 12, 2021

@bison I will be patch manager this week when things open up, please ping me on slack Wed-Fri if I forget about this.

@simonpasquier
Copy link
Contributor

/retitle [release-4.8] Bug 1981871: jsonnet: Disable cpufreq collector in node_exporter

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 1972076: jsonnet: Disable cpufreq collector in node_exporter [release-4.8] Bug 1981871: jsonnet: Disable cpufreq collector in node_exporter Jul 13, 2021
@simonpasquier
Copy link
Contributor

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jul 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2021

@simonpasquier: This pull request references Bugzilla bug 1981871, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "4.8.z" instead
  • expected dependent Bugzilla bug 1972076 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1981871, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "4.8.z" instead
  • expected dependent Bugzilla bug 1972076 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.8] Bug 1981871: jsonnet: Disable cpufreq collector in node_exporter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@simonpasquier
Copy link
Contributor

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2021

@simonpasquier: This pull request references Bugzilla bug 1981871, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

@openshift-bot: This pull request references Bugzilla bug 1981871, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

@openshift-bot: This pull request references Bugzilla bug 1981871, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "4.8.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jul 15, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

@sdodson: This pull request references Bugzilla bug 1981871, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1972076 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1972076 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao July 15, 2021 13:13
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 15, 2021
@sdodson
Copy link
Member

sdodson commented Jul 15, 2021

I've accepted this into 4.8 because there's an urgent customer case associated with this change.

@sdodson sdodson added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jul 15, 2021
@openshift-merge-robot openshift-merge-robot merged commit 5cfe241 into openshift:release-4.8 Jul 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1981871 has been moved to the MODIFIED state.

In response to this:

[release-4.8] Bug 1981871: jsonnet: Disable cpufreq collector in node_exporter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jul 27, 2021

/cherry-pick release-4.7

@openshift-cherrypick-robot
Copy link
Author

@sdodson: #1272 failed to apply on top of branch "release-4.7":

Applying: jsonnet: Disable cpufreq collector in node_exporter
Using index info to reconstruct a base tree...
M	assets/node-exporter/daemonset.yaml
A	jsonnet/node-exporter.libsonnet
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): jsonnet/node-exporter.libsonnet deleted in HEAD and modified in jsonnet: Disable cpufreq collector in node_exporter. Version jsonnet: Disable cpufreq collector in node_exporter of jsonnet/node-exporter.libsonnet left in tree.
Auto-merging assets/node-exporter/daemonset.yaml
CONFLICT (content): Merge conflict in assets/node-exporter/daemonset.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 jsonnet: Disable cpufreq collector in node_exporter
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arajkumar
Copy link
Contributor

/cherry-pick release-4.7

@openshift-cherrypick-robot
Copy link
Author

@arajkumar: #1272 failed to apply on top of branch "release-4.7":

Applying: jsonnet: Disable cpufreq collector in node_exporter
Using index info to reconstruct a base tree...
M	assets/node-exporter/daemonset.yaml
A	jsonnet/node-exporter.libsonnet
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): jsonnet/node-exporter.libsonnet deleted in HEAD and modified in jsonnet: Disable cpufreq collector in node_exporter. Version jsonnet: Disable cpufreq collector in node_exporter of jsonnet/node-exporter.libsonnet left in tree.
Auto-merging assets/node-exporter/daemonset.yaml
CONFLICT (content): Merge conflict in assets/node-exporter/daemonset.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 jsonnet: Disable cpufreq collector in node_exporter
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jul 28, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison Awaiting requested review from bison

@paulfantom paulfantom Awaiting requested review from paulfantom

@juzhao juzhao Awaiting requested review from juzhao

Assignees

@bison bison

@jan--f jan--f

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@openshift-cherrypick-robot @bison @jan--f @openshift-bot @sdodson @simonpasquier @arajkumar @openshift-merge-robot