-
Notifications
You must be signed in to change notification settings - Fork 0
Commits on Mar 1, 2017
-
remove getAllPerformanceCounters() function
Reviewed By: fkgozali Differential Revision: D4626085 fbshipit-source-id: f07f5a72791176f075d3ce450af4c7ae4cd6fa5c
Configuration menu - View commit details
-
Copy full SHA for 6b738d1 - Browse repository at this point
Copy the full SHA 6b738d1View commit details -
default root node to size of parent contraints
Reviewed By: dshahidehpour Differential Revision: D4634616 fbshipit-source-id: 089eb4313c5bb810a6ff56f158cd19cec71808ec
Configuration menu - View commit details
-
Copy full SHA for 23f2f5f - Browse repository at this point
Copy the full SHA 23f2f5fView commit details -
Fast finish Travis builds, disable tvOS and JS tests
Reviewed By: mkonicek Differential Revision: D4635182 Ninja: Manual import #12603 fbshipit-source-id: f512bf3ce7840b3fbc229e9225e06e3112d849d3
Configuration menu - View commit details
-
Copy full SHA for e44730c - Browse repository at this point
Copy the full SHA e44730cView commit details -
packager: DependencyGraph-test: go through fs.watch mock rather than …
…manual API Reviewed By: davidaurelio Differential Revision: D4628593 fbshipit-source-id: 43ccdb038bd387e87096f2a7020c98d915fa5bba
Configuration menu - View commit details
-
Copy full SHA for 04f42ab - Browse repository at this point
Copy the full SHA 04f42abView commit details -
Reviewed By: jeanlauliac Differential Revision: D4628330 fbshipit-source-id: 94fad1294e22fa0073e15843f94241ae778112a0
Configuration menu - View commit details
-
Copy full SHA for 4d00df4 - Browse repository at this point
Copy the full SHA 4d00df4View commit details -
Packager - Fix absolute imports on Windows
Summary: Absolute imports on Windows were broken, I'm not 100% sure when this happens but when I tested Exponent on Windows which uses `rn-cli.config.js` with ```js getTransformOptions() { return { reactNativePath: path.resolve('./node_modules/react-native'), reactPath: path.resolve('./node_modules/react'), }; } ``` it seemed to use absolute paths for these modules. I also tested absolute paths in node repl and it does work for absolute paths of different formats. `C:/root/test.js`, `/root/test.js`, `C:\root\test.js` all do resolve properly to the same module. To fix this I resolve the absolute path using `path.resolve` on Windows. Noop on other platforms to avoid the overhead since it's not necessary. **Test plan** - Tested that it fixed the bug I had when running Exponent on Windows. - Updated the absolute path test to use forward slashes since this is what happens in practice when using `getTransformOptions`. We can't test all cases on linux since adding the drive letter au Closes #12530 Differential Revision: D4634699 Pulled By: jeanlauliac fbshipit-source-id: 0cf6528069b79cba2e0f79f48f5a524d59b7091e
Configuration menu - View commit details
-
Copy full SHA for 5facc23 - Browse repository at this point
Copy the full SHA 5facc23View commit details -
Move new components out of
Experimental
directorySummary: I think these are sufficiently baked. Also beef up comments. Reviewed By: yungsters Differential Revision: D4632604 fbshipit-source-id: 64ae6b240a05d62e418099f7403e1781f9b4717c
Configuration menu - View commit details
-
Copy full SHA for 7b35eb3 - Browse repository at this point
Copy the full SHA 7b35eb3View commit details -
Fix margin auto for start and end values
Reviewed By: astreet Differential Revision: D4627339 fbshipit-source-id: eebf64e79a34331e79cffcfa3662d4938fbd6c13
Configuration menu - View commit details
-
Copy full SHA for d5a381f - Browse repository at this point
Copy the full SHA d5a381fView commit details -
More efficient decoding of Dynamic value in LayoutShadowNode
Reviewed By: astreet Differential Revision: D4627219 fbshipit-source-id: 1495d58b08af3c619a8dc0d2df655e0c42aa813e
Configuration menu - View commit details
-
Copy full SHA for fb266fc - Browse repository at this point
Copy the full SHA fb266fcView commit details -
Add margin auto support to react native
Summary: This diff adds margin:auto (https://drafts.csswg.org/css-flexbox-1/#auto-margins) support to React Native. This enables layout not previously supported without inserting empty 'spacer' views. See below Playground for usage. ``` class Playground extends React.Component { render() { return ( <View style={{width: '100%', height: '100%', flexDirection: 'row', backgroundColor: 'white'}}> <View style={{width: 100, height: 100, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 'auto', backgroundColor: 'blue'}}/> </View> ); } } ``` Reviewed By: astreet Differential Revision: D4611753 fbshipit-source-id: e78335565c193f7fb263129a638b444715ba5ab0
Configuration menu - View commit details
-
Copy full SHA for cc27555 - Browse repository at this point
Copy the full SHA cc27555View commit details -
Expose alignContent to react native
Summary: This diff adds alignContent (https://developer.mozilla.org/en-US/docs/Web/CSS/align-content) support to React Native. This enables aligning the lines of multi-line content. See below playground for example usage. ``` class Playground extends React.Component { render() { return ( <View style={{width: '100%', height: '100%', flexDirection: 'row', backgroundColor: 'white', flexWrap: 'wrap', alignContent: 'space-between'}}> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, marginLeft: 10, marginTop: 10, backgroundColor: 'red'}}/> </View> ); } } ``` Reviewed By: astreet Differential Revision: D4611803 fbshipit-source-id: ae7f6b4b7e9f4bc78d2502da948214294aad4dd2
Configuration menu - View commit details
-
Copy full SHA for 31f848a - Browse repository at this point
Copy the full SHA 31f848aView commit details -
Add display:none support to react native
Summary: This diff adds display:none support to React Native. This enables hiding components which still calling their render method and keeping them within the state of your application. This enables preserving state in a component even though the component is not visible. Previously this was often implemented by rendering a component off screen as a work around. See below playground for usage. ``` class Playground extends React.Component { render() { return ( <View style={{width: '100%', height: '100%', flexDirection: 'row', backgroundColor: 'white'}}> <View style={{width: 100, height: 100, display: 'none', backgroundColor: 'red'}}/> <View style={{width: 100, height: 100, backgroundColor: 'blue'}}/> </View> ); } } ``` Reviewed By: astreet Differential Revision: D4611771 fbshipit-source-id: 0dbe0494d989df42994ab9ad5125d47f3233cc5a
Configuration menu - View commit details
-
Copy full SHA for 4d69f4b - Browse repository at this point
Copy the full SHA 4d69f4bView commit details -
Move configuration to new YGConfig and pass them down to CalculateLayout
Summary: Move configuration to new ```YGConfig``` and pass them down to CalculateLayout. See #418 . Adds ```YGConfigNew()``` + ```YGConfigFree```, and changed ```YGSetExperimentalFeatureEnabled``` to use the config. New function for calculation is ```YGNodeCalculateLayoutWithConfig```. Closes facebook/yoga#432 Reviewed By: astreet Differential Revision: D4611359 Pulled By: emilsjolander fbshipit-source-id: a1332f0e1b21cec02129dd021ee57408449e10b0
Configuration menu - View commit details
-
Copy full SHA for bdd9aed - Browse repository at this point
Copy the full SHA bdd9aedView commit details -
Reviewed By: mkonicek Differential Revision: D4634272 fbshipit-source-id: 97d22115ffa29456ce253ad8c97a720d0c4e4d53
Configuration menu - View commit details
-
Copy full SHA for d54c7f8 - Browse repository at this point
Copy the full SHA d54c7f8View commit details -
Deprecate NavigationExperimental
Summary: Docs change to encourage people to use React Navigation over other options. Explains a bit of history about Navigator and NavigationExperimental. Remove an intro guide that encourages use of Navigator. Hopefully the existing ReactNav guide fills this void. Navigator docs are less emphasized but still present. Reviewed By: mkonicek Differential Revision: D4634452 fbshipit-source-id: 26763c2f02530009b3dfd20b0590fadcb5ea35ee
Configuration menu - View commit details
-
Copy full SHA for 08dbc43 - Browse repository at this point
Copy the full SHA 08dbc43View commit details -
Move showcase source data into a JSON file
Summary: The showcase is displayed in the homepage as well as in a standalone showcase page. The source data for these two pages is embedded in each page, resulting in repetition of data across both. This PR splits out all of the showcase data to its own file, which is then loaded into the Metadata component during website generation. `cd website && npm start`, then verified index and showcase loaded successfully `cd website && node server/generate.js`, confirmed script runs successfully Closes #12626 Differential Revision: D4632036 Pulled By: hramos fbshipit-source-id: 2d1ad890e78e457205179e36c3ef04ffec354ad9
Configuration menu - View commit details
-
Copy full SHA for 4ee7d94 - Browse repository at this point
Copy the full SHA 4ee7d94View commit details -
Summary: Closes #12488 Differential Revision: D4590699 fbshipit-source-id: 003da4b622e8732ab66c6f2c931670a2eae47eae
Configuration menu - View commit details
-
Copy full SHA for 48a84df - Browse repository at this point
Copy the full SHA 48a84dfView commit details -
Reviewed By: ericvicenti Differential Revision: D4636504 fbshipit-source-id: 89a776902d893c19dff81afcf1cba631c220c9c2
Configuration menu - View commit details
-
Copy full SHA for 18eb7ae - Browse repository at this point
Copy the full SHA 18eb7aeView commit details
Commits on Mar 2, 2017
-
Summary: Also fix some bugs with fbjs requires. Reviewed By: mkonicek Differential Revision: D4635805 fbshipit-source-id: b0663b727632fe5784f1caa1ff20b160a82a3931
Configuration menu - View commit details
-
Copy full SHA for e70cdf0 - Browse repository at this point
Copy the full SHA e70cdf0View commit details -
Improve doc generation with flow types
Reviewed By: vjeux, hramos Differential Revision: D4638610 fbshipit-source-id: 122d6fb68d521b675019a0698b6427960bb2d070
Configuration menu - View commit details
-
Copy full SHA for a7a3922 - Browse repository at this point
Copy the full SHA a7a3922View commit details -
Improve command-line experience for capturing mobile JS heap
Reviewed By: cwdick Differential Revision: D4612319 fbshipit-source-id: 607a09286abdd83368996ffc553b3ce984b62f34
Configuration menu - View commit details
-
Copy full SHA for 8bfab2c - Browse repository at this point
Copy the full SHA 8bfab2cView commit details -
Update Getting Started instructions.
Summary: I am starting fresh on a new Mac and took another stab at the instructions. - Java SDK 7 seems to work just fine. - Adjusted Custom Android Studio installation instructions to use bare minimum required. - Updated AVD configuration instructions with necessary changes to run AVD the first time. - Added note on using real devices. - Removed notes warning against use of API Level 23, these do not belong on a Getting Started guide. - Added step to install Xcode Command Line Tools. - Use `.profile` over `.bashrc` as the latter is shell-specific and is not loaded on login shells (e.g. new Terminal windows). `.profile` will work on bash, however, which is the default macOS shell. - Added screenshots. Went through steps for setting up RN for iOS as well as Android on a new Mac. Ended with apps running on the iOS Simulator and a AVD. Generated website and verified instructions rendered correctly for each of the OS/device permutations. Closes #12272 Differential Revision: D4637737 Pulled By: hramos fbshipit-source-id: 5d322e4d55dbabc70f70471622a2f379ac6230cb
Configuration menu - View commit details
-
Copy full SHA for cf4891c - Browse repository at this point
Copy the full SHA cf4891cView commit details -
BUCK file renaming round 2 (10/13)
Reviewed By: dinhviethoa Differential Revision: D4641351 fbshipit-source-id: f965d3c55313258934d926f6333e2ba161263882
Configuration menu - View commit details
-
Copy full SHA for 906879e - Browse repository at this point
Copy the full SHA 906879eView commit details -
Reviewed By: hramos Differential Revision: D4638645 fbshipit-source-id: 6a37a5fd4e0d8c7769f6c241142b949dba665c34
Configuration menu - View commit details
-
Copy full SHA for d2ed064 - Browse repository at this point
Copy the full SHA d2ed064View commit details -
Set initial opacity based on style
Summary: Set the initial opacity based on the style opacity instead of defaulting to 1. Without this change, if the opacity on the view is set to 0.5 (for example), the component will render with 1 opacity and then after a press and release it will set to 0.5. This fixes it to set to the correct value on mount. **Test plan (required)** Example code: ``` <TouchableOpacity activeOpacity={1} style={STYLES.Button}> {...} </TouchableOpacity> ``` ``` const STYLES = StyleSheet.create({ Button: { opacity: 0.5, }, }); ``` Before (notice starts out dark and then after click and release becomes light): ![before](https://cloud.githubusercontent.com/assets/19673711/23444255/c120cbb0-fde8-11e6-8c03-ef4f0f25736b.gif) After (starts out light and is the same light color after a click and release): ![after](https://cloud.githubusercontent.com/assets/19673711/23444254/c106a6e0-fde8-11e6-8181-def45b7bb84f.gif) Closes #12628 Differential Revision: D4641509 fbshipit-source-id: 3b6cf653fe837df704007f585c655d4450d14497
Configuration menu - View commit details
-
Copy full SHA for f66fba8 - Browse repository at this point
Copy the full SHA f66fba8View commit details -
Summary: Flow improvement: Added ColorPropType on color property on Picker component Closes #12528 Differential Revision: D4619897 Pulled By: ericvicenti fbshipit-source-id: 6356d6f4ae6d2db3d93a56882ec51d140f9ac2ab
Configuration menu - View commit details
-
Copy full SHA for dc334b0 - Browse repository at this point
Copy the full SHA dc334b0View commit details -
Add missing Immutable-List parameter
Reviewed By: kassens Differential Revision: D4636523 fbshipit-source-id: 99bbf32005073ef534c8b7d42109d9a1a1c2f945
Configuration menu - View commit details
-
Copy full SHA for fea8745 - Browse repository at this point
Copy the full SHA fea8745View commit details -
Reviewed By: jeanlauliac Differential Revision: D4642517 fbshipit-source-id: 0882f453eb91c9f12a9e507ccfa60873106d2d71
Configuration menu - View commit details
-
Copy full SHA for 94901b1 - Browse repository at this point
Copy the full SHA 94901b1View commit details -
Summary: This adds blurRadius support for <Image>, similar to iOS. The heavy-lifting was done by lambdapioneer in the stack of diffs ending with D3924013, we're just patching this in. Two notes: we might need to apply two postprocessors going forward, will tackle that in a separate diff, so we can ship this asap. However, we need a new version of fresco to be released in order to ship this. Reviewed By: lexs Differential Revision: D3936438 fbshipit-source-id: 353bf1f1120ebd5f4f8266c5a20188b41478a741
Configuration menu - View commit details
-
Copy full SHA for 0b34809 - Browse repository at this point
Copy the full SHA 0b34809View commit details -
packager: DependencyGraph-test: fix tests
Reviewed By: davidaurelio Differential Revision: D4635348 fbshipit-source-id: 0130496e20d54f5ddf6546823b7a6cba3118917d
Configuration menu - View commit details
-
Copy full SHA for 5d37bfa - Browse repository at this point
Copy the full SHA 5d37bfaView commit details -
packager: ResolutionRequest: use moduleMap instead of hasteMap
Reviewed By: cpojer Differential Revision: D4605535 fbshipit-source-id: bc8394eb296f3fbeda5d8f0f3c17790db8691033
Configuration menu - View commit details
-
Copy full SHA for 067496e - Browse repository at this point
Copy the full SHA 067496eView commit details -
packager: make DependencyGraph.processFileChange private
Reviewed By: davidaurelio Differential Revision: D4635645 fbshipit-source-id: baf3ec75927dfa2d1b29d6548a13453370f434ba
Configuration menu - View commit details
-
Copy full SHA for 0cb2bc1 - Browse repository at this point
Copy the full SHA 0cb2bc1View commit details -
Add deprecation warning for NavigationExperimental
Summary: Starting in RN 0.43, lets start recommending people to move off of NavExperimental, now that a better navigation option is available, and hybrid options on the horizon. Reviewed By: hramos Differential Revision: D4634268 fbshipit-source-id: 2f37cc62f9729ae123d85f609a88f84516a5ae92
Configuration menu - View commit details
-
Copy full SHA for a0f49fc - Browse repository at this point
Copy the full SHA a0f49fcView commit details -
Remove NavigationExperimental examples
Summary: NavigationExperimental is deprecated, so we should avoid documenting it with examples Reviewed By: lacker, hramos Differential Revision: D4634484 fbshipit-source-id: 6c8b114d2a7b49c75ec548025384fa6ed75cb2d2
Configuration menu - View commit details
-
Copy full SHA for da04a6b - Browse repository at this point
Copy the full SHA da04a6bView commit details -
Implement sticky headers in JS using Native Animated
Summary: This re-implements sticky headers in JS to make it work on Android. The only change that was needed was to expose a way to attach a an animated value to an event manually since we can't use the Animated wrapper and `Animated.event` to do it for us because this is implemented directly in the `ScrollView` component. Simply exposed `attachNativeEvent` that takes a ref, event name and event object mapping. This is what is used by `Animated.event`. TODO: - Need to check why momentum scrolling isn't triggering scroll events properly on Android. - Remove native iOS implementation - cleanup / fix flow **Test plan** Test the example list in UIExplorer, test the ListViewPaging example. Closes #11315 Differential Revision: D4450278 Pulled By: sahrens fbshipit-source-id: fec8da2cffce9807d74f8e518ebdefeb6a708667
Configuration menu - View commit details
-
Copy full SHA for 77b8c09 - Browse repository at this point
Copy the full SHA 77b8c09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13b4c2d - Browse repository at this point
Copy the full SHA 13b4c2dView commit details -
in non-lazy mode, log instantiation time for each native module
Reviewed By: alexeylang Differential Revision: D4640157 fbshipit-source-id: cfc1c3114ef97b8ba12839c3814a72b8ece869d6
Configuration menu - View commit details
-
Copy full SHA for f9a3ed3 - Browse repository at this point
Copy the full SHA f9a3ed3View commit details
Commits on Mar 3, 2017
-
log native module initialization time
Reviewed By: alexeylang Differential Revision: D4640369 fbshipit-source-id: 9d1ec353d9b8c4bccb5eedea1fc5d0f6cb414985
Configuration menu - View commit details
-
Copy full SHA for 9f68d95 - Browse repository at this point
Copy the full SHA 9f68d95View commit details -
Android: Remove dependency on recyclerview
Summary: Removing unused code. We used to have this dependency for the RecyclerViewBackedScrollView, which has been removed. **Test plan (required)** Tests pass on Circle CI. Closes #12636 Differential Revision: D4646561 Pulled By: ericnakagawa fbshipit-source-id: 285de78debec306078eb9ad34a2339f95bc42a9c
Configuration menu - View commit details
-
Copy full SHA for ee122be - Browse repository at this point
Copy the full SHA ee122beView commit details -
log onHostResume and onHostPause times
Reviewed By: alexeylang Differential Revision: D4640631 fbshipit-source-id: fe55368b152c96ce631280143d59923aa2e628d3
Configuration menu - View commit details
-
Copy full SHA for d2050a3 - Browse repository at this point
Copy the full SHA d2050a3View commit details -
Summary: flow existentials aren't supported yet. Reviewed By: yungsters Differential Revision: D4649184 fbshipit-source-id: c1294edd4bf15559d7a277816361af9bcca9ad48
Configuration menu - View commit details
-
Copy full SHA for 32d7531 - Browse repository at this point
Copy the full SHA 32d7531View commit details -
Safely fix underline TextInput
Summary: Resubmit of #12493 factoring in the AOSP bug here: https://code.google.com/p/android/issues/detail?id=191754 Reviewed By: achen1 Differential Revision: D4627575 fbshipit-source-id: 8a984852db54be98bd6e781a4d00854d7d0dca68
Configuration menu - View commit details
-
Copy full SHA for dfe09db - Browse repository at this point
Copy the full SHA dfe09dbView commit details -
Use floats to prevent double calculation + float casting on scale
Summary: Use ```float``` for calculation, as we would calculate with ```double``` and cast to float afterwards otherwise. So this removes the warning. Closes facebook/yoga#450 Reviewed By: astreet Differential Revision: D4642267 Pulled By: emilsjolander fbshipit-source-id: 184ef24474f2b8a42654a71a8e98839296648b2b
Configuration menu - View commit details
-
Copy full SHA for 1b79e55 - Browse repository at this point
Copy the full SHA 1b79e55View commit details -
Explicitly set new experimental and a small other improvement
Summary: This sets the new ```YGExperimentalFeatureMinFlexFix``` explicitly to false in the config. It also a changes a stretch reason to reflect that it is the strech in a multiline. Closes facebook/yoga#447 Reviewed By: astreet Differential Revision: D4642275 Pulled By: emilsjolander fbshipit-source-id: 26777db7008ff6ee86da72ca9ea19e979b916cc9
Configuration menu - View commit details
-
Copy full SHA for a1406c4 - Browse repository at this point
Copy the full SHA a1406c4View commit details -
Mark all children as dirty if display changes
Summary: If we set ```display:none``` all children are set with layout sizes/values of 0. We need do mark all those children as dirty to force a relayout if we toggle the display on a higher parent node. This fixes #443 Closes facebook/yoga#448 Reviewed By: astreet Differential Revision: D4642273 Pulled By: emilsjolander fbshipit-source-id: dfdb920e2049952bd6c7f48cfa53b1448e1f3e8f
Configuration menu - View commit details
-
Copy full SHA for 495fb54 - Browse repository at this point
Copy the full SHA 495fb54View commit details -
Added bool config to YGConfig to configure using web defaults
Summary: Added bool config to YGConfig to configure using web defaults. See #445. Closes facebook/yoga#449 Reviewed By: astreet Differential Revision: D4642272 Pulled By: emilsjolander fbshipit-source-id: 4f35bd17b7f764f42295052a4a8b4ae46c192d7e
Configuration menu - View commit details
-
Copy full SHA for e596217 - Browse repository at this point
Copy the full SHA e596217View commit details -
packager: minimize terminal.log() work
Reviewed By: davidaurelio Differential Revision: D4650441 fbshipit-source-id: 2de2c8e5bea29179fd04ef8db67ac385b3f0a06b
Configuration menu - View commit details
-
Copy full SHA for 3e9dedf - Browse repository at this point
Copy the full SHA 3e9dedfView commit details -
Remove semi-colons after class definition
Summary: None of the preceding code examples have semi-colons after the class definition (because they're not necessary): - https://facebook.github.io/react-native/docs/tutorial.html - https://facebook.github.io/react-native/docs/props.html - https://facebook.github.io/react-native/docs/state.html - https://facebook.github.io/react-native/docs/style.html For consistency, I removed them 👍 Closes #12616 Differential Revision: D4651704 fbshipit-source-id: e59fa37c82d61728bc8ee28c7109717bd10635c2
Configuration menu - View commit details
-
Copy full SHA for 8174a0d - Browse repository at this point
Copy the full SHA 8174a0dView commit details -
Reviewed By: hramos Differential Revision: D4649351 fbshipit-source-id: 06cbd735bdb51b6d9d4997a348cbc191193485aa
Configuration menu - View commit details
-
Copy full SHA for 2022b1e - Browse repository at this point
Copy the full SHA 2022b1eView commit details -
Fix missing/renamed files so OSS builds again
Reviewed By: ericvicenti Differential Revision: D4652383 fbshipit-source-id: 04f816c333aba81d936135d7e5fc29a8f9de3af7
Configuration menu - View commit details
-
Copy full SHA for 218e37d - Browse repository at this point
Copy the full SHA 218e37dView commit details -
Default sticky headers enabled on ios only.
Summary: They aren't normal for android, so don't make that the default. some more context: #11315 (comment) Reviewed By: furdei Differential Revision: D4648714 fbshipit-source-id: 3232a6914e3db82c2b300409663ce63412d892a6
Configuration menu - View commit details
-
Copy full SHA for f6aad8b - Browse repository at this point
Copy the full SHA f6aad8bView commit details
Commits on Mar 4, 2017
-
Fix crash with js-based sticky headers
Summary: We're seeing ` inputRange must be monotonically increasing -1,0,0,-33,-32 ` which happens when we have zero height headers, wherever those come from...maybe rendering null? The math was also off and didn't handle variable height headers correctly, and it was confusing because it was `setNextHeaderY` with the header y _minus it's height_, which only works if the prev height was also the same height. Reviewed By: furdei Differential Revision: D4649404 fbshipit-source-id: c2c2d438fa0d0b979c2cbdfa5752eaf86c14768b
Configuration menu - View commit details
-
Copy full SHA for 94a333a - Browse repository at this point
Copy the full SHA 94a333aView commit details -
Fix bug with sticky headers that listen to onLayout
Summary: Wrapping them in ScrollViewStickyHeader broken the onLayout and would always give y = 0 because it is now relative to the wrapper. This uses some not-so-great react magic, but fixes the bugs with no aparent side-effects. Note we also need to kill the StaticRenderer wrapper that ListView introduces. I think this was probably a premature optimization anyway since there are usually not many headers and they are usually pretty cheap to render. If people care, they can use `shouldComponentUpdate` with the rendered components. Reviewed By: yungsters Differential Revision: D4654622 fbshipit-source-id: 1ea557ef64327d1f4df53b22fedd678da1549288
Configuration menu - View commit details
-
Copy full SHA for 500dd2c - Browse repository at this point
Copy the full SHA 500dd2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e2d7f0 - Browse repository at this point
Copy the full SHA 7e2d7f0View commit details
Commits on Mar 5, 2017
-
iOS: fixed RCTDevSettings executor-override handling
Summary: RCTDevSettings incorrectly assigned "bad" executor-override class to the executor instead of checking if the class exists before assigning it. It should really check if the class exists, and fallback to defaults otherwise. Reviewed By: mmmulani, yungsters Differential Revision: D4655926 fbshipit-source-id: 48c8fe28f22aaa8430752411ce5e6e858dbd4b32
Configuration menu - View commit details
-
Copy full SHA for c04e79e - Browse repository at this point
Copy the full SHA c04e79eView commit details -
Reviewed By: yungsters Differential Revision: D4654335 fbshipit-source-id: 2913c3b4b04db140adc06b484ea2a64c673c6ad0
Configuration menu - View commit details
-
Copy full SHA for 6378333 - Browse repository at this point
Copy the full SHA 6378333View commit details -
VirtualizedList - trigger this.props.onContentSizeChange
Summary: Have tested this and works fine ``` <SectionList onLayout={this.onLayout} ref={thisRef => this.listView = thisRef} ListFooterComponent={this.renderFooter} renderItem={this._renderRow} onScroll={this._onScroll} onContentSizeChange={this.contentSizeChanged} renderSectionHeader={this._renderSectionHeader} sections={this.props.data} /> Closes #12708 Differential Revision: D4656338 Pulled By: sahrens fbshipit-source-id: a2b585aa80247ff0dc2261b740003a6e77cb7a97
Configuration menu - View commit details
-
Copy full SHA for e3ef695 - Browse repository at this point
Copy the full SHA e3ef695View commit details -
Reviewed By: gabelevi Differential Revision: D4652687 fbshipit-source-id: 6069c8bc24f0b88da3537ada877cdb7d1d4eccfd
Configuration menu - View commit details
-
Copy full SHA for 59257d6 - Browse repository at this point
Copy the full SHA 59257d6View commit details -
Native Animated - Support multiple events attached to the same prop
Summary: Fixes a bug that happens when trying to use ScrollView with sticky headers and native `Animated.event` with `onScroll`. Made a few changes to the ListViewPaging UIExplorer example to repro https://gist.github.com/janicduplessis/17e2fcd99c6ea49ced2954d881011b09. What happens is we need to be able to add multiple events to the same prop + viewTag pair. To do that I simple changed the data structure to `Map<prop+viewTag, List<AnimatedEventDriver>>` and try to optimize for the case where there is only one item in the list since it will be the case 99% of the time. **Test plan** Tested by reproducing the bug with the above gist and made sure it was fixed after applying this diff. Closes #12697 Differential Revision: D4656347 Pulled By: sahrens fbshipit-source-id: b5c36ba796f478e56028c7a95bc0f86bc54cb2ce
Configuration menu - View commit details
-
Copy full SHA for c708234 - Browse repository at this point
Copy the full SHA c708234View commit details -
Improve iOS' running on device instructions
Summary: Add missing step needed to run your project on a device Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: > **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.** Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob Closes #12718 Differential Revision: D4657289 Pulled By: ericvicenti fbshipit-source-id: f73736027d3872c63046c8a46307e9b486b4d444
Configuration menu - View commit details
-
Copy full SHA for cdcd620 - Browse repository at this point
Copy the full SHA cdcd620View commit details -
Remove unused native iOS sticky headers implementation
Summary: Remove the native iOS sticky headers implementation that has been replaced by the js Animated one. Also remove a line in JS that made sure we passed null to native so it did not use the native implementation. **Test plan** Made sure there were no more mentions of sticky / header in native ScrollView related code. Tested that sticky headers still work :o Closes #12696 Differential Revision: D4657391 Pulled By: ericvicenti fbshipit-source-id: 16324a45ca4ce5cd143293c61394a0fa7ad0c4a1
Configuration menu - View commit details
-
Copy full SHA for 5353d39 - Browse repository at this point
Copy the full SHA 5353d39View commit details
Commits on Mar 6, 2017
-
Fix symlink resolving for examples in the repo
Summary: Motivation: Few days ago gaearon [filed an issue](#12406) that examples in the react-native repo doesn't work after the [recent changes in local-cli](bce6ece). This PR fixes reported bug. **Test plan (required)** - No UI changes - [x] Run UIExplorer from XCode (no package.json in the folder) and check if packager/application runs correctly cc davidaurelio satya164 grabbou Closes #12435 Differential Revision: D4657370 Pulled By: ericvicenti fbshipit-source-id: 72ee4b96cae37c7ed2794ed4490ce7b4fbbd66c3
Configuration menu - View commit details
-
Copy full SHA for c97c1e5 - Browse repository at this point
Copy the full SHA c97c1e5View commit details -
Inherit WebSocket protocol scheme in case of http and https
Summary: **Motivation** Currently, when supplying a URL with protocol scheme `http` or `https` to the WebSocket module: ``` new WebSocket("http://10.0.2.2:8080") ``` it will result in the following error: ![Unable to get cookie from http://10.0.2.2:8080](https://cloud.githubusercontent.com/assets/661993/23584771/f3f9573e-011f-11e7-839e-eb100c8cb5d2.png) When a WebSocket URL with protocol scheme `http` or `https` is used the method [`getDefaultOrigin`](https://github.com/facebook/react-native/blob/be4afdde37ab6ff6ebe573821745887fd3edfb05/ReactAndroid/src/main/java/com/facebook/react/modules/websocket/WebSocketModule.java#L274-L301) will fail to substitute it and just returns a URL with empty protocol scheme leading to this opaque exception. Thus, in case of `http` or `https` it should just inherit the protocol scheme since the WebSocket is responsible for upgrading the HTTP/HTTPS connection to the WebSocket protocol. **Test plan** If anything this change makes the method more robust. The WebSock Closes #12713 Differential Revision: D4657738 Pulled By: ericvicenti fbshipit-source-id: 8835b539e94713355e063a2639b7293c764b084b
Configuration menu - View commit details
-
Copy full SHA for 4d4028d - Browse repository at this point
Copy the full SHA 4d4028dView commit details -
Summary: When running the Movies Example, the application displays an error message: "Cannot read property 'total' of undefined". <img width="374" alt="capture d ecran 2017-03-01 a 21 26 50" src="https://cloud.githubusercontent.com/assets/3247607/23479864/2871c52a-fec6-11e6-9266-8a5fe44adfe4.png"> This is due to the fact that the API call raised an error, and the catch block is followed by a then block, which means that the code in the second then bloc will be executed. The fix is to move the catch at the last position, to prevent any further execution in case of network error. Closes #12641 Differential Revision: D4657739 Pulled By: ericvicenti fbshipit-source-id: bdc58d2b89a7d2a53de716773e7bc8a735fa2e45
Configuration menu - View commit details
-
Copy full SHA for c4e73dd - Browse repository at this point
Copy the full SHA c4e73ddView commit details -
Summary: Changes to setState will cause re-renders. **Test plan (required)** Textual changes only - on Markdown only Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests). Closes #12647 Differential Revision: D4658053 Pulled By: ericvicenti fbshipit-source-id: 0d9cde8f9710b4e0f7d7f82214d8eeda0bf3c135
Configuration menu - View commit details
-
Copy full SHA for caa9d84 - Browse repository at this point
Copy the full SHA caa9d84View commit details -
Remove reference to react-router-native
Summary: We're currently taking ownership of react-router-native and have shipped several beta releases that do not wrap the NavigationExperimental API. In order to avoid confusion, I'd appreciate it if we could avoid mentioning react-router-native here. Thanks :) Closes #12691 Differential Revision: D4654551 Pulled By: hramos fbshipit-source-id: d1f393cefc87f087d4e9c19b7cbee861f0a2d29a
Configuration menu - View commit details
-
Copy full SHA for c535c26 - Browse repository at this point
Copy the full SHA c535c26View commit details -
Run install third party script as part of the xcode build
Summary: Runs the `./ios-install-third-party.sh` script as part of the build process to avoid having to do it manually when building the cxx bridge with xcode. Also added the third-party dir to gitignore. **Test plan** Tested that just building works when the third-party dir is missing. Closes #12694 Differential Revision: D4658165 Pulled By: ericvicenti fbshipit-source-id: 9b51b88eb26637b19266bf85deafa41e3a77a645
Configuration menu - View commit details
-
Copy full SHA for 7d06c35 - Browse repository at this point
Copy the full SHA 7d06c35View commit details -
CLI: Assign project root concat back to project roots.
Summary: With the latest version of React Native I noted my setup with React Native Storybook stopped working because it stopped searching all the right project roots. I found that it had to do with the change here bce6ece **Test plan (required)** Run the CLI with a project root other then the root directory and ensure that it displays both the specified project root and the actual root directory. Closes #12659 Differential Revision: D4658137 Pulled By: ericvicenti fbshipit-source-id: 97d3784348f92394df111f189c6b00dd0165b75e
Configuration menu - View commit details
-
Copy full SHA for 4471c32 - Browse repository at this point
Copy the full SHA 4471c32View commit details -
Fix linking manager library name in documentation
Summary: I had an issue while using ```#import "RCTLinkingManager.h"``` ![image](https://cloud.githubusercontent.com/assets/1089932/22933908/523cf910-f2cd-11e6-9c20-b3c298d5b7cc.png) But when replaced with ```#import <React/RCTLinkingManager.h>``` the build succeeds. Looks fine on the website: ![image](https://cloud.githubusercontent.com/assets/1089932/22934563/b1ff337a-f2cf-11e6-9109-b133aef1d69c.png) Closes #12383 Differential Revision: D4658153 Pulled By: ericvicenti fbshipit-source-id: e48368c08cb27bf68ea2f1294129669896350f34
Configuration menu - View commit details
-
Copy full SHA for f126540 - Browse repository at this point
Copy the full SHA f126540View commit details -
packager: node-haste: remove getHasteMap()
Reviewed By: davidaurelio Differential Revision: D4597906 fbshipit-source-id: 4e239d0278fd79a8c60944b71e127e5a335b066f
Configuration menu - View commit details
-
Copy full SHA for c77f09b - Browse repository at this point
Copy the full SHA c77f09bView commit details -
Merge Android UI Performance into Performance doc, reorder sidebar
Summary: Doing some cleanup in preparation for CRNA. Recommend `FlatList` and React Navigation for perf. Tag docs that may only apply to apps ejected from CRNA. Currently has no effect. Closes #12692 Differential Revision: D4654077 Pulled By: hramos fbshipit-source-id: 1245d80d66e37d9dca9e9daf23e8b93c65cd1bf7
Configuration menu - View commit details
-
Copy full SHA for c503dae - Browse repository at this point
Copy the full SHA c503daeView commit details -
Summary: TabBarIOS has a dummy module on Android, but it doesn't export TabBarIOSItem so if you try to use TabBarIOS.Item you'll get a redbox. Reviewed By: frantic Differential Revision: D4653962 fbshipit-source-id: 36ca2527d8eac2d28d35c3ac69ced5bf50b2e682
Configuration menu - View commit details
-
Copy full SHA for 5e20b7b - Browse repository at this point
Copy the full SHA 5e20b7bView commit details -
Summary: Doing some cleanup here, mostly removing entries that lack an engineering blog post focused on React Native. - Removes links to F8 2016 app. New entry coming soon! - Add [Tesla](https://twitter.com/timdorr/status/830423561592532993)! - Update some article titles, and link to newer content Closes #12693 Differential Revision: D4654541 Pulled By: hramos fbshipit-source-id: 3b22309ecc344fb5de2bcab36a64b69dd55c2f78
Configuration menu - View commit details
-
Copy full SHA for 8f0c16d - Browse repository at this point
Copy the full SHA 8f0c16dView commit details -
revert D4656347 to fix crashes
Reviewed By: jingc Differential Revision: D4659669 fbshipit-source-id: 2c95c212a19cc8b67ce4ec62963c8374aecb3ef6
Configuration menu - View commit details
-
Copy full SHA for b87f4ab - Browse repository at this point
Copy the full SHA b87f4abView commit details -
Workaround for P/Invoke AccessViolationException
Summary: The issue is on ARM builds for Windows UWP. For the C# P/Invoke API wrapper, any native method that returns the YogaValue struct throws the AccessViolationException. The issue is not with structs in general, as returning the YogaSize / YGSize struct works fine. The issue seems to be limited to structs that have an enum member. I tried a number of things to resolve the issue without changing the underlying native API for Windows. I read the ARM documentation and saw reference to variable enum sizes based on the number of enum members, so I tried to use a number of different UnmanagedType values in a [MarsalAs()] attribute on the enum member of the C# struct declaration. What ultimately worked was to return a pointer to the location of the struct, and use the System.Runtime.InteropServices.PtrToStructure API to read the struct data from that pointer. I added a few new macros that will return the struct address on Windows only, other builds are not affected. Note, I have not tested the impact of this ch Closes facebook/yoga#459 Reviewed By: emilsjolander Differential Revision: D4652278 Pulled By: splhack fbshipit-source-id: bf7ada4da1781e3f813b3ba331974b7bded476d9
Configuration menu - View commit details
-
Copy full SHA for dd5798b - Browse repository at this point
Copy the full SHA dd5798bView commit details -
Updating the info about Myntra
Summary: Updating the info about Myntra We've also gotten our Android apps on React Native now. I also gave a talk on our journey and have updated the infoLink for the same. I currently work for Myntra. Closes #12736 Differential Revision: D4659904 Pulled By: hramos fbshipit-source-id: c2a93d34e56979c05106d378695dbc5345bf9a2c
Configuration menu - View commit details
-
Copy full SHA for 31c9943 - Browse repository at this point
Copy the full SHA 31c9943View commit details -
Drop calls to [RCTCxxBridge enqueueCallback:args:] on an invalid inst…
…ance Reviewed By: mmmulani Differential Revision: D4655339 fbshipit-source-id: a6cb026325a030fa15a25638ebfb17ac9ea53767
Configuration menu - View commit details
-
Copy full SHA for d1411f1 - Browse repository at this point
Copy the full SHA d1411f1View commit details -
Export Alert's type ButtonsArray for external use
Reviewed By: mmmulani Differential Revision: D4623764 fbshipit-source-id: 9c4edc98e15603bdae180ec4b6c27b677bba1d53
Configuration menu - View commit details
-
Copy full SHA for 4e437c1 - Browse repository at this point
Copy the full SHA 4e437c1View commit details -
Clean up objc-test-ios.sh, include tvOS build check
Summary: **Motivation**: Having full tests for both iOS and tvOS is hard on Travis, and it's probably ok to not run full tests on tvOS. However, we should make sure that tvOS at least builds and doesn't have missing files. Also fixed a warning import. Closes #12642 Differential Revision: D4661571 Pulled By: mkonicek fbshipit-source-id: 45932113951c01e35d6e8ce91af2522cb135efe8
Configuration menu - View commit details
-
Copy full SHA for 4c79df9 - Browse repository at this point
Copy the full SHA 4c79df9View commit details -
android: add ReactInstancePackage abstract class to pass down ReactIn…
…stanceManager to create modules Summary: At times, ReactPackage needs to get information from the ReactInstanceManager, e.g. to get the DevSupportManager for debugging purpose. This allows passing down the instance manager to create the native modules, in addition to just ReactApplicationContext. It is then up to the Package to use it or not. To use this, you must make your package class extends ReactInstancePackage, instead of just implementing ReactPackage interface. Reviewed By: mmmulani Differential Revision: D4641997 fbshipit-source-id: 497c4408a7d2b773c49f08bff7c1bf8f9d372edb
Configuration menu - View commit details
-
Copy full SHA for 7acf741 - Browse repository at this point
Copy the full SHA 7acf741View commit details
Commits on Mar 7, 2017
-
Support for defineEnumerableProperties
Summary: **Motivation** detailed in #12702. **Test plan** 1) running [a piece of code](mobxjs/mobx#839 (comment)) that utilizes the helper without any modifications on the react native package results an error being thrown. ![b589a71-0041-11e7-9d47-cb79efff3ba5](https://cloud.githubusercontent.com/assets/23000873/23579517/3c8fe992-0100-11e7-9eb5-93c47f3df3e0.png) 2) updating the list of helpers available by adding the definition of `defineEnumerableProperties` as provided by babel [babel/babel/packages/babel-helpers/src/helpers.js](https://github.com/babel/babel/blob/master/packages/babel-helpers/src/helpers.js#L275-L285) results no errors. ![kapture 2017-03-04 at 16 48 35](https://cloud.githubusercontent.com/assets/23000873/23579520/457b8ca0-0100-11e7-8ca4-c704c6e9631f.gif) Closes #12703 Differential Revision: D4658120 Pulled By: ericvicenti fbshipit-source-id: 914aed4d313b3cc4f7ab99049d05d0aef269a3be
Configuration menu - View commit details
-
Copy full SHA for 160b1c8 - Browse repository at this point
Copy the full SHA 160b1c8View commit details -
<TextView>.onContentSizeChange
now fires on ANY content changing ci……rcumstances Reviewed By: blairvanderhoof Differential Revision: D4625916 fbshipit-source-id: 80191a07edaf404a70a7571ada2d849619407bda
Configuration menu - View commit details
-
Copy full SHA for 4040e89 - Browse repository at this point
Copy the full SHA 4040e89View commit details -
Summary: fs-extra's first stable release is out since 1 of November. I think its time to upgrade to 1.0.0. We've been running 1.0.0 locally and is having no problems with it. **Test plan (required)** Walked through the commits from 0.30 to 1.0.0 and no breaking changes has been made to the repository. jprichardson/node-fs-extra@1.0.0...1.x Closes #11542 Reviewed By: zertosh Differential Revision: D4444576 Pulled By: hramos fbshipit-source-id: 520311af8dc0911c026c08bdb74bec6572e7e17f
Configuration menu - View commit details
-
Copy full SHA for 9959db2 - Browse repository at this point
Copy the full SHA 9959db2View commit details -
Tweak presentation of Colors guide.
Summary: Explain a bit more how these are used. Closes #12753 Differential Revision: D4663972 Pulled By: hramos fbshipit-source-id: acbda6593e3f2a01776d2208f6ef3bc69bca0eef
Configuration menu - View commit details
-
Copy full SHA for 3f6476f - Browse repository at this point
Copy the full SHA 3f6476fView commit details -
warn about PureComponent in docs
Reviewed By: hramos Differential Revision: D4663872 fbshipit-source-id: cb2bd2a2d588a9419da7517304d0612e259151e3
Configuration menu - View commit details
-
Copy full SHA for 293bb36 - Browse repository at this point
Copy the full SHA 293bb36View commit details -
Reviewed By: hramos Differential Revision: D4635928 fbshipit-source-id: 751cfbb8ce50be4ae7248069e9f4c04384c3eced
Configuration menu - View commit details
-
Copy full SHA for e32e4d9 - Browse repository at this point
Copy the full SHA e32e4d9View commit details -
move NativeModule initialization off UI thread
Summary: Initializing natives modules on the UI thread blocks the JS thread if the UI thread is busy. Reviewed By: yungsters Differential Revision: D4611211 fbshipit-source-id: cd4fb9cb5e52a478b6692b784cfd9e3bf34c0d34
Configuration menu - View commit details
-
Copy full SHA for b085215 - Browse repository at this point
Copy the full SHA b085215View commit details -
Fix unmount crash when using sticky headers
Reviewed By: bvaughn Differential Revision: D4659436 fbshipit-source-id: c04394681a4f07599f16bae195313e6617419404
Configuration menu - View commit details
-
Copy full SHA for 7005f54 - Browse repository at this point
Copy the full SHA 7005f54View commit details -
Fix crash with empty section headers
Summary: It's ok for them to be empty, so we should check! Reviewed By: yungsters Differential Revision: D4664411 fbshipit-source-id: c66e98458708eee59757fa665b3a05972f1c1b70
Configuration menu - View commit details
-
Copy full SHA for 28b43aa - Browse repository at this point
Copy the full SHA 28b43aaView commit details -
Simplify scroll interaction stuff
Reviewed By: angelahess Differential Revision: D4662787 fbshipit-source-id: 6e28f8cacd08601254e70f30ab98ee27bd08cc5a
Configuration menu - View commit details
-
Copy full SHA for 9325496 - Browse repository at this point
Copy the full SHA 9325496View commit details -
Move BackAndroid -> BackHandler, add Apple TV support for back nav
Summary: Enable back navigation on Apple TV (with the remote's menu button) in code making use of BackAndroid. The module is renamed to BackHandler. BackAndroid is still exported to ReactNative for now, until external projects switch to using the new name for the module. The navigation in https://github.com/react-community/react-navigation makes use of this module. **Test plan**: Manual testing with an example app (https://github.com/dlowder-salesforce/react-nav-example). Closes #12571 Differential Revision: D4665152 Pulled By: ericvicenti fbshipit-source-id: 925400ce216379267e014457be6f5eedbe4453ec
Configuration menu - View commit details
-
Copy full SHA for b7e9374 - Browse repository at this point
Copy the full SHA b7e9374View commit details -
Add new
forkEvent
/unforkEvent
APIReviewed By: vjeux Differential Revision: D4648427 fbshipit-source-id: 9bbbd81f49a9363ac271b3906d73f937f0d1f500
Configuration menu - View commit details
-
Copy full SHA for 5257c35 - Browse repository at this point
Copy the full SHA 5257c35View commit details -
Summary: Closes #12766 Differential Revision: D4666410 Pulled By: hramos fbshipit-source-id: 6eef74352414f2c138670f58ac1cb2c39787f3a3
Configuration menu - View commit details
-
Copy full SHA for b698b4a - Browse repository at this point
Copy the full SHA b698b4aView commit details -
When building open source React Native, make Buck use the same versio…
…n of Support Library as Gradle uses, and as we use internally Reviewed By: bestander Differential Revision: D4666693 fbshipit-source-id: a9a15164498353759a14630e2ce78a4a00e9c855
Configuration menu - View commit details
-
Copy full SHA for 53c7f1d - Browse repository at this point
Copy the full SHA 53c7f1dView commit details -
Add build-time check that module methods are exported correctly
Summary: This prevents someone from only putting `RCT_EXPORT_METHOD(...)` around some of the arguments to a method and generally causing confusion. Yes, before this diff it would still compile correctly if you did something like: ``` RCT_EXPORT_METHOD(lol:(NSNumber *)lol) blah:(id)blah { NSLog(@"%@ %@", lol, blah); } ``` Reviewed By: fkgozali Differential Revision: D4660019 fbshipit-source-id: 1829a47e5c8d5e8ce93edca2ac7efd7e2bfdf840
Configuration menu - View commit details
-
Copy full SHA for 0a06250 - Browse repository at this point
Copy the full SHA 0a06250View commit details -
Upgrade double-conversion to 1.1.5
Reviewed By: ericvicenti Differential Revision: D4662924 fbshipit-source-id: ecf4a3d8aee8a3def1d8308456ca2551b4669f63
Configuration menu - View commit details
-
Copy full SHA for cb3a439 - Browse repository at this point
Copy the full SHA cb3a439View commit details -
Website: Fix aspect ratio of icons in the showcase on homepage
Summary: I ran the website locally and noticed the icons in the showcase on the homepage look squashed: ![screenshot 2017-03-07 22 28 23](https://cloud.githubusercontent.com/assets/346214/23681227/18fbec6e-0386-11e7-9658-93907cbb3337.png) Made the icons consistent with /showcase.html: https://github.com/facebook/react-native/blob/d54c7f82822f623a903858d8d686d7f14ec71aae/website/styles/_showcase.scss#L74 Closes #12773 Differential Revision: D4669767 Pulled By: hramos fbshipit-source-id: be5a758dd912083fc02c8e0b56c30c8617dcf3df
Configuration menu - View commit details
-
Copy full SHA for b8e8b72 - Browse repository at this point
Copy the full SHA b8e8b72View commit details
Commits on Mar 8, 2017
-
preserve inline components in prop type doc gen
Summary: Some of the operations, like `oneOf` and `arrayOf`, were doing joins on arrays of potential tags, like `<span>` or `<a>`, which would stringify them to `[object Object]`. This introduces a new `spanJoinMapper` which suppresses the trailing separator like `join` but wraps elements in `<span>` rather than `concat`ing into a string. Latest master is pretty broken: {F66059444} Nested `color` and some other props were broken even before a7a3922 {F66059446} All fixed in this diff: {F66059445} Reviewed By: mkonicek Differential Revision: D4670441 fbshipit-source-id: ddc10f13b3bdc6a1e799fa06a4e206f8dbd08769
Configuration menu - View commit details
-
Copy full SHA for 7eded2d - Browse repository at this point
Copy the full SHA 7eded2dView commit details -
added RCTLog.logToConsole() to force log regardless of debugger conne…
…ction Summary: This adds an alternative logging method that can be called from native side. `logIfNoLoggingHook()` will pass the message to console only if there's Chrome debugger attached. This new method sends the message to console regardless to notify the developers better. Reviewed By: yungsters Differential Revision: D4669663 fbshipit-source-id: 3940816dadd08d450f066b7223f6d26a38a70921
Configuration menu - View commit details
-
Copy full SHA for 1a8d216 - Browse repository at this point
Copy the full SHA 1a8d216View commit details -
Replace defaultLink with infoLink in Showcase
Reviewed By: ericvicenti Differential Revision: D4671154 fbshipit-source-id: ee9df269b91ec140afc8dace9bbf960f9a47f0b0
Configuration menu - View commit details
-
Copy full SHA for f65a3c4 - Browse repository at this point
Copy the full SHA f65a3c4View commit details -
Reviewed By: hramos Differential Revision: D4670890 fbshipit-source-id: e8429aa88a1d4f3cc80034dd087739410c0761f2
Configuration menu - View commit details
-
Copy full SHA for a8474c2 - Browse repository at this point
Copy the full SHA a8474c2View commit details -
enable Systracing is JS before JSBundle finishes loading
Reviewed By: alexeylang Differential Revision: D4671771 fbshipit-source-id: 5cd12bf84f25d4c3b188cf32907415b5a695b360
Configuration menu - View commit details
-
Copy full SHA for 7978f7a - Browse repository at this point
Copy the full SHA 7978f7aView commit details -
Use different function syntax that the JS parser used to build the we…
…bsite can understand Summary: For some reason the parser doesn't support that syntax. It fails with: ``` Cannot parse file ../Libraries/Animated/src/AnimatedImplementation.js Error: parseSource returned falsy at parseAPIInferred (/home/ubuntu/react-native/website/server/extractDocs.js:343:13) ``` Reviewed By: sahrens Differential Revision: D4669961 fbshipit-source-id: 3536c94b8f385f5810c47544c4a72c8c785bf0e5
Configuration menu - View commit details
-
Copy full SHA for adf650d - Browse repository at this point
Copy the full SHA adf650dView commit details -
Move iOS Maps out of the GitHub repo to internal fb codebase
Summary: MapView has been deprecated in open source for a while: http://facebook.github.io/react-native/docs/mapview.html We still want to use it internally. Moving it away from the GitHub folder. Reviewed By: mmmulani Differential Revision: D4646199 fbshipit-source-id: f469971e448dbca12afe141b43fa8a2518c7d467
Configuration menu - View commit details
-
Copy full SHA for 48f30ec - Browse repository at this point
Copy the full SHA 48f30ecView commit details -
Android: Fix clipping of text which contains unicode emoticons on And…
…roid 4.4.2 Summary: Fixes #11592 This bug was seen on a Galaxy S4 running Android 4.4.2. On this device, Android's `Layout.getDesiredWidth` method doesn't correctly measure text that contains unicode emoticons. It appears to think the emoticons take up 0 space. Setting ANTI_ALIAS_FLAG in the TextPaint's constructor instead of setting it later with setFlags works around the Android bug. **Test plan (required)** My team uses this fix in our app. Adam Comella Microsoft Corp. Closes #12690 Differential Revision: D4673649 Pulled By: mkonicek fbshipit-source-id: 535f371281927bfff5d8b42966496bc8daf30045
Configuration menu - View commit details
-
Copy full SHA for 4c7576e - Browse repository at this point
Copy the full SHA 4c7576eView commit details -
Summary: 04d870b added support for onabort in XHRs. The other on* events are declared on XMLHttpRequest and XMLHttpRequestEventTarget. This adds onabort there as well. Adam Comella Microsoft Corp. Closes #12277 Differential Revision: D4673648 Pulled By: mkonicek fbshipit-source-id: 0c5255da77537103c5ad91d9b2826d064140708d
Configuration menu - View commit details
-
Copy full SHA for 36f09dc - Browse repository at this point
Copy the full SHA 36f09dcView commit details -
iOS: Expose fontScale to JavaScript
Summary: A related Android PR is #11008. Font scale was exposed through: - The `getContentSizeMultiplier` method - The `didUpdateContentSizeMultiplier` event These are now deprecated. The reason is that there was already an API that exposed font scale. However, it was Android only. We now expose font scale through that API on iOS as well. Specifically: - Font scale is now available as `PixelRatio.getFontScale()`. - The `change` event on the `Dimensions` object now fires when font scale changes. This change also adds support for `Dimensions.get('screen')` on iOS. Previously, only `Dimensions.get('window')` was available on iOS. The motivation is that, [according to this comment](#11008 (comment)), we'd like to deprecate `window` dimensions in favor of `screen` dimensions in the future. **Test plan (required)** Verified that `PixelRatio.getFontScale()` and the `change` event work properly in a test app. Adam Comella Microsoft Corp. Closes #12268 Differential Revision: D4673642 Pulled By: mkonicek fbshipit-source-id: 2602204da6998a96216e06f5321f28f6603e4972
Configuration menu - View commit details
-
Copy full SHA for 22b3faf - Browse repository at this point
Copy the full SHA 22b3fafView commit details -
BREAKING: iOS: Support withCredentials flag in XHRs
Summary: Corresponding Android PR: #12276 Respect the withCredentials XMLHttpRequest flag for sending cookies with requests. This can reduce payload sizes where large cookies are set for domains. This should fix #5347. This is a breaking change because it alters the default behavior of XHR. Prior to this change, XHR would send cookies by default. After this change, by default, XHR does not send cookies which is consistent with the default behavior of XHR on web for cross-site requests. Developers can restore the previous behavior by passing `true` for XHR's `withCredentials` argument. **Test plan (required)** Verified in a test app that XHR works properly when specifying `withCredentials` as `true`, `false`, and `undefined`. Also, my team uses this change in our app. Adam Comella Microsoft Corp. Closes #12275 Differential Revision: D4673644 Pulled By: mkonicek fbshipit-source-id: 2fd8f536d02fb39d872eb849584c5c4f7e7698c5
Configuration menu - View commit details
-
Copy full SHA for 454ab8f - Browse repository at this point
Copy the full SHA 454ab8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36eb69e - Browse repository at this point
Copy the full SHA 36eb69eView commit details -
BREAKING - Remove LayoutAnimation experimental flag on Android
Summary: I don't remember exactly where we talked about this but LayoutAnimation on Android is pretty stable now so there's no reason to keep it behind an experimental flag anymore. The only part that is not really stable is delete animations, so what I did is remove the default delete animation that we provide in presets. **Test plan** Tested that layout animations work properly without any config. Closes #12141 Differential Revision: D4494386 Pulled By: mkonicek fbshipit-source-id: 5dd025584e35f9bff25dc299cc9ca5c5bf5f17a3
Configuration menu - View commit details
-
Copy full SHA for abc483a - Browse repository at this point
Copy the full SHA abc483aView commit details -
Updating the documentation for getSize()
Summary: Clearly state that the `getSize()` does not work for static image resources because it is assumed the developer knows their static image resource size (the reason I got from a comment on a github issue by a react native contributor). This missing documentation cost me about 30 minutes to figure out why it didn't work for my static image resource and so I decided to update the documentation 💃 Closes #11645 Differential Revision: D4533463 Pulled By: lacker fbshipit-source-id: 70e175ea30a5540c8a9f2a0c040585c711d82ac3
Configuration menu - View commit details
-
Copy full SHA for 0150bc7 - Browse repository at this point
Copy the full SHA 0150bc7View commit details -
packager: node-haste: remove use of HasteMap class
Reviewed By: davidaurelio Differential Revision: D4658741 fbshipit-source-id: 951c96df174c79a00b3cff102b3dda75abd4ef99
Configuration menu - View commit details
-
Copy full SHA for a435fbc - Browse repository at this point
Copy the full SHA a435fbcView commit details -
packager: node-haste: cleanup the load() function
Reviewed By: davidaurelio Differential Revision: D4659391 fbshipit-source-id: a83e218ba89ad459fed07a4dfb61c422a6b4db5d
Configuration menu - View commit details
-
Copy full SHA for 0ff379b - Browse repository at this point
Copy the full SHA 0ff379bView commit details -
UIExplorer test: wait for packager by polling its status
Reviewed By: ericvicenti Differential Revision: D4674436 fbshipit-source-id: c9673f85a764207f108c6e2282503e8c3201c97e
Configuration menu - View commit details
-
Copy full SHA for c5e2cf7 - Browse repository at this point
Copy the full SHA c5e2cf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f637936 - Browse repository at this point
Copy the full SHA f637936View commit details
Commits on Mar 9, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 3672b20 - Browse repository at this point
Copy the full SHA 3672b20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b146cd - Browse repository at this point
Copy the full SHA 3b146cdView commit details -
Update the date for this blog post
Reviewed By: ericvicenti, gfosco Differential Revision: D4677339 fbshipit-source-id: bc27de3ad294215f969311b51a02b080a5be52d6
Configuration menu - View commit details
-
Copy full SHA for ddc4f8a - Browse repository at this point
Copy the full SHA ddc4f8aView commit details -
don't obfuscate CxxModule names
Reviewed By: mhorowitz Differential Revision: D4677275 fbshipit-source-id: 990e2e6338d76e283a1bc44d4991140560d1b101
Configuration menu - View commit details
-
Copy full SHA for 1269f1e - Browse repository at this point
Copy the full SHA 1269f1eView commit details -
Setting
availableSize
forRCTRootShadowView
on earlier stageSummary: Moving setting `availableSize` for `RCTRootShadowView` on earlier stage allows to prevent situations where `availableSize` is not specified yet, but Yoga layout is already happening. Because `availableSize` equals {infinity, infinity} by default (in this case), Yoga returns a lot of nodes with infinit metrics, which confises UIKit. Reviewed By: mmmulani Differential Revision: D4672170 fbshipit-source-id: f9d8c84799dcbdb6b9230ddef6284d84df268833
Configuration menu - View commit details
-
Copy full SHA for 264d60b - Browse repository at this point
Copy the full SHA 264d60bView commit details -
remove dup TRACE_TAG_REACT_APPS
Summary: Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: > **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.** Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see Closes #12818 Differential Revision: D4680312 Pulled By: AaaChiuuu fbshipit-source-id: d8410e99c3ced4e2c94145186a450923029d5b22
Configuration menu - View commit details
-
Copy full SHA for 07153dd - Browse repository at this point
Copy the full SHA 07153ddView commit details -
Reviewed By: gfosco Differential Revision: D4679649 fbshipit-source-id: ab363e6dc91cd855c0cd6111c64feda88ea9bba9
Configuration menu - View commit details
-
Copy full SHA for 8d6776c - Browse repository at this point
Copy the full SHA 8d6776cView commit details -
UIExplorer e2e: fix duplicated exit trap
Summary: I accidentally introduced an exit trap, allthough a cleanup handler already existed. This moves killing of background processes into the existing trap. Reviewed By: bestander Differential Revision: D4681289 fbshipit-source-id: f8bcdcac7b246854e3ee024c9335b6c4eb3aacbd
Configuration menu - View commit details
-
Copy full SHA for 21c2291 - Browse repository at this point
Copy the full SHA 21c2291View commit details -
Take margin into account on max dimension
Summary: We need to take the margin into account if we clip on max dimension. Fixes #466. Closes facebook/yoga#467 Differential Revision: D4681342 Pulled By: emilsjolander fbshipit-source-id: 56311df9864a284d553c31f1c6db382f337f1fad
Configuration menu - View commit details
-
Copy full SHA for 751addc - Browse repository at this point
Copy the full SHA 751addcView commit details -
ScrollView should not use RefreshControl on tvOS
Summary: **Motivation**: On tvOS, Flatview and other components that use ScrollView with a RefreshControl will break without this change. **Test plan**: Manual testing on tvOS simulator. Closes #12751 Differential Revision: D4669503 fbshipit-source-id: 320036571788dc0102ec2611492d0fc97bceb53b
Configuration menu - View commit details
-
Copy full SHA for f5585b3 - Browse repository at this point
Copy the full SHA f5585b3View commit details -
Move pointscalefactor to config
Summary: This adds some improvements to the new ```YGConfig```, it tackles #452 and moves the scalefactor into the config. Closes facebook/yoga#457 Differential Revision: D4675088 Pulled By: emilsjolander fbshipit-source-id: 99b2c734d6c5139fe1dc8bdeb014bb038f0e337d
Configuration menu - View commit details
-
Copy full SHA for 9c6da27 - Browse repository at this point
Copy the full SHA 9c6da27View commit details -
Make a section on keyboard shortcuts more prominent
Summary: The note is currently in "Reloading JavaScript". However I was struggling with the first step ("Accessing the In-App Developer Menu") so didn't read down to that section. I think it makes sense to make this the very first thing the reader sees when visiting the page. Closes #12828 Differential Revision: D4681842 Pulled By: hramos fbshipit-source-id: 1afbec7f62a2ec97febdd05987e7fc1541d3ee28
Configuration menu - View commit details
-
Copy full SHA for a94d14c - Browse repository at this point
Copy the full SHA a94d14cView commit details -
Update 2016-12-05-easier-upgrades.md
Summary: > The logic behind react-native-git-upgrade described above is going to power the standard react-native upgrade starting with React Native version 0.40.0. This means that if you are upgrading from version 0.40.0 or higher, you will be able to simply run react-native upgrade in your project without having to install anything globally. I hadn't seen any logic related to this description in either practice nor [the source code](https://github.com/facebook/react-native/blob/master/local-cli/upgrade/upgrade.js) . Did I misunderstand anything or the plan has been changed since this blog post? ncuillery Closes #12758 Differential Revision: D4681959 Pulled By: mkonicek fbshipit-source-id: 782d243bd92e51cbfcf83995fdcbb569fcb7bbc1
Configuration menu - View commit details
-
Copy full SHA for 0429b6b - Browse repository at this point
Copy the full SHA 0429b6bView commit details -
Summary: Following ericvicenti request on #10188 (comment) Hope it helps Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: > **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.** Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also Closes #12578 Differential Revision: D4682076 Pulled By: mkonicek fbshipit-source-id: 2fab5355a066eb3d8333e50f07ab3a258cbc002b
Configuration menu - View commit details
-
Copy full SHA for b79a246 - Browse repository at this point
Copy the full SHA b79a246View commit details -
Summary: Typo documentation ScrollView: 'as as alternative' => 'as an alternative' Closes #12826 Differential Revision: D4681930 Pulled By: mkonicek fbshipit-source-id: a10574c659c949359da0be9e6e82f597e9a3eb73
Configuration menu - View commit details
-
Copy full SHA for a592e5b - Browse repository at this point
Copy the full SHA a592e5bView commit details -
Showcase is now fully managed by OSS team at fb, update comment
Reviewed By: mkonicek Differential Revision: D4682340 Ninja: OSS only fbshipit-source-id: ddeed5d267fd4999e16061c7b847fe163337e283
Configuration menu - View commit details
-
Copy full SHA for e5ebdd8 - Browse repository at this point
Copy the full SHA e5ebdd8View commit details -
Show bundle loading progress on Android
Summary: This implements a loading banner like on iOS that shows the progress of the packager. ![](https://media.giphy.com/media/l4FGoepExkpOeXtTO/giphy.gif) **Test plan** - Tested that it displays similar messages as it does on iOS and also that is show the right message when waiting for the remote debugger. - Tested that errors are still shown properly. - Tested that it works with packagers that don't support multipart response (add && false in https://github.com/facebook/react-native/blob/master/packager/src/Server/MultipartResponse.js#L81). - Run new unit tests. - Tested that backgrounding / foregrounding the app hides / show the banner properly. Closes #12674 Differential Revision: D4673638 Pulled By: mkonicek fbshipit-source-id: b2a1163de3d0792cf481d7111231a065f80a9594
Configuration menu - View commit details
-
Copy full SHA for 231bf7c - Browse repository at this point
Copy the full SHA 231bf7cView commit details -
Fix cookies not being sent with <Image> network requests
Reviewed By: pvulgaris Differential Revision: D4669967 fbshipit-source-id: d26da8d3a60f71cf3751eb1c73974b0e57e59bed
Configuration menu - View commit details
-
Copy full SHA for d2796ea - Browse repository at this point
Copy the full SHA d2796eaView commit details -
Allow Promise to display error strings and not just error objects.
Summary: Closes #9989 Reviewed By: bestander Differential Revision: D4147256 Pulled By: hramos fbshipit-source-id: 62d49b592391bad434062e3c0d9c8287842664a8
Configuration menu - View commit details
-
Copy full SHA for bfb2766 - Browse repository at this point
Copy the full SHA bfb2766View commit details -
Native Animated - Support multiple events attached to the same prop
Summary: Re-applying the diff that was reverted in D4659669 / b87f4ab because of some crashes with fixes from D4659708 merged in. --- Fixes a bug that happens when trying to use ScrollView with sticky headers and native `Animated.event` with `onScroll`. Made a few changes to the ListViewPaging UIExplorer example to repro https://gist.github.com/janicduplessis/17e2fcd99c6ea49ced2954d881011b09. What happens is we need to be able to add multiple events to the same prop + viewTag pair. To do that I simple changed the data structure to `Map<prop+viewTag, List<AnimatedEventDriver>>` and try to optimize for the case where there is only one item in the list since it will be the case 99% of the time. **Test plan** Tested by reproducing the bug with the above gist and made sure it was fixed after applying this diff. Closes #12697 Reviewed By: fkgozali Differential Revision: D4661105 Pulled By: sahrens fbshipit-source-id: c719dc85f45c1a142ef5b9ebfe0a82ae8ec66497
Configuration menu - View commit details
-
Copy full SHA for 921b9ac - Browse repository at this point
Copy the full SHA 921b9acView commit details -
YellowBox" Only provide elevation style prop when running on Android
Summary: For unknown reasons, setting elevation: Number.MAX_VALUE causes remote debugging to hang on iOS (some sort of overflow maybe). Setting it to Number.MAX_SAFE_INTEGER fixes the iOS issue, but since elevation is an android-only style property we might as well remove it altogether for iOS. See: #12223 Closes #12744 Differential Revision: D4684524 Pulled By: mkonicek fbshipit-source-id: 7fb4f6da1c5c0cb437beff0e75122523e7233b72
Configuration menu - View commit details
-
Copy full SHA for dd5ac84 - Browse repository at this point
Copy the full SHA dd5ac84View commit details
Commits on Mar 10, 2017
-
Configuration menu - View commit details
-
Copy full SHA for ac92d3e - Browse repository at this point
Copy the full SHA ac92d3eView commit details -
Reviewed By: javache Differential Revision: D4588356 fbshipit-source-id: ac13bbef8252ce87cdccc2f2d32890e94ff022fb
Configuration menu - View commit details
-
Copy full SHA for b47000a - Browse repository at this point
Copy the full SHA b47000aView commit details -
Revert D4494386: [react-native][PR] BREAKING - Remove LayoutAnimation…
… experimental flag on Android Differential Revision: D4494386 fbshipit-source-id: 1ba6fc60467d1c3347c90e52a3251e6591a99e25
Configuration menu - View commit details
-
Copy full SHA for 28ed5ed - Browse repository at this point
Copy the full SHA 28ed5edView commit details -
native animated scroll event support
Reviewed By: yungsters Differential Revision: D4648383 fbshipit-source-id: fdb8e2deaa06b2d2f9002cee2c0b827dbd7a5570
Configuration menu - View commit details
-
Copy full SHA for 5177a55 - Browse repository at this point
Copy the full SHA 5177a55View commit details -
packager: Resolver: make the Resolver construction a Promise
Reviewed By: cpojer Differential Revision: D4681614 fbshipit-source-id: 5da558280edf300f67042e72c65b272e49351871
Configuration menu - View commit details
-
Copy full SHA for 1030aab - Browse repository at this point
Copy the full SHA 1030aabView commit details -
packager: node-haste: async load()
Reviewed By: cpojer Differential Revision: D4673384 fbshipit-source-id: 816529f8947079b4003c8e91443e221184fd589d
Configuration menu - View commit details
-
Copy full SHA for 0c46953 - Browse repository at this point
Copy the full SHA 0c46953View commit details -
Update Boost dependency on Android to 1.63
Summary: We use this version internally. Closes #12837 Differential Revision: D4688986 Pulled By: mkonicek fbshipit-source-id: 93d9dedb51a56d6104aae443e939455c44397e88
Configuration menu - View commit details
-
Copy full SHA for 193afff - Browse repository at this point
Copy the full SHA 193afffView commit details -
Update Boost dependency to 1.63 on iOS
Summary: We use this version internally. Closes #12838 Differential Revision: D4688982 Pulled By: mkonicek fbshipit-source-id: d8a6f8168b9e71ff4f53a8c18d55dc5a759a9183
Configuration menu - View commit details
-
Copy full SHA for 5c24a91 - Browse repository at this point
Copy the full SHA 5c24a91View commit details -
Revert D4588356: Refactor dependencies
Differential Revision: D4588356 fbshipit-source-id: 88cd348ed10cbf51e8ea4cde7503f6e0f9e6c572
Configuration menu - View commit details
-
Copy full SHA for f0394ce - Browse repository at this point
Copy the full SHA f0394ceView commit details -
Align resolve function names to have similiar namings
Summary: We have some resolve functions with ```YG**Resolve``` and others named ```YGResolve**```. This changes both to be named like the later one, as I think this is the grammatically better readable one. Closes facebook/yoga#471 Differential Revision: D4688997 Pulled By: emilsjolander fbshipit-source-id: 38b5f84d4d39ed3effedf08188085b9efd96b4ce
Configuration menu - View commit details
-
Copy full SHA for 75e783d - Browse repository at this point
Copy the full SHA 75e783dView commit details -
Clear Fresco memory cache in onHostDestroy
Summary: `onHostDestroy` is when the app is backgrounded and all Activities are destroyed. At this point it's safe to clear Fresco's memory cache. Reviewed By: AaaChiuuu Differential Revision: D4674950 fbshipit-source-id: f6db658ad56e3ad843cd2acfa31e2df1c40d3279
Configuration menu - View commit details
-
Copy full SHA for d9ae27b - Browse repository at this point
Copy the full SHA d9ae27bView commit details -
packager: Resolver: remove opt defaults, simplify load()
Summary: Not having default everywhere (keeping them at the top level instead) makes for a code that is easier to understand, and more robust as different pieces of code cannot default to different values. This changeset also unifies the option types (ex. `platform`). Reviewed By: cpojer Differential Revision: D4688882 fbshipit-source-id: b5f407601386336f937a0ac1f68c666acc89dfd8
Configuration menu - View commit details
-
Copy full SHA for 3e1542b - Browse repository at this point
Copy the full SHA 3e1542bView commit details -
Reviewed By: mkonicek Differential Revision: D4689351 fbshipit-source-id: 35e6939379dcb6723e7749883ad9613459f9787b
Configuration menu - View commit details
-
Copy full SHA for acb9fa8 - Browse repository at this point
Copy the full SHA acb9fa8View commit details -
Use CLOCK_MONOTONIC instead of CLOCK_MONOTONIC_RAW in performanceNow
Reviewed By: AaaChiuuu Differential Revision: D4688909 fbshipit-source-id: 30d02ea6af4cce47bcd4fe41bc1f048dccbb3b2b
Configuration menu - View commit details
-
Copy full SHA for 434ca24 - Browse repository at this point
Copy the full SHA 434ca24View commit details -
packager: verify validity of TTY before using it
Reviewed By: mkonicek Differential Revision: D4689779 fbshipit-source-id: 9bc2c1447bd64ec392adef772b1189a782f83545
Configuration menu - View commit details
-
Copy full SHA for 014eef3 - Browse repository at this point
Copy the full SHA 014eef3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30bf039 - Browse repository at this point
Copy the full SHA 30bf039View commit details -
Try to fix tvOS and podspec builds
Summary: Closes #12866 Differential Revision: D4691348 Pulled By: ericvicenti fbshipit-source-id: df7d611aa4ed3fed6158d2210a0403c90875b7c3
Configuration menu - View commit details
-
Copy full SHA for a8bd462 - Browse repository at this point
Copy the full SHA a8bd462View commit details -
Configuration menu - View commit details
-
Copy full SHA for f28f5d3 - Browse repository at this point
Copy the full SHA f28f5d3View commit details -
Update ListView sticky header docs
Summary: Sticky headers work on android now, but are only enabled by default on ios, so reflect that in the docs. cc janicduplessis Closes #12860 Differential Revision: D4691071 fbshipit-source-id: 0e28f948dc587561b6f20c3615cdf65dfebd9b73
Configuration menu - View commit details
-
Copy full SHA for 82ff298 - Browse repository at this point
Copy the full SHA 82ff298View commit details -
Fix indent for .babelrc in HelloWorld template
Summary: Minor code formatting. Each time I run `react-native init` I must reindent this file. Closes #12850 Differential Revision: D4691374 fbshipit-source-id: dc02b021e2f320f1046e4e6d024ba675a4213de8
Configuration menu - View commit details
-
Copy full SHA for 68695bd - Browse repository at this point
Copy the full SHA 68695bdView commit details
Commits on Mar 11, 2017
-
Add systemJSCWrapper.cpp to React-tvOS target
Summary: **Motivation**: Fix Apple TV build breakage **Test plan**: This fixes Travis test that builds tvOS targets. Closes #12869 Differential Revision: D4692883 fbshipit-source-id: 3babfe4ab6d80143e15410bff7cae41ada3bf09f
Configuration menu - View commit details
-
Copy full SHA for 02a6621 - Browse repository at this point
Copy the full SHA 02a6621View commit details -
measure conversion of Java Map to WritableNativeMap for each NativeMo…
…dule Reviewed By: fkgozali Differential Revision: D4688690 fbshipit-source-id: 871b3f5ab141d7f63ec15b06e44a2c398603d757
Configuration menu - View commit details
-
Copy full SHA for 70e4a58 - Browse repository at this point
Copy the full SHA 70e4a58View commit details
Commits on Mar 12, 2017
-
Fix wrong modal size in fullscreen
Summary: Display.getCurrentSizeRange() doesn't include the size of the status bar, so Modal windows on Android have a gap in the bottom that is the same size as the status bar. This checks the current theme and adds the size of status bar to the modal window height if necessary. **Test plan (required)** Run a React Native app on Android with a theme that doesn't show status bar and launch a modal dialog. See issue #11872 for an example. Closes #11928 Differential Revision: D4695847 fbshipit-source-id: 9fafc2b5040e2f58d562c9cc4cd4d6d87b0df2a3
Configuration menu - View commit details
-
Copy full SHA for 8ba06cb - Browse repository at this point
Copy the full SHA 8ba06cbView commit details
Commits on Mar 13, 2017
-
packager: Bundler: refactor the maxWorkerCount
Summary: The function giving the worker count was duplicated, let's just pass it down from a central place, the Bundler. Also, I simplified the function to use a simple formula rather than arbitrary ranges (it's still arbitrary, just a tad bit less :D ). Reviewed By: davidaurelio Differential Revision: D4689366 fbshipit-source-id: fe5b349396f1a07858f4f80ccaa63c375122fac8
Configuration menu - View commit details
-
Copy full SHA for 76f5b96 - Browse repository at this point
Copy the full SHA 76f5b96View commit details -
Expose getter for 'flex' property
Summary: Helps mitigate part of #12245 while we wait for a more comprehensive solution. Reviewed By: emilsjolander Differential Revision: D4571776 fbshipit-source-id: 185cd1b0d3af37724136a37471df412c2000dfe4
Configuration menu - View commit details
-
Copy full SHA for 41f3d0c - Browse repository at this point
Copy the full SHA 41f3d0cView commit details -
packager: Server: make buildBundle() async
Summary: Also remove the unnecessary await of the resolver, because `_bundler.bundle()` already does that. Reviewed By: davidaurelio Differential Revision: D4689448 fbshipit-source-id: 3b4fd73b1368f8b00c6eb7483e751387d9856ce9
Configuration menu - View commit details
-
Copy full SHA for ac452c0 - Browse repository at this point
Copy the full SHA ac452c0View commit details -
Rename *Component props to match SectionList
Reviewed By: yungsters Differential Revision: D4697335 fbshipit-source-id: 742b7a1729ba7a08fe3d9707bcf6c51026779739
Configuration menu - View commit details
-
Copy full SHA for 3ce31c2 - Browse repository at this point
Copy the full SHA 3ce31c2View commit details -
Reviewed By: ericvicenti, gfosco Differential Revision: D4679678 fbshipit-source-id: c1088390a44540e8934666e0ffdd43a3e170de32
Configuration menu - View commit details
-
Copy full SHA for 67a8d89 - Browse repository at this point
Copy the full SHA 67a8d89View commit details -
Fixes spelling mistake inside TouchableNativeFeedback.android.js
Summary: Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: > **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.** Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see Closes #12901 Differential Revision: D4699296 Pulled By: hramos fbshipit-source-id: 514ae27c47c8ae22e1aadb99a787daa6fdc3b6a4
Configuration menu - View commit details
-
Copy full SHA for 2976aa1 - Browse repository at this point
Copy the full SHA 2976aa1View commit details -
More accurate implementation of
RCTRootView
'ssizeThatFits:
Reviewed By: mmmulani Differential Revision: D4672788 fbshipit-source-id: 780487f2264916349e32785808a93ed6f957e471
Configuration menu - View commit details
-
Copy full SHA for 98798a0 - Browse repository at this point
Copy the full SHA 98798a0View commit details -
Summary: Closes #12868 Differential Revision: D4699900 Pulled By: hramos fbshipit-source-id: b531f2359734177df1868b453dd1d882e693caa3
Configuration menu - View commit details
-
Copy full SHA for 103fa3d - Browse repository at this point
Copy the full SHA 103fa3dView commit details -
Better TextInput: RCTTextView and RCTTextField was marked as Yoga lea…
…f nodes Reviewed By: mmmulani Differential Revision: D4639060 fbshipit-source-id: d4580303a61a7f86cf8bb6ec016fd9834340ffe0
Configuration menu - View commit details
-
Copy full SHA for fa30f41 - Browse repository at this point
Copy the full SHA fa30f41View commit details