Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native run-android no longer supports --configuration=release #12698

Closed
sungwoncho opened this issue Mar 4, 2017 · 6 comments
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@sungwoncho
Copy link

Description

Documentation for Testing the release build of your app for Android seems to be outdated.

Concretely, the flag --configuration does not exist anymore.

Reproduction

Running react-native run-android --configuration=release gives me:

  error: unknown option `--configuration'

Solution

Replacing configuration flag with variant flag works.

react-native run-android --variant=release

Additional Information

  • React Native version: 0.42.0
  • Platform: Android
  • Operating System: MacOS 10.12.3
facebook-github-bot pushed a commit that referenced this issue Mar 4, 2017
Summary:
**Motivation**

Documentation was referring to an outdated command line flag for building a signed APK. #12698

**Test plan**

This PR does not contain any code changes.
Closes #12699

Differential Revision: D4655915

fbshipit-source-id: fdad86e0be60929525172022980f1950c8b0188d
@laalaguer
Copy link

Shall we update the official tutorial as well? it still contains outdated info here:
https://facebook.github.io/react-native/docs/signed-apk-android.html

@sungwoncho
Copy link
Author

@laalaguer I fixed this in #12699 but it seems that the doc has not been released yet. Let's close this when the updated version is released.

@wedelgaard
Copy link

@sungwoncho not updated in 0.43 :/

@fauna5
Copy link

fauna5 commented Apr 13, 2017

Just tripped over this too. Would be great to update it

@sungwoncho
Copy link
Author

sungwoncho commented Apr 14, 2017

@janicduplessis #12699 was merged but doc has not been updated. Any action required to ship the updated docs?

@hramos
Copy link
Contributor

hramos commented Jul 25, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos closed this as completed Jul 25, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 25, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

7 participants