Remove unused native iOS sticky headers implementation #12696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
I'm excited to see this code cleaned up! |
facebook-github-bot
added
GH Review: accepted
Import Started
|
@ericvicenti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
dojiboy9
pushed a commit
to dojiboy9/react-native
that referenced
this pull request
Mar 18, 2017
Summary: Remove the native iOS sticky headers implementation that has been replaced by the js Animated one. Also remove a line in JS that made sure we passed null to native so it did not use the native implementation. **Test plan** Made sure there were no more mentions of sticky / header in native ScrollView related code. Tested that sticky headers still work :o Closes facebook#12696 Differential Revision: D4657391 Pulled By: ericvicenti fbshipit-source-id: 16324a45ca4ce5cd143293c61394a0fa7ad0c4a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the native iOS sticky headers implementation that has been replaced by the js Animated one. Also remove a line in JS that made sure we passed null to native so it did not use the native implementation.
Test plan
Made sure there were no more mentions of sticky / header in native ScrollView related code.
Tested that sticky headers still work :o