Website: Fix aspect ratio of icons in the showcase on homepage #12773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Good catch, thanks! |
facebook-github-bot
added
GH Review: accepted
Import Started
|
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
hramos
pushed a commit
that referenced
this pull request
Mar 9, 2017
Summary: I ran the website locally and noticed the icons in the showcase on the homepage look squashed:  Made the icons consistent with /showcase.html: https://github.com/facebook/react-native/blob/d54c7f82822f623a903858d8d686d7f14ec71aae/website/styles/_showcase.scss#L74 Closes #12773 Differential Revision: D4669767 Pulled By: hramos fbshipit-source-id: be5a758dd912083fc02c8e0b56c30c8617dcf3df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran the website locally and noticed the icons in the showcase on the homepage look squashed:
Made the icons consistent with /showcase.html:
react-native/website/styles/_showcase.scss
Line 74 in d54c7f8
Test plan: