Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stable to v2.7.0 #723

Merged
merged 24 commits into from
Oct 17, 2024
Merged

Update stable to v2.7.0 #723

merged 24 commits into from
Oct 17, 2024

Conversation

HumairAK
Copy link
Contributor

Update stable to v2.7.0

HumairAK and others added 24 commits September 30, 2024 12:52
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
remove unncessary release test gh workflow
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Add support for using route or service as target endpoints in the test suite
This will include all the changes from the kfp 2.2.0 release

Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
Accomodate changes for KFP 2.2 upgrade
Added secrets::list permissions to pipeline runner
Signed-off-by: Giulio Frasca <gfrasca@redhat.com>
Co-authored-by: Francisco Arceo <farceo@redhat.com>
Reuse WaitFor function to ensure DSPA is ready
The DSP apiserver implements TLS by relying on the OpenShift
service cert signer. In order to get this to work nicely with
our openshift-oauth sidecar, we set the Kubernetes service as
the upstream for the oauth container. This means that all incoming
traffic to DSP goes like this:
`client -> DSP service -> DSP oauth -> DSP service -> DSP apiserver`
DSP oauth and DSP apiserver are in the same pod. We haven't explicitly
created a NetworkPolicy to allow that, but it works on AWS and
OpenStack-based clusters. For some yet to be determined reason,
it doesn't work on IBM / Calico / Secure-By-Default clusters.

Add a NetworkPolicy entry to allow the DSP pod to talk to itself
on 8888 and 8887. This fixes the issue where DSP(oauth) can't talk
to DSP(apiserver) via the service (that fronts both containers /
the pod).

Fixes: https://issues.redhat.com/browse/RHOAIENG-14571

Signed-off-by: Greg Sheremeta <gshereme@redhat.com>
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
…-traffic-np

fix: add NetworkPolicy for DSP apiserver pod self traffic
Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from humairak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit 53336ab into opendatahub-io:stable Oct 17, 2024
10 of 14 checks passed
@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-723
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/723/head
git checkout -b pullrequest 998859f4b22bbbbb0a52adaf271f1037c978ba9d
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-723"

More instructions here on how to deploy and test a Data Science Pipelines Application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants