New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accomodate changes for KFP 2.2 upgrade #684

Merged

HumairAK merged 1 commit into opendatahub-io:main from rimolive:kfp-rebase

Oct 8, 2024

Contributor

rimolive commented Aug 12, 2024 •

edited

Loading

This will include all the changes from the kfp 2.2.0 release

The issue resolved by this Pull Request:

Resolves #RHOAIENG-6670

Description of your changes:

Testing instructions

Checklist

The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

openshift-ci bot requested review from gmfrasca and gregsheremeta

August 12, 2024 17:35

Contributor

openshift-ci bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rimolive. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rimolive changed the title ~~Prepare to upgrade to the next DSP Release~~ WIP: Prepare to upgrade to the next DSP Release

openshift-ci bot added the do-not-merge/work-in-progress label

Contributor

dsp-developers commented Aug 12, 2024

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-684
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/684/head
git checkout -b pullrequest 1bd1e19b7d595100f5b843931d3edf1ac65e37f7
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-684"

More instructions here on how to deploy and test a Data Science Pipelines Application.

HumairAK changed the title ~~WIP: Prepare to upgrade to the next DSP Release~~ WIP: Accomodate changes for KFP 2.2 upgrade

rimolive force-pushed the kfp-rebase branch from 1bd1e19 to acd6b28 Compare

September 2, 2024 14:15

Contributor

dsp-developers commented Sep 2, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-684

rimolive force-pushed the kfp-rebase branch from acd6b28 to a5f7be9 Compare

September 2, 2024 14:52

Contributor

dsp-developers commented Sep 2, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-684

rimolive force-pushed the kfp-rebase branch from a5f7be9 to d1aed03 Compare

September 2, 2024 14:57

Contributor

dsp-developers commented Sep 2, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-684

rimolive force-pushed the kfp-rebase branch from d1aed03 to 13a5e69 Compare

September 2, 2024 15:01

Contributor

dsp-developers commented Sep 2, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-684

rimolive force-pushed the kfp-rebase branch from 13a5e69 to dfb0987 Compare

September 5, 2024 15:30

Contributor

dsp-developers commented Sep 5, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-684

rimolive force-pushed the kfp-rebase branch from dfb0987 to 4dc8257 Compare

September 6, 2024 14:23

Contributor

dsp-developers commented Sep 6, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-684

rimolive force-pushed the kfp-rebase branch 2 times, most recently from ecc5df8 to 540c6b6 Compare

September 6, 2024 14:53

Contributor

dsp-developers commented Sep 6, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-684

1 similar comment

Contributor

dsp-developers commented Sep 6, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-684

rimolive force-pushed the kfp-rebase branch from 540c6b6 to f88f7cf Compare

September 7, 2024 14:49

Contributor

dsp-developers commented Sep 7, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-684

rimolive force-pushed the kfp-rebase branch from f88f7cf to 22a62b1 Compare

September 16, 2024 14:20

rimolive force-pushed the kfp-rebase branch from 22a62b1 to 2a4681c Compare

October 8, 2024 17:42

Contributor

dsp-developers commented Oct 8, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-684

HumairAK changed the title ~~WIP: Accomodate changes for KFP 2.2 upgrade~~ Accomodate changes for KFP 2.2 upgrade

openshift-ci bot removed the do-not-merge/work-in-progress label

HumairAK reviewed

View reviewed changes

config/internal/apiserver/default/kfp_launcher_config.yaml.tmpl Outdated Show resolved Hide resolved


          Accomodate changes for KFP 2.2.0 upgrade

622249a

This will include all the changes from the kfp 2.2.0 release

Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>

rimolive force-pushed the kfp-rebase branch from 2a4681c to 622249a Compare

October 8, 2024 18:32

Contributor

dsp-developers commented Oct 8, 2024

Change to PR detected. A new PR build was completed.
A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-684

Contributor

openshift-ci bot commented Oct 8, 2024

@rimolive: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/integration-test-odh-dspo	`622249a`	link	true	`/test integration-test-odh-dspo`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

gmfrasca reviewed

View reviewed changes

Member

gmfrasca left a comment

/lgtm

openshift-ci bot assigned gmfrasca

openshift-ci bot added the lgtm label

HumairAK merged commit 0394f6f into opendatahub-io:main

5 of 7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm