-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added secrets::list permissions to pipeline runner #715
Conversation
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/715/head
git checkout -b pullrequest 026f94582c96d500acf18e9d30b82ec31bdeb968
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-715" More instructions here on how to deploy and test a Data Science Pipelines Application. |
026f945
to
57d98d9
Compare
Change to PR detected. A new PR build was completed. |
57d98d9
to
ec92016
Compare
Change to PR detected. A new PR build was completed. |
ec92016
to
2e3409f
Compare
Change to PR detected. A new PR build was completed. |
@diegolovison: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failure seems unrelated to the change.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves https://issues.redhat.com/browse/RHOAIENG-13630
Description of your changes:
Added secrets::list permissions to pipeline runner
Testing instructions
Run a Ray Integration pipeline
Checklist