Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse WaitFor function to ensure DSPA is ready #714

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

diegolovison
Copy link
Contributor

@diegolovison diegolovison commented Oct 7, 2024

The issue resolved by this Pull Request:

Resolves https://issues.redhat.com/browse/RHOAIENG-10212

Description of your changes:

Support --endpoint-type and refactor the test suite to allow reusing the WaitFor function

Testing instructions

kind: No manual testing required.
rhoai: sh run_robot_test.sh --set-urls-variables true --extra-robot-args '-L DEBUG -i ODS-2632' --skip-oclogin ( it passed )

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@diegolovison diegolovison marked this pull request as ready for review October 7, 2024 16:37
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

.github/scripts/tests/tests.sh Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm label Oct 8, 2024
Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

@diegolovison: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-test-odh-dspo 14d6530 link true /test integration-test-odh-dspo

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm label Oct 9, 2024
@HumairAK
Copy link
Contributor

nicely done!
/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, jgarciao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit faba0b7 into opendatahub-io:main Oct 11, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants